Skip to content

Update doc/ca.pod to clarify description for dates#3895

Closed
InfoHunter wants to merge 1 commit intoopenssl:masterfrom
InfoHunter:ca-doc
Closed

Update doc/ca.pod to clarify description for dates#3895
InfoHunter wants to merge 1 commit intoopenssl:masterfrom
InfoHunter:ca-doc

Conversation

@InfoHunter
Copy link
Copy Markdown
Member

@InfoHunter InfoHunter commented Jul 9, 2017

"Note" part is based on PR #3566

Checklist
  • documentation is added or updated

FdaSilvaYY
FdaSilvaYY reviewed Jul 9, 2017
View reviewed changes
doc/man1/ca.pod Outdated
Copy link
Copy Markdown
Contributor

@FdaSilvaYY FdaSilvaYY Jul 9, 2017 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

enconded ? ;)
than (year) 2049 ...

Copy link
Copy Markdown
Member Author

@InfoHunter InfoHunter Jul 10, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Errr...

@InfoHunter InfoHunter force-pushed the ca-doc branch 2 times, most recently from f8c8c7f to db4b03c Compare July 10, 2017 03:13
@InfoHunter
Copy link
Copy Markdown
Member Author

InfoHunter commented Jul 10, 2017

commit updated. @FdaSilvaYY

@InfoHunter
Copy link
Copy Markdown
Member Author

InfoHunter commented Jul 12, 2017

Ping @openssl

kaduk
kaduk reviewed Jul 13, 2017
View reviewed changes
doc/man1/ca.pod Outdated
Copy link
Copy Markdown
Contributor

@kaduk kaduk Jul 13, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think s/presented/present/ is better.

doc/man1/ca.pod Outdated
Copy link
Copy Markdown
Contributor

@kaduk kaduk Jul 13, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(ditto)

@InfoHunter
Copy link
Copy Markdown
Member Author

InfoHunter commented Jul 14, 2017

updated: change 'presented' to 'present'

@InfoHunter
Copy link
Copy Markdown
Member Author

InfoHunter commented Jul 14, 2017

Let'e ping @openssl for an OMC approval.

richsalz
richsalz suggested changes Jul 15, 2017
View reviewed changes
doc/man1/ca.pod Outdated
Copy link
Copy Markdown
Contributor

@richsalz richsalz Jul 15, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Call this HISTORY and start it as "Since OpenSSL version 1.1.1, the program follows RFC 5280 and ...."

@InfoHunter
Copy link
Copy Markdown
Member Author

InfoHunter commented Jul 15, 2017

updated based on @richsalz 's comments.

@InfoHunter InfoHunter mentioned this pull request Jul 15, 2017
Closed
@InfoHunter
Copy link
Copy Markdown
Member Author

InfoHunter commented Jul 15, 2017

Delete 'version' to follow #3938

@InfoHunter
Copy link
Copy Markdown
Member Author

InfoHunter commented Jul 15, 2017

Please re-confirm, @kaduk @richsalz

@richsalz
Copy link
Copy Markdown
Contributor

richsalz commented Jul 15, 2017 via email

@dot-asm dot-asm added the approval: done This pull request has the required number of approvals label Jul 16, 2017
@InfoHunter
Copy link
Copy Markdown
Member Author

InfoHunter commented Jul 23, 2017

looks like this could be merged now...

levitte pushed a commit that referenced this pull request Jul 23, 2017
@InfoHunter
Update doc/ca.pod to clarify description for dates
909873b 
"Note" part is based on PR #3566

Reviewed-by: Ben Kaduk <kaduk@mit.edu>
Reviewed-by: Rich Salz <rsalz@openssl.org>
(Merged from #3895)
@richsalz
Copy link
Copy Markdown
Contributor

richsalz commented Jul 23, 2017

thank you!

@richsalz richsalz closed this Jul 23, 2017
@InfoHunter InfoHunter deleted the ca-doc branch July 23, 2017 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

3 more reviewers

@FdaSilvaYY FdaSilvaYY FdaSilvaYY left review comments

@kaduk kaduk kaduk approved these changes

@richsalz richsalz richsalz approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

approval: done This pull request has the required number of approvals

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@InfoHunter @richsalz @kaduk @FdaSilvaYY @dot-asm