Wait longer for the server in TLSProxy to start#3587
Closed
mattcaswell wants to merge 1 commit intoopenssl:masterfrom
Closed
Wait longer for the server in TLSProxy to start#3587mattcaswell wants to merge 1 commit intoopenssl:masterfrom
mattcaswell wants to merge 1 commit intoopenssl:masterfrom
Conversation
In a recent PR (openssl#3566) it seems that TLSProxy gave up trying to connect to the server process too quickly. This meant the test failed even though the server *did* eventually start. Currently we try 3 times to connect with a 0.1 second pause between each attempt. That is probably too aggressive.
2 tasks
levitte
approved these changes
May 31, 2017
levitte
pushed a commit
that referenced
this pull request
May 31, 2017
In a recent PR (#3566) it seems that TLSProxy gave up trying to connect to the server process too quickly. This meant the test failed even though the server *did* eventually start. Currently we try 3 times to connect with a 0.1 second pause between each attempt. That is probably too aggressive. Reviewed-by: Richard Levitte <levitte@openssl.org> (Merged from #3587) (cherry picked from commit 142463c)
Member
Author
|
Pushed. Thanks. |
levitte
pushed a commit
that referenced
this pull request
May 31, 2017
In a recent PR (#3566) it seems that TLSProxy gave up trying to connect to the server process too quickly. This meant the test failed even though the server *did* eventually start. Currently we try 3 times to connect with a 0.1 second pause between each attempt. That is probably too aggressive. Reviewed-by: Richard Levitte <levitte@openssl.org> (Merged from #3587)
pracj3am
pushed a commit
to cdn77/openssl
that referenced
this pull request
Aug 22, 2017
In a recent PR (openssl#3566) it seems that TLSProxy gave up trying to connect to the server process too quickly. This meant the test failed even though the server *did* eventually start. Currently we try 3 times to connect with a 0.1 second pause between each attempt. That is probably too aggressive. Reviewed-by: Richard Levitte <levitte@openssl.org> (Merged from openssl#3587) (cherry picked from commit 142463c)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In a recent PR (#3566) it seems that TLSProxy gave up trying to connect to
the server process too quickly. This meant the test failed even though the
server did eventually start. Currently we try 3 times to connect with a
0.1 second pause between each attempt. That is probably too aggressive.