If tlsext ticket decrypt callback returns error, cleanup ctxs #3273
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tmshort
reviewed
Apr 21, 2017
| return -1; | ||
| goto err; | ||
| if (rv == 0) | ||
| return 2; |
Contributor
There was a problem hiding this comment.
Contexts are not cleaned up in this case as well.
Contributor
Author
There was a problem hiding this comment.
As return value 0 is when key is not matched. In this case, is application expected to call HMAC_Init_ex() and EVP_DecryptInit_ex().
If there is no assumption on this, then yes, need to clean up here as well.
If tlsext ticket decrypt callback returns error, cleanup ctxs
mattcaswell
approved these changes
Aug 21, 2017
Member
mattcaswell
left a comment
There was a problem hiding this comment.
ping @openssl/committers for second review
richsalz
approved these changes
Aug 21, 2017
levitte
pushed a commit
that referenced
this pull request
Jan 24, 2018
If tlsext ticket decrypt callback returns error, cleanup ctxs Reviewed-by: Rich Salz <rsalz@openssl.org> Reviewed-by: Matt Caswell <matt@openssl.org> (Merged from #3273)
Member
|
Merged. Better late than never. Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If application has a TLS ext ticket callback and if the callback returns error while decrypting the ticket the contexts were not cleaned up.
Instead of returning immediately, goto err handles it.
This is taken care in 1.1.0 and in 1.0.2 it is taken care if callback invoked for encryption returns error.