util/mkinstallvars.pl: replace List::Util::pairs with our own#25367
util/mkinstallvars.pl: replace List::Util::pairs with our own#25367levitte wants to merge 2 commits intoopenssl:masterfrom
Conversation
Unfortunately, List::Util::pairs didn't appear in perl core modules before 5.19.3, and our minimum requirement is 5.10. Fortunately, we already have a replacement implementation, and can re-apply it in this script. Fixes openssl#25366
|
@friesoft, @alexdotgov2, please try out this patch |
|
Looks good to me on RHEL 7 + 8 + 9 |
|
Works for me on RHEL 7 + 8 + 9 :) Thanks for the lightning fast fix :) |
As there is a clear workaround by installing the perl module, I do not think this warrants a 3.3.2.1 release. |
|
How does failing to build with your listed minimum dependencies not warrant a point release? This release does not build for a bunch of platforms, and telling those users to upgrade their version of perl or some perl module may be a non-starter for them. |
|
Small detail: the next patch (point) release will be 3.3.3, regardless of when or how much goes into it. |
|
LGTM, the patch fixes 3.3.2 builds for SLES 11 + 12, RHEL 6 + 7 . |
|
@t8m why isn't a patch release being made? This would make many folks their work easier to resolve this |
|
A patch release means a forced update for many users of OpenSSL so it creates additional work for many people. There is of course also some work required from the OpenSSL release managers to create the release but that is not so important for the decision. So doing a new patch release should not be taken lightly and only fairly serious regressions should trigger such release. |
|
I will be raising this issue in the next OTC meeting (next Tuesday). |
…inux release This change enables the use of Rustls for the manylinux Python wheel, which was originally disabled in #1224. That issue was only affecting MacOS and has likely since been resolved. The switch from openssl motivated by the issue described in openssl/openssl#25367 Closes #2848
|
Not building on supported platforms is a serious regression, and honestly, this regression should have been caught by automation prior to release. |
Sorry to jump in here, but I've been facing the same issue with a Thanks P.S.: Openssl dev team, you're a core tenet of all software out there, so I'll take this opportunity to thank you for all of the hard work you've put into this lib over the decades. |
Yes there is. You can take the patch that came out of this PR (commit 40c8ebe). BTW, we created a discussion category Release addendums a couple of days ago, and you'll find Release 3.3.2 errata there. |
openssl 3.3.2 does not build on manylinux. See openssl/openssl#25367
|
If you found your way here because you are building on manylinux via Rust, I found that |
| my @subdirs = pairs (PREFIX => [ qw(BINDIR LIBDIR INCLUDEDIR APPLINKDIR) ], | ||
| LIBDIR => [ qw(ENGINESDIR MODULESDIR PKGCONFIGDIR | ||
| CMAKECONFIGDIR) ]); | ||
| my @subdirs = _pairs (PREFIX => [ qw(BINDIR LIBDIR INCLUDEDIR APPLINKDIR) ], |
There was a problem hiding this comment.
Why do it with _pairs when you can just type 2 pairs of [ / ]?
array-refs have been core in perl for some time
There was a problem hiding this comment.
Exactly, this is just a very round-about way of writing them as literal array refs, since you're only supplying 4 items to pairs or _pairs.
There was a problem hiding this comment.
Good point. I had done it like this initially 'cause I found it more elegant, simple as that.
But, now it's in with _pairs. If someone is really hell bent on changing this bit again, feel free to raise a PR.
The only way is to force a rollback to 300.3.1+3.3.1 and wait for the new version to be released. That patch has no effect on this case. |
Yes, that's what my command does — I'm just noting that this took me a while to figure out as a non-Cargo-expert (and it seems like I'm not the only person on this thread running into this via a manylinux build of Rust software) and that perhaps others might appreciate the explicit command. |
|
Works for me on amazon-linux2 |
Adding onto this, if you don't have a |
Unfortunately, List::Util::pairs didn't appear in perl core modules
before 5.19.3, and our minimum requirement is 5.10.
Fortunately, we already have a replacement implementation, and can
re-apply it in this script.
Fixes #25366