Issue 22076 - Fix regressions in dupctx testing #22082#22102
Closed
nhorman wants to merge 2 commits intoopenssl:masterfrom
Closed
Issue 22076 - Fix regressions in dupctx testing #22082#22102nhorman wants to merge 2 commits intoopenssl:masterfrom
nhorman wants to merge 2 commits intoopenssl:masterfrom
Conversation
If we ignore the faliure to copy on an old fips provider, we need to use ctx_base, rather than ctx Fixes openssl#22076
In the dupctx fixups I missed a pointer that needed to be repointed to the surrounding structures AES_KEY structure for the sm4/aes/aria ccm/gcm variants. This caused a colliding use of the key and possible use after free issues. Fixes openssl#22076
t8m
approved these changes
Sep 14, 2023
paulidale
approved these changes
Sep 14, 2023
1 task
Collaborator
|
This pull request is ready to merge |
Contributor
|
Merged, thanks. |
openssl-machine
pushed a commit
that referenced
this pull request
Sep 17, 2023
In the dupctx fixups I missed a pointer that needed to be repointed to the surrounding structures AES_KEY structure for the sm4/aes/aria ccm/gcm variants. This caused a colliding use of the key and possible use after free issues. Fixes #22076 Reviewed-by: Tomas Mraz <tomas@openssl.org> Reviewed-by: Paul Dale <pauli@openssl.org> (Merged from #22102)
wanghao75
pushed a commit
to openeuler-mirror/openssl
that referenced
this pull request
Sep 23, 2023
If we ignore the faliure to copy on an old fips provider, we need to use ctx_base, rather than ctx Fixes #22076 Reviewed-by: Tomas Mraz <tomas@openssl.org> Reviewed-by: Paul Dale <pauli@openssl.org> (Merged from openssl/openssl#22102) Signed-off-by: fly2x <fly2x@hitls.org>
wanghao75
pushed a commit
to openeuler-mirror/openssl
that referenced
this pull request
Sep 23, 2023
In the dupctx fixups I missed a pointer that needed to be repointed to the surrounding structures AES_KEY structure for the sm4/aes/aria ccm/gcm variants. This caused a colliding use of the key and possible use after free issues. Fixes #22076 Reviewed-by: Tomas Mraz <tomas@openssl.org> Reviewed-by: Paul Dale <pauli@openssl.org> (Merged from openssl/openssl#22102) Signed-off-by: fly2x <fly2x@hitls.org>
Liu-ErMeng
pushed a commit
to Liu-ErMeng/openssl
that referenced
this pull request
Dec 21, 2023
In the dupctx fixups I missed a pointer that needed to be repointed to the surrounding structures AES_KEY structure for the sm4/aes/aria ccm/gcm variants. This caused a colliding use of the key and possible use after free issues. Fixes openssl#22076 Reviewed-by: Tomas Mraz <tomas@openssl.org> Reviewed-by: Paul Dale <pauli@openssl.org> (Merged from openssl#22102)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hit a few regressions in dupctx tests from my addition of those methods in the various ciphers. Fix them up
Checklist