Skip to content

Add system guessing for linux64-loongarch64 target#21510

Closed
xry111 wants to merge 1 commit intoopenssl:masterfrom
xry111:xry111/issue-21340
Closed

Add system guessing for linux64-loongarch64 target#21510
xry111 wants to merge 1 commit intoopenssl:masterfrom
xry111:xry111/issue-21340

Conversation

@xry111
Copy link
Contributor

@xry111 xry111 commented Jul 21, 2023

Now the default is linux-generic32, it's not good for loongarch64.

We can also test if the assembler supports vector instructions here and disable asm if not.

Closes #21340.

Now the default is linux-generic32, it's not good for loongarch64.

We can also test if the assembler supports vector instructions here and
disable asm if not.

Closes openssl#21340.
@t8m t8m added branch: master Applies to master branch approval: review pending This pull request needs review by a committer approval: otc review pending triaged: feature The issue/pr requests/adds a feature tests: exempted The PR is exempt from requirements for testing labels Jul 21, 2023
@paulidale paulidale removed the approval: review pending This pull request needs review by a committer label Jul 24, 2023
@xry111
Copy link
Contributor Author

xry111 commented Jul 30, 2023

Ping?

Or should we add back the review pending label?

@paulidale paulidale added the approval: done This pull request has the required number of approvals label Jul 31, 2023
@openssl-machine openssl-machine added approval: ready to merge The 24 hour grace period has passed, ready to merge and removed approval: done This pull request has the required number of approvals labels Aug 1, 2023
@openssl-machine
Copy link
Collaborator

This pull request is ready to merge

@t8m
Copy link
Member

t8m commented Aug 1, 2023

Merged to master branch. Thank you for your contribution.

@t8m t8m closed this Aug 1, 2023
openssl-machine pushed a commit that referenced this pull request Aug 1, 2023
Now the default is linux-generic32, it's not good for loongarch64.

We can also test if the assembler supports vector instructions here and
disable asm if not.

Closes #21340.

Reviewed-by: Paul Dale <pauli@openssl.org>
Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from #21510)
beldmit pushed a commit to beldmit/openssl that referenced this pull request Aug 2, 2023
Now the default is linux-generic32, it's not good for loongarch64.

We can also test if the assembler supports vector instructions here and
disable asm if not.

Closes openssl#21340.

Reviewed-by: Paul Dale <pauli@openssl.org>
Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from openssl#21510)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approval: ready to merge The 24 hour grace period has passed, ready to merge branch: master Applies to master branch tests: exempted The PR is exempt from requirements for testing triaged: feature The issue/pr requests/adds a feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

openssl 3.1.x fails to build on loongarch64 with asm enabled

4 participants