Vector optimization for adding AES encryption and decryption to the loongarch64 architecture#19364
Closed
zhuchen1911 wants to merge 2 commits intoopenssl:masterfrom
zhuchen1911:Loongarch64
Closed
Vector optimization for adding AES encryption and decryption to the loongarch64 architecture#19364zhuchen1911 wants to merge 2 commits intoopenssl:masterfrom zhuchen1911:Loongarch64
zhuchen1911 wants to merge 2 commits intoopenssl:masterfrom
zhuchen1911:Loongarch64
Conversation
paulidale
approved these changes
Oct 9, 2022
t8m
requested changes
Oct 10, 2022
crypto/loongarch_arch.h
Outdated
| #ifndef OSSL_CRYPTO_LOONGARCH_ARCH_H | ||
| #define OSSL_CRYPTO_LOONGARCH_ARCH_H | ||
|
|
||
| //extern int have_lasx; |
Member
There was a problem hiding this comment.
Please use regular C style comments.
Contributor
Author
There was a problem hiding this comment.
Thank you very much for your review. This comment has been removed. If there are other problems in the code, please point out and I will modify it according to your requirements.
Loongarch64 architecture defines 128 bit vector extension lsx and 256 bit vector extension lasx. The cpucfg instruction can be used to obtain whether the CPU has a corresponding extension. This part of code is added to prepare for the subsequent addition of corresponding vector instruction optimization. Signed-off-by: zhuchen <zhuchen@loongson.cn>
t8m
reviewed
Oct 10, 2022
include/crypto/aes_platform.h
Outdated
Comment on lines
+161
to
+166
| #if defined(__loongarch__) || defined(__loongarch64) | ||
| #include "loongarch_arch.h" | ||
| # if defined(VPAES_ASM) | ||
| # define VPAES_CAPABLE (OPENSSL_loongarchcap_P & LOONGARCH_CFG2_LSX) | ||
| # endif | ||
| #endif |
Member
There was a problem hiding this comment.
Please make the preprocessor directive indentations right. I.e., add one more space in front of everything, except the # define, and add two spaces in #include.
Contributor
Author
There was a problem hiding this comment.
Thank you very much for your review. preprocessor directive indentations has been corrected.
Add 128 bit lsx vector expansion optimization code of Loongarch64 architecture to AES. The test result on the 3A5000 improves performance by about 40%~50%. Signed-off-by: zhuchen <zhuchen@loongson.cn>
Contributor
|
Still good. |
Collaborator
|
24 hours has passed since 'approval: done' was set, but this PR has failing CI tests. Once the tests pass it will get moved to 'approval: ready to merge' automatically, alternatively please review and set the label manually. |
Contributor
|
Merged, thanks. |
openssl-machine
pushed a commit
that referenced
this pull request
Oct 12, 2022
Loongarch64 architecture defines 128 bit vector extension lsx and 256 bit vector extension lasx. The cpucfg instruction can be used to obtain whether the CPU has a corresponding extension. This part of code is added to prepare for the subsequent addition of corresponding vector instruction optimization. Signed-off-by: zhuchen <zhuchen@loongson.cn> Reviewed-by: Tomas Mraz <tomas@openssl.org> Reviewed-by: Paul Dale <pauli@openssl.org> (Merged from #19364)
openssl-machine
pushed a commit
that referenced
this pull request
Oct 12, 2022
Add 128 bit lsx vector expansion optimization code of Loongarch64 architecture to AES. The test result on the 3A5000 improves performance by about 40%~50%. Signed-off-by: zhuchen <zhuchen@loongson.cn> Reviewed-by: Tomas Mraz <tomas@openssl.org> Reviewed-by: Paul Dale <pauli@openssl.org> (Merged from #19364)
|
merge to |
Contributor
|
No, our stability policy prevent performance enhancements on stable branches. It would be a possibility for 3.1 however. |
t8m
pushed a commit
to t8m/openssl
that referenced
this pull request
Nov 21, 2022
Loongarch64 architecture defines 128 bit vector extension lsx and 256 bit vector extension lasx. The cpucfg instruction can be used to obtain whether the CPU has a corresponding extension. This part of code is added to prepare for the subsequent addition of corresponding vector instruction optimization. Signed-off-by: zhuchen <zhuchen@loongson.cn> Reviewed-by: Tomas Mraz <tomas@openssl.org> Reviewed-by: Paul Dale <pauli@openssl.org> (Merged from openssl#19364) (cherry picked from commit 7f2d618)
t8m
pushed a commit
to t8m/openssl
that referenced
this pull request
Nov 21, 2022
Add 128 bit lsx vector expansion optimization code of Loongarch64 architecture to AES. The test result on the 3A5000 improves performance by about 40%~50%. Signed-off-by: zhuchen <zhuchen@loongson.cn> Reviewed-by: Tomas Mraz <tomas@openssl.org> Reviewed-by: Paul Dale <pauli@openssl.org> (Merged from openssl#19364) (cherry picked from commit ef91754)
openssl-machine
pushed a commit
that referenced
this pull request
Nov 23, 2022
Loongarch64 architecture defines 128 bit vector extension lsx and 256 bit vector extension lasx. The cpucfg instruction can be used to obtain whether the CPU has a corresponding extension. This part of code is added to prepare for the subsequent addition of corresponding vector instruction optimization. Signed-off-by: zhuchen <zhuchen@loongson.cn> Reviewed-by: Tomas Mraz <tomas@openssl.org> Reviewed-by: Paul Dale <pauli@openssl.org> (Merged from #19364) (cherry picked from commit 7f2d618)
openssl-machine
pushed a commit
that referenced
this pull request
Nov 23, 2022
Add 128 bit lsx vector expansion optimization code of Loongarch64 architecture to AES. The test result on the 3A5000 improves performance by about 40%~50%. Signed-off-by: zhuchen <zhuchen@loongson.cn> Reviewed-by: Tomas Mraz <tomas@openssl.org> Reviewed-by: Paul Dale <pauli@openssl.org> (Merged from #19364) (cherry picked from commit ef91754)
beldmit
pushed a commit
to beldmit/openssl
that referenced
this pull request
Dec 26, 2022
Loongarch64 architecture defines 128 bit vector extension lsx and 256 bit vector extension lasx. The cpucfg instruction can be used to obtain whether the CPU has a corresponding extension. This part of code is added to prepare for the subsequent addition of corresponding vector instruction optimization. Signed-off-by: zhuchen <zhuchen@loongson.cn> Reviewed-by: Tomas Mraz <tomas@openssl.org> Reviewed-by: Paul Dale <pauli@openssl.org> (Merged from openssl#19364)
beldmit
pushed a commit
to beldmit/openssl
that referenced
this pull request
Dec 26, 2022
Add 128 bit lsx vector expansion optimization code of Loongarch64 architecture to AES. The test result on the 3A5000 improves performance by about 40%~50%. Signed-off-by: zhuchen <zhuchen@loongson.cn> Reviewed-by: Tomas Mraz <tomas@openssl.org> Reviewed-by: Paul Dale <pauli@openssl.org> (Merged from openssl#19364)
|
This breaks with upstream toolchains that does NOT yet have the LSX/LASX support (in fact support has just been merged about a week ago!), we have to probe for assembler support and disable the asm if support is absent. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist