Skip to content

Fix various typos, repeated words, align some spelling to LDP. #19059

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
FdaSilvaYY wants to merge 7 commits into from
Closed

Fix various typos, repeated words, align some spelling to LDP. #19059

FdaSilvaYY wants to merge 7 commits into from

Conversation

@FdaSilvaYY
Copy link
Contributor

@FdaSilvaYY FdaSilvaYY commented Aug 24, 2022

partially revamped from #16712

  • fall thru -> fall through
  • time stamp -> timestamp
  • file name -> filename
  • host name -> hostname

Only fix a few low level =>low-level to reduce the PR extent.

Fix a few pointer compare test nits, while fixing some typos.

Checklist
  • documentation is added or updated
  • tests are added or updated

@FdaSilvaYY
crypto: Fix various typos, repeated words, align some spelling to LDP.
68f81fc 
partially revamped from openssl#16712
- fall thru -> fall through
- time stamp -> timestamp
- file name -> filename
- host name -> hostname
@FdaSilvaYY
crypto/*: Fix various typos, repeated words, align some spelling to LDP.
277defb 
partially revamped from openssl#16712
- fall thru -> fall through
- time stamp -> timestamp
- host name -> hostname
- ipv6 -> IPv6
@FdaSilvaYY
Fix various typos, repeated words, align some spelling to LDP.
86729a9 
Partially revamped from openssl#16712
- fall thru -> fall through
- time stamp -> timestamp
- host name -> hostname
- ipv6 -> IPv6
@FdaSilvaYY
fixup! Fix various typos, repeated words, align some spelling to LDP.…
2d06381 
… Partially revamped from openssl#16712 - fall thru -> fall through - time stamp -> timestamp - host name -> hostname - ipv6 -> IPv6
@FdaSilvaYY
apps & al : Fix various typos, repeated words, align some spelling to…
b194bec 
… LDP.

Mostly revamped from openssl#16712
- fall thru -> fall through
- time stamp -> timestamp
- host name -> hostname
- ipv6 -> IPv6
@FdaSilvaYY
nit: fix some pointer comparisons
8728522
@github-actions github-actions bot added the severity: fips change The pull request changes FIPS provider sources label Aug 24, 2022
t8m
t8m reviewed Aug 25, 2022
View reviewed changes
Copy link
Member

@t8m t8m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMO this is for master branch only. The fixes of the documentation would be probably eligible for 3.0 backport, however the comments changes are not something we would backport.

@t8m t8m added branch: master Applies to master branch triaged: cleanup The issue/pr deals with cleanup of comments/docs not altering code significantly labels Aug 25, 2022
@FdaSilvaYY
fixup! Fix various typos, repeated words, align some spelling to LDP.…
4761a73 
… Partially revamped from openssl#16712 - fall thru -> fall through - time stamp -> timestamp - host name -> hostname - ipv6 -> IPv6
@FdaSilvaYY FdaSilvaYY requested a review from t8m August 25, 2022 18:48
@FdaSilvaYY
Copy link
Contributor Author

FdaSilvaYY commented Aug 25, 2022

I may submit a PR to backport documentation fixes only, if you want.

@t8m t8m added the approval: review pending This pull request needs review by a committer label Aug 26, 2022
@t8m
Copy link
Member

t8m commented Aug 26, 2022

I may submit a PR to backport documentation fixes only, if you want.

Feel free to submit it.

@FdaSilvaYY
Copy link
Contributor Author

FdaSilvaYY commented Sep 10, 2022

Ping @openssl/commiters, needs a 2nd reviewer.

@openssl-machine
Copy link
Collaborator

openssl-machine commented Oct 11, 2022

This PR is in a state where it requires action by @openssl/committers but the last update was 30 days ago

@paulidale paulidale added the approval: done This pull request has the required number of approvals label Oct 11, 2022
@openssl-machine openssl-machine added approval: ready to merge The 24 hour grace period has passed, ready to merge and removed approval: done This pull request has the required number of approvals labels Oct 12, 2022
@openssl-machine
Copy link
Collaborator

openssl-machine commented Oct 12, 2022

This pull request is ready to merge

@paulidale paulidale removed the approval: review pending This pull request needs review by a committer label Oct 12, 2022
@paulidale
Copy link
Contributor

paulidale commented Oct 12, 2022

Merged, thanks for the contributions.

@paulidale paulidale closed this Oct 12, 2022
openssl-machine pushed a commit that referenced this pull request Oct 12, 2022
@FdaSilvaYY @paulidale
crypto: Fix various typos, repeated words, align some spelling to LDP.
1567a82 
partially revamped from #16712
- fall thru -> fall through
- time stamp -> timestamp
- file name -> filename
- host name -> hostname

Reviewed-by: Tomas Mraz <tomas@openssl.org>
Reviewed-by: Paul Dale <pauli@openssl.org>
(Merged from #19059)
openssl-machine pushed a commit that referenced this pull request Oct 12, 2022
@FdaSilvaYY @paulidale
crypto/*: Fix various typos, repeated words, align some spelling to LDP.
c734058 
partially revamped from #16712
- fall thru -> fall through
- time stamp -> timestamp
- host name -> hostname
- ipv6 -> IPv6

Reviewed-by: Tomas Mraz <tomas@openssl.org>
Reviewed-by: Paul Dale <pauli@openssl.org>
(Merged from #19059)
openssl-machine pushed a commit that referenced this pull request Oct 12, 2022
@FdaSilvaYY @paulidale
Fix various typos, repeated words, align some spelling to LDP.
d7f3a2c 
Partially revamped from #16712
- fall thru -> fall through
- time stamp -> timestamp
- host name -> hostname
- ipv6 -> IPv6

Reviewed-by: Tomas Mraz <tomas@openssl.org>
Reviewed-by: Paul Dale <pauli@openssl.org>
(Merged from #19059)
openssl-machine pushed a commit that referenced this pull request Oct 12, 2022
@FdaSilvaYY @paulidale
apps & al : Fix various typos, repeated words, align some spelling to…
9929c81 
… LDP.

Mostly revamped from #16712
- fall thru -> fall through
- time stamp -> timestamp
- host name -> hostname
- ipv6 -> IPv6

Reviewed-by: Tomas Mraz <tomas@openssl.org>
Reviewed-by: Paul Dale <pauli@openssl.org>
(Merged from #19059)
openssl-machine pushed a commit that referenced this pull request Oct 12, 2022
@FdaSilvaYY @paulidale
nit: fix some pointer comparisons
e1e93f7 
Reviewed-by: Tomas Mraz <tomas@openssl.org>
Reviewed-by: Paul Dale <pauli@openssl.org>
(Merged from #19059)
@FdaSilvaYY FdaSilvaYY deleted the 2022/08/LDP-typography branch November 19, 2022 14:44
t8m pushed a commit to t8m/openssl that referenced this pull request Nov 21, 2022
@FdaSilvaYY @t8m
crypto: Fix various typos, repeated words, align some spelling to LDP.
eba9272 
partially revamped from openssl#16712
- fall thru -> fall through
- time stamp -> timestamp
- file name -> filename
- host name -> hostname

Reviewed-by: Tomas Mraz <tomas@openssl.org>
Reviewed-by: Paul Dale <pauli@openssl.org>
(Merged from openssl#19059)

(cherry picked from commit 1567a82)
t8m pushed a commit to t8m/openssl that referenced this pull request Nov 21, 2022
@FdaSilvaYY @t8m
crypto/*: Fix various typos, repeated words, align some spelling to LDP.
f6faac8 
partially revamped from openssl#16712
- fall thru -> fall through
- time stamp -> timestamp
- host name -> hostname
- ipv6 -> IPv6

Reviewed-by: Tomas Mraz <tomas@openssl.org>
Reviewed-by: Paul Dale <pauli@openssl.org>
(Merged from openssl#19059)

(cherry picked from commit c734058)
t8m pushed a commit to t8m/openssl that referenced this pull request Nov 21, 2022
@FdaSilvaYY @t8m
Fix various typos, repeated words, align some spelling to LDP.
27c1102 
Partially revamped from openssl#16712
- fall thru -> fall through
- time stamp -> timestamp
- host name -> hostname
- ipv6 -> IPv6

Reviewed-by: Tomas Mraz <tomas@openssl.org>
Reviewed-by: Paul Dale <pauli@openssl.org>
(Merged from openssl#19059)

(cherry picked from commit d7f3a2c)
t8m pushed a commit to t8m/openssl that referenced this pull request Nov 21, 2022
@FdaSilvaYY @t8m
apps & al : Fix various typos, repeated words, align some spelling to…
816c2da 
… LDP.

Mostly revamped from openssl#16712
- fall thru -> fall through
- time stamp -> timestamp
- host name -> hostname
- ipv6 -> IPv6

Reviewed-by: Tomas Mraz <tomas@openssl.org>
Reviewed-by: Paul Dale <pauli@openssl.org>
(Merged from openssl#19059)

(cherry picked from commit 9929c81)
t8m pushed a commit to t8m/openssl that referenced this pull request Nov 21, 2022
@FdaSilvaYY @t8m
nit: fix some pointer comparisons
b01748e 
Reviewed-by: Tomas Mraz <tomas@openssl.org>
Reviewed-by: Paul Dale <pauli@openssl.org>
(Merged from openssl#19059)

(cherry picked from commit e1e93f7)
openssl-machine pushed a commit that referenced this pull request Nov 23, 2022
@FdaSilvaYY @t8m
crypto: Fix various typos, repeated words, align some spelling to LDP.
5af0050 
partially revamped from #16712
- fall thru -> fall through
- time stamp -> timestamp
- file name -> filename
- host name -> hostname

Reviewed-by: Tomas Mraz <tomas@openssl.org>
Reviewed-by: Paul Dale <pauli@openssl.org>
(Merged from #19059)

(cherry picked from commit 1567a82)
openssl-machine pushed a commit that referenced this pull request Nov 23, 2022
@FdaSilvaYY @t8m
crypto/*: Fix various typos, repeated words, align some spelling to LDP.
2c54276 
partially revamped from #16712
- fall thru -> fall through
- time stamp -> timestamp
- host name -> hostname
- ipv6 -> IPv6

Reviewed-by: Tomas Mraz <tomas@openssl.org>
Reviewed-by: Paul Dale <pauli@openssl.org>
(Merged from #19059)

(cherry picked from commit c734058)
openssl-machine pushed a commit that referenced this pull request Nov 23, 2022
@FdaSilvaYY @t8m
Fix various typos, repeated words, align some spelling to LDP.
f24b716 
Partially revamped from #16712
- fall thru -> fall through
- time stamp -> timestamp
- host name -> hostname
- ipv6 -> IPv6

Reviewed-by: Tomas Mraz <tomas@openssl.org>
Reviewed-by: Paul Dale <pauli@openssl.org>
(Merged from #19059)

(cherry picked from commit d7f3a2c)
openssl-machine pushed a commit that referenced this pull request Nov 23, 2022
@FdaSilvaYY @t8m
apps & al : Fix various typos, repeated words, align some spelling to…
fee9986 
… LDP.

Mostly revamped from #16712
- fall thru -> fall through
- time stamp -> timestamp
- host name -> hostname
- ipv6 -> IPv6

Reviewed-by: Tomas Mraz <tomas@openssl.org>
Reviewed-by: Paul Dale <pauli@openssl.org>
(Merged from #19059)

(cherry picked from commit 9929c81)
openssl-machine pushed a commit that referenced this pull request Nov 23, 2022
@FdaSilvaYY @t8m
nit: fix some pointer comparisons
bf0e3fa 
Reviewed-by: Tomas Mraz <tomas@openssl.org>
Reviewed-by: Paul Dale <pauli@openssl.org>
(Merged from #19059)

(cherry picked from commit e1e93f7)
beldmit pushed a commit to beldmit/openssl that referenced this pull request Dec 26, 2022
@FdaSilvaYY @beldmit
crypto: Fix various typos, repeated words, align some spelling to LDP.
c28ab34 
partially revamped from openssl#16712
- fall thru -> fall through
- time stamp -> timestamp
- file name -> filename
- host name -> hostname

Reviewed-by: Tomas Mraz <tomas@openssl.org>
Reviewed-by: Paul Dale <pauli@openssl.org>
(Merged from openssl#19059)
beldmit pushed a commit to beldmit/openssl that referenced this pull request Dec 26, 2022
@FdaSilvaYY @beldmit
crypto/*: Fix various typos, repeated words, align some spelling to LDP.
d0714c5 
partially revamped from openssl#16712
- fall thru -> fall through
- time stamp -> timestamp
- host name -> hostname
- ipv6 -> IPv6

Reviewed-by: Tomas Mraz <tomas@openssl.org>
Reviewed-by: Paul Dale <pauli@openssl.org>
(Merged from openssl#19059)
beldmit pushed a commit to beldmit/openssl that referenced this pull request Dec 26, 2022
@FdaSilvaYY @beldmit
Fix various typos, repeated words, align some spelling to LDP.
a182145 
Partially revamped from openssl#16712
- fall thru -> fall through
- time stamp -> timestamp
- host name -> hostname
- ipv6 -> IPv6

Reviewed-by: Tomas Mraz <tomas@openssl.org>
Reviewed-by: Paul Dale <pauli@openssl.org>
(Merged from openssl#19059)
beldmit pushed a commit to beldmit/openssl that referenced this pull request Dec 26, 2022
@FdaSilvaYY @beldmit
apps & al : Fix various typos, repeated words, align some spelling to…
dec51f5 
… LDP.

Mostly revamped from openssl#16712
- fall thru -> fall through
- time stamp -> timestamp
- host name -> hostname
- ipv6 -> IPv6

Reviewed-by: Tomas Mraz <tomas@openssl.org>
Reviewed-by: Paul Dale <pauli@openssl.org>
(Merged from openssl#19059)
beldmit pushed a commit to beldmit/openssl that referenced this pull request Dec 26, 2022
@FdaSilvaYY @beldmit
nit: fix some pointer comparisons
072ab41 
Reviewed-by: Tomas Mraz <tomas@openssl.org>
Reviewed-by: Paul Dale <pauli@openssl.org>
(Merged from openssl#19059)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@t8m t8m t8m approved these changes

@paulidale paulidale paulidale approved these changes

Assignees

No one assigned

Labels

approval: ready to merge The 24 hour grace period has passed, ready to merge branch: master Applies to master branch severity: fips change The pull request changes FIPS provider sources triaged: cleanup The issue/pr deals with cleanup of comments/docs not altering code significantly

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@FdaSilvaYY @t8m @openssl-machine @paulidale