Skip to content

Add a stand-alone "timing_load_creds" program (was PR 15088/16540)#18821

Closed
DDvO wants to merge 5 commits intoopenssl:masterfrom
siemens:openssl-pr-15088
Closed

Add a stand-alone "timing_load_creds" program (was PR 15088/16540)#18821
DDvO wants to merge 5 commits intoopenssl:masterfrom
siemens:openssl-pr-15088

Conversation

@DDvO
Copy link
Contributor

@DDvO DDvO commented Jul 18, 2022 •
edited
Loading

Copy of #16540 by @richsalz, plus new fixups.

@DDvO DDvO mentioned this pull request Jul 18, 2022
Closed
@DDvO DDvO requested review from paulidale and slontis July 18, 2022 18:32
@DDvO DDvO mentioned this pull request Jul 18, 2022
Open
@DDvO DDvO force-pushed the openssl-pr-15088 branch from 0417388 to 93c749e Compare July 18, 2022 18:40
@DDvO DDvO added approval: otc review pending branch: master Applies to master branch approval: review pending This pull request needs review by a committer labels Jul 18, 2022
@DDvO DDvO force-pushed the openssl-pr-15088 branch from 93c749e to 036a3fd Compare July 18, 2022 18:48
@DDvO DDvO changed the title Add a stand-alone "timing" program (PR 15088) Add a stand-alone "timing_load_creds" program (was PR 15088/16540) Jul 18, 2022
beldmit
beldmit previously approved these changes Jul 18, 2022
View reviewed changes
Copy link
Member

@beldmit beldmit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@beldmit
Copy link
Member

beldmit commented Jul 18, 2022

No, to early :(

@beldmit beldmit dismissed their stale review July 18, 2022 19:49

Windows build fails

@DDvO DDvO force-pushed the openssl-pr-15088 branch from 036a3fd to a11f108 Compare July 18, 2022 20:19
@DDvO
Copy link
Contributor Author

DDvO commented Jul 18, 2022 •
edited
Loading

Windows build fails

Sigh, yes.
Is there a way of selective excluding certain builds from Windows in build.info?

@DDvO DDvO force-pushed the openssl-pr-15088 branch 3 times, most recently from fdc1981 to 8157107 Compare July 19, 2022 07:08
beldmit
beldmit approved these changes Jul 19, 2022
View reviewed changes
Copy link
Member

@beldmit beldmit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tmshort
Copy link
Contributor

tmshort commented Jul 22, 2022

FYI, @DDvO, I can write to the Akamai repo...

@tmshort tmshort added approval: done This pull request has the required number of approvals and removed approval: review pending This pull request needs review by a committer labels Jul 22, 2022
tmshort
tmshort reviewed Jul 22, 2022
View reviewed changes
@tmshort tmshort added approval: review pending This pull request needs review by a committer and removed approval: done This pull request has the required number of approvals labels Jul 22, 2022
tmshort
tmshort requested changes Jul 22, 2022
View reviewed changes
Copy link
Contributor

@tmshort tmshort left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update the various comma-delimited compound statements.

@DDvO DDvO force-pushed the openssl-pr-15088 branch from 8157107 to 8866985 Compare July 25, 2022 07:21
@DDvO DDvO requested a review from tmshort July 25, 2022 07:25
@DDvO DDvO force-pushed the openssl-pr-15088 branch from 8866985 to 4dc116d Compare July 31, 2022 16:06
@DDvO
Copy link
Contributor Author

DDvO commented Jul 31, 2022 •
edited
Loading

If this had been my code, it would have looked pretty clean right away.
I also fixed a mem leak on contents.
Hopefully this little tool code is now in sufficient state.

@DDvO DDvO requested a review from tmshort July 31, 2022 16:11
@DDvO
Copy link
Contributor Author

DDvO commented Jul 31, 2022

Unfortunately I have to ask once more for re-approval.

@beldmit
Copy link
Member

beldmit commented Aug 2, 2022

Still OK

@paulidale paulidale added approval: done This pull request has the required number of approvals and removed approval: review pending This pull request needs review by a committer labels Aug 15, 2022
@openssl-machine openssl-machine added approval: ready to merge The 24 hour grace period has passed, ready to merge and removed approval: done This pull request has the required number of approvals labels Aug 16, 2022
@openssl-machine
Copy link
Collaborator

openssl-machine commented Aug 16, 2022

This pull request is ready to merge

@DDvO
Copy link
Contributor Author

DDvO commented Aug 16, 2022

Merged - thanks @tmshort for your comments and @beldmit and @paulidale for comments and approvals.

openssl-machine pushed a commit that referenced this pull request Aug 16, 2022
@richsalz @DDvO
Add a stand-alone "timing" program
6212fc6 
Reviewed-by: Dmitry Belyavskiy <beldmit@gmail.com>
Reviewed-by: Paul Dale <pauli@openssl.org>
Reviewed-by: David von Oheimb <david.von.oheimb@siemens.com>
(Merged from #18821)
openssl-machine pushed a commit that referenced this pull request Aug 16, 2022
@DDvO
Rename the "timing" program to "timing_load_creds" and integrate it w…
c02036e 
…ith test/build.info

Reviewed-by: Dmitry Belyavskiy <beldmit@gmail.com>
Reviewed-by: Paul Dale <pauli@openssl.org>
Reviewed-by: David von Oheimb <david.von.oheimb@siemens.com>
(Merged from #18821)
openssl-machine pushed a commit that referenced this pull request Aug 16, 2022
@DDvO
test/timing_load_creds.c: fix coding style and other (mostly minor) i…
45479dc 
…ssues

Reviewed-by: Dmitry Belyavskiy <beldmit@gmail.com>
Reviewed-by: Paul Dale <pauli@openssl.org>
Reviewed-by: David von Oheimb <david.von.oheimb@siemens.com>
(Merged from #18821)
@DDvO DDvO closed this Aug 16, 2022
sftcd pushed a commit to sftcd/openssl that referenced this pull request Sep 24, 2022
@richsalz @sftcd
Add a stand-alone "timing" program
cb94b8a 
Reviewed-by: Dmitry Belyavskiy <beldmit@gmail.com>
Reviewed-by: Paul Dale <pauli@openssl.org>
Reviewed-by: David von Oheimb <david.von.oheimb@siemens.com>
(Merged from openssl#18821)
sftcd pushed a commit to sftcd/openssl that referenced this pull request Sep 24, 2022
@DDvO @sftcd
Rename the "timing" program to "timing_load_creds" and integrate it w…
bb320e2 
…ith test/build.info

Reviewed-by: Dmitry Belyavskiy <beldmit@gmail.com>
Reviewed-by: Paul Dale <pauli@openssl.org>
Reviewed-by: David von Oheimb <david.von.oheimb@siemens.com>
(Merged from openssl#18821)
sftcd pushed a commit to sftcd/openssl that referenced this pull request Sep 24, 2022
@DDvO @sftcd
test/timing_load_creds.c: fix coding style and other (mostly minor) i…
36f7a6d 
…ssues

Reviewed-by: Dmitry Belyavskiy <beldmit@gmail.com>
Reviewed-by: Paul Dale <pauli@openssl.org>
Reviewed-by: David von Oheimb <david.von.oheimb@siemens.com>
(Merged from openssl#18821)
t8m pushed a commit to t8m/openssl that referenced this pull request Nov 21, 2022
@richsalz @t8m
Add a stand-alone "timing" program
9a6eebe 
Reviewed-by: Dmitry Belyavskiy <beldmit@gmail.com>
Reviewed-by: Paul Dale <pauli@openssl.org>
Reviewed-by: David von Oheimb <david.von.oheimb@siemens.com>
(Merged from openssl#18821)

(cherry picked from commit 6212fc6)
t8m pushed a commit to t8m/openssl that referenced this pull request Nov 21, 2022
@DDvO @t8m
Rename the "timing" program to "timing_load_creds" and integrate it w…
b72fd91 
…ith test/build.info

Reviewed-by: Dmitry Belyavskiy <beldmit@gmail.com>
Reviewed-by: Paul Dale <pauli@openssl.org>
Reviewed-by: David von Oheimb <david.von.oheimb@siemens.com>
(Merged from openssl#18821)

(cherry picked from commit c02036e)
t8m pushed a commit to t8m/openssl that referenced this pull request Nov 21, 2022
@DDvO @t8m
test/timing_load_creds.c: fix coding style and other (mostly minor) i…
d46d958 
…ssues

Reviewed-by: Dmitry Belyavskiy <beldmit@gmail.com>
Reviewed-by: Paul Dale <pauli@openssl.org>
Reviewed-by: David von Oheimb <david.von.oheimb@siemens.com>
(Merged from openssl#18821)

(cherry picked from commit 45479dc)
openssl-machine pushed a commit that referenced this pull request Nov 23, 2022
@richsalz @t8m
Add a stand-alone "timing" program
e5124e1 
Reviewed-by: Dmitry Belyavskiy <beldmit@gmail.com>
Reviewed-by: Paul Dale <pauli@openssl.org>
Reviewed-by: David von Oheimb <david.von.oheimb@siemens.com>
(Merged from #18821)

(cherry picked from commit 6212fc6)
openssl-machine pushed a commit that referenced this pull request Nov 23, 2022
@DDvO @t8m
Rename the "timing" program to "timing_load_creds" and integrate it w…
93485e8 
…ith test/build.info

Reviewed-by: Dmitry Belyavskiy <beldmit@gmail.com>
Reviewed-by: Paul Dale <pauli@openssl.org>
Reviewed-by: David von Oheimb <david.von.oheimb@siemens.com>
(Merged from #18821)

(cherry picked from commit c02036e)
openssl-machine pushed a commit that referenced this pull request Nov 23, 2022
@DDvO @t8m
test/timing_load_creds.c: fix coding style and other (mostly minor) i…
40230f6 
…ssues

Reviewed-by: Dmitry Belyavskiy <beldmit@gmail.com>
Reviewed-by: Paul Dale <pauli@openssl.org>
Reviewed-by: David von Oheimb <david.von.oheimb@siemens.com>
(Merged from #18821)

(cherry picked from commit 45479dc)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@levitte levitte levitte left review comments

@beldmit beldmit beldmit approved these changes

@paulidale paulidale paulidale approved these changes

@slontis slontis Awaiting requested review from slontis

@tmshort tmshort Awaiting requested review from tmshort

Assignees

No one assigned

Labels

approval: ready to merge The 24 hour grace period has passed, ready to merge branch: master Applies to master branch triaged: feature The issue/pr requests/adds a feature

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@DDvO @beldmit @tmshort @openssl-machine @levitte @paulidale @t8m @richsalz