adding external oqsprovider testing#17832
Closed
baentsch wants to merge 4 commits intoopenssl:masterfrom
Closed
Conversation
Member
|
This already looks very good! Thanks for the PR! |
Member
|
There are some docs fixes to please the markdown linter, and we should add the oqs tests to the external tests CI, either as part of the existing external_tests task or as its own, like we do for pyca. |
Contributor
Author
Both done. |
levitte
requested changes
Mar 8, 2022
levitte
approved these changes
Mar 8, 2022
mattcaswell
approved these changes
Mar 8, 2022
t8m
approved these changes
Mar 8, 2022
Collaborator
|
This pull request is ready to merge |
Member
|
Squashed the commits and slightly reworded the commit message and merged to master branch. Thank you for your contribution! |
openssl-machine
pushed a commit
that referenced
this pull request
Mar 9, 2022
Including running the oqsprovider external test in the CI external test build. Reviewed-by: Richard Levitte <levitte@openssl.org> Reviewed-by: Matt Caswell <matt@openssl.org> Reviewed-by: Tomas Mraz <tomas@openssl.org> (Merged from #17832)
t8m
pushed a commit
to t8m/openssl
that referenced
this pull request
Nov 4, 2022
Including running the oqsprovider external test in the CI external test build. Reviewed-by: Richard Levitte <levitte@openssl.org> Reviewed-by: Matt Caswell <matt@openssl.org> Reviewed-by: Tomas Mraz <tomas@openssl.org> (Merged from openssl#17832) (cherry picked from commit fa66f62)
t8m
pushed a commit
to t8m/openssl
that referenced
this pull request
Nov 4, 2022
Including running the oqsprovider external test in the CI external test build. Reviewed-by: Richard Levitte <levitte@openssl.org> Reviewed-by: Matt Caswell <matt@openssl.org> Reviewed-by: Tomas Mraz <tomas@openssl.org> (Merged from openssl#17832) (cherry picked from commit fa66f62)
t8m
pushed a commit
to t8m/openssl
that referenced
this pull request
Nov 9, 2022
Including running the oqsprovider external test in the CI external test build. Reviewed-by: Richard Levitte <levitte@openssl.org> Reviewed-by: Matt Caswell <matt@openssl.org> Reviewed-by: Tomas Mraz <tomas@openssl.org> (Merged from openssl#17832) (cherry picked from commit fa66f62)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As per #17733 (comment) adding oqsprovider as a submodule for (external) testing.