Implement pem_read_key directly through OSSL_DECODER#15045
Closed
t8m wants to merge 2 commits intoopenssl:masterfrom
Closed
Implement pem_read_key directly through OSSL_DECODER#15045t8m wants to merge 2 commits intoopenssl:masterfrom
t8m wants to merge 2 commits intoopenssl:masterfrom
Conversation
Member
Author
|
This is still WIP because there is missing legacy PEM handling. |
Member
Author
As reflected in the external GOST engine test failure. |
Member
Yes :) |
levitte
reviewed
Apr 27, 2021
Member
Author
|
Ready for review now. |
Member
Author
|
I do not think the non-caching build failure is relevant. This seems to be some intermittent leak in the threads test. |
Member
Author
|
Ping for reviews |
dc12f9c to
5a1d7eb
Compare
Member
Author
|
Rebased again, ping again for reviews! |
Collaborator
|
This pull request is ready to merge |
Member
Author
|
Rebased to resolve the conflict in checksums |
Member
Author
|
One more clean rebase to test the FIPS checksums action |
Using OSSL_STORE is too heavy and breaks things. There were also needed various fixes mainly for missing proper handling of the SM2 keys in the OSSL_DECODER. Fixes openssl#14788
Member
Author
|
And one more |
Member
Author
|
Hooray! The labeling works. |
openssl-machine
pushed a commit
that referenced
this pull request
May 13, 2021
Reviewed-by: Paul Dale <pauli@openssl.org> (Merged from #15045)
Member
Author
|
Merged to master. Thank you for the review! |
devnexen
pushed a commit
to devnexen/openssl
that referenced
this pull request
Jul 7, 2021
Using OSSL_STORE is too heavy and breaks things. There were also needed various fixes mainly for missing proper handling of the SM2 keys in the OSSL_DECODER. Fixes openssl#14788 Reviewed-by: Paul Dale <pauli@openssl.org> (Merged from openssl#15045)
devnexen
pushed a commit
to devnexen/openssl
that referenced
this pull request
Jul 7, 2021
Reviewed-by: Paul Dale <pauli@openssl.org> (Merged from openssl#15045)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Using OSSL_STORE is too heavy and breaks things.
There were also needed various fixes mainly for missing proper
handling of the SM2 keys in the OSSL_DECODER.
Fixes #14788
Checklist