Skip to content

minor fixes in engines/ccgost #1449

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
cristian-stoica wants to merge 2 commits into from
Closed

minor fixes in engines/ccgost #1449

cristian-stoica wants to merge 2 commits into from

Conversation

@cristian-stoica
Copy link
Contributor

@cristian-stoica cristian-stoica commented Aug 12, 2016

No description provided.

@richsalz richsalz added this to the 1.0.2 milestone Aug 12, 2016
@mattcaswell
Copy link
Member

mattcaswell commented Aug 26, 2016

+1

@mattcaswell
Copy link
Member

mattcaswell commented Aug 26, 2016

Needs another team review.

@richsalz richsalz added the approval: done This pull request has the required number of approvals label Aug 26, 2016
@richsalz
Copy link
Contributor

richsalz commented Aug 26, 2016

+1

@mattcaswell mattcaswell added the hold: cla required The contributor needs to submit a license agreement label Aug 26, 2016
@levitte
Copy link
Member

levitte commented Nov 15, 2016

@cristian-stoica, I'm not sure if you got this feedback: we need a signed CLA from you to include this PR into our codebase. See https://www.openssl.org/policies/cla.html

Note that the email address(es) you specify in the CLA must match the address(es) you use in your commits.

@cristian-stoica
Copy link
Contributor Author

cristian-stoica commented Nov 16, 2016

@levitte
See also my other reply on the same issue in another patch. Maybe if Geoff Thorpe can sign off these patches we can make progress before legal signs the CLA.

Cristian Stoica added 2 commits February 10, 2017 15:40
merge two mutual exclusive #ifdefs to improve clarity
35cf235 
CLA: trivial

Signed-off-by: Cristian Stoica <cristian.stoica@nxp.com>
fix several typos in README.gost
452c674 
CLA: trivial

Signed-off-by: Cristian Stoica <cristian.stoica@nxp.com>
@cristian-stoica
Copy link
Contributor Author

cristian-stoica commented Feb 10, 2017

@levitte Please see updated pull request with CLA: trivial

@levitte
Copy link
Member

levitte commented Feb 10, 2017

@richsalz, @mattcaswell, you are the reviewers, please say if you agree with regards to triviality.

@richsalz
Copy link
Contributor

richsalz commented Feb 10, 2017

the code is trivial, the wording changes are obvoius. so yes, trivial.

@mattcaswell
Copy link
Member

mattcaswell commented Feb 10, 2017

Agreed - trivial.

@richsalz richsalz removed the reviewed label Mar 2, 2017
@richsalz richsalz closed this Nov 21, 2017
@richsalz richsalz reopened this Nov 21, 2017
@openssl-machine openssl-machine removed the hold: cla required The contributor needs to submit a license agreement label Nov 21, 2017
@mattcaswell
Copy link
Member

mattcaswell commented Jan 23, 2018

Merged. Better late than never.

levitte pushed a commit that referenced this pull request Jan 23, 2018
@mattcaswell
merge two mutual exclusive #ifdefs to improve clarity
87402d4 
CLA: trivial

Signed-off-by: Cristian Stoica <cristian.stoica@nxp.com>

Reviewed-by: Rich Salz <rsalz@openssl.org>
Reviewed-by: Matt Caswell <matt@openssl.org>
(Merged from #1449)
levitte pushed a commit that referenced this pull request Jan 23, 2018
@mattcaswell
fix several typos in README.gost
bb9ca2a 
CLA: trivial

Signed-off-by: Cristian Stoica <cristian.stoica@nxp.com>

Reviewed-by: Rich Salz <rsalz@openssl.org>
Reviewed-by: Matt Caswell <matt@openssl.org>
(Merged from #1449)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

approval: done This pull request has the required number of approvals

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@cristian-stoica @mattcaswell @richsalz @levitte @openssl-machine