Skip to content

Fix test_cmp_vfy failures with FUZZING_BUILD_MODE_UNSAFE_FOR_PRODUCTION#11585

Closed
DDvO wants to merge 1 commit intoopenssl:masterfrom
siemens:fix_cmp_vfy_tests_while_fuzzing
Closed

Fix test_cmp_vfy failures with FUZZING_BUILD_MODE_UNSAFE_FOR_PRODUCTION#11585
DDvO wants to merge 1 commit intoopenssl:masterfrom
siemens:fix_cmp_vfy_tests_while_fuzzing

Conversation

@DDvO
Copy link
Copy Markdown
Contributor

@DDvO DDvO commented Apr 20, 2020

Should fix issue reported today in #11386

  • tests are added or updated

@DDvO DDvO added the severity: urgent Fixes an urgent issue (exempt from 24h grace period) label Apr 20, 2020
@DDvO DDvO mentioned this pull request Apr 20, 2020
1 task
@mattcaswell
Copy link
Copy Markdown
Member

[extended tests]

That line needs to be in the actual commit message. Can you force push an update? Otherwise this looks good (and I agree this is urgent).

@DDvO DDvO force-pushed the fix_cmp_vfy_tests_while_fuzzing branch from 8f16b32 to 6d42dd7 Compare April 20, 2020 15:54
@DDvO
Copy link
Copy Markdown
Contributor Author

DDvO commented Apr 20, 2020

Oops, done.

Copy link
Copy Markdown
Member

@mattcaswell mattcaswell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved assuming the CIs pass (or at least don't fail in a relevant way)

@mattcaswell mattcaswell added the approval: done This pull request has the required number of approvals label Apr 20, 2020
@DDvO
Copy link
Copy Markdown
Contributor Author

DDvO commented Apr 20, 2020

So I'll merge this as soon as the CI tests passed...

@DDvO
Copy link
Copy Markdown
Contributor Author

DDvO commented Apr 21, 2020

All four CI failures that have been reported: https://travis-ci.org/github/openssl/openssl/builds/677315133
are not CMP related but due to some (the same?) EVP issue. So I've just merged this.

@DDvO DDvO closed this Apr 21, 2020
openssl-machine pushed a commit that referenced this pull request Apr 21, 2020
[extended tests]

Reviewed-by: Matt Caswell <matt@openssl.org>
Reviewed-by: David von Oheimb <david.von.oheimb@siemens.com>
(Merged from #11585)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approval: done This pull request has the required number of approvals severity: urgent Fixes an urgent issue (exempt from 24h grace period)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants