Closed
Conversation
slontis
approved these changes
Feb 22, 2020
slontis
requested changes
Feb 22, 2020
Member
slontis
left a comment
There was a problem hiding this comment.
Take it back - travis is still failing
Property "default" no longer exists, replace "default=yes" with "provider=default"
054dbe0 to
89c4591
Compare
Member
Author
|
Turns out I overdid this PR, one fix cancelled out the other error. It's now been reduced to something that should work |
paulidale
approved these changes
Feb 24, 2020
Contributor
|
Travis timeout isn't relevant. |
openssl-machine
pushed a commit
that referenced
this pull request
Feb 24, 2020
Property "default" no longer exists, replace "default=yes" with "provider=default" Reviewed-by: Paul Dale <paul.dale@oracle.com> (Merged from #11150)
Contributor
|
Ah, the PING! was deleted :) |
Member
Author
|
Yeah, I got confused because the tab I had this in wasn't updated before I posted... |
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A couple of incorrect things went through in merges of diverse pieces of code.
URGENT! We have builds failing because of this