Fix error handling in x509v3_cache_extensions and related functions#10755
Fix error handling in x509v3_cache_extensions and related functions#10755bernd-edlinger wants to merge 11 commits intoopenssl:masterfrom
Conversation
28c5aea to
c9f275f
Compare
Basically we use EXFLAG_INVALID for all kinds of out of memory and all kinds of parse errors in x509v3_cache_extensions. [extended tests]
c9f275f to
f919606
Compare
FdaSilvaYY
left a comment
There was a problem hiding this comment.
EXFLAG_INVALID is not very well documented .
I suggest to add something like this :
This bit may also be raised after some internal cert-processing failures
So it may not be related to the processed object itself.
crypto/x509/v3_purp.c
Outdated
| BASIC_CONSTRAINTS_free(bs); | ||
| x->ex_flags |= EXFLAG_BCONS; | ||
| } | ||
| else if (i != -1) { |
There was a problem hiding this comment.
Style nit: on previous line.
| name = X509_get_subject_name(x->x509); | ||
| X509_digest(x->x509, evpmd, digest, NULL); | ||
| if (!X509_digest(x->x509, evpmd, digest, NULL)) { | ||
| BIO_printf(bio_err, "out of memory\n"); |
There was a problem hiding this comment.
Is out of memory the only possible failure?
There was a problem hiding this comment.
I think, only on X509*_get_ext_d2i a syntax or OOM error can both be possible
crypto/x509/v3_purp.c
Outdated
| PROXY_CERT_INFO_EXTENSION_free(pci); | ||
| x->ex_flags |= EXFLAG_PROXY; | ||
| } | ||
| else if (i != -1) { |
There was a problem hiding this comment.
Style nit: on previous line.
|
Mind, lookin at #10756 as well? |
|
24 hours has passed since 'approval: done' was set, but as this PR has been updated in that time the label 'approval: ready to merge' is not being automatically set. Please review the updates and set the label manually. |
Basically we use EXFLAG_INVALID for all kinds of out of memory and all kinds of parse errors in x509v3_cache_extensions. [extended tests] Reviewed-by: Tomas Mraz <tmraz@fedoraproject.org> (Merged from #10755)
|
Merged to master 7e06a67 |
Basically we use EXFLAG_INVALID for all kinds of out of memory and
all kinds of parse errors in x509v3_cache_extensions.
[extended tests]
Checklist