Skip to content

Conversation

@FdaSilvaYY
Copy link
Contributor

@FdaSilvaYY FdaSilvaYY commented May 11, 2016

Fix some missing OBJ_dup failure checks.
Merged from
https://boringssl.googlesource.com/boringssl/+/0ce78a757d815c0dde9ed5884229f3a5b2cb3e9c%5E!


It's a quick and short change.

@levitte
Copy link
Member

levitte commented May 12, 2016

+1

@levitte levitte added this to the 1.1.0 milestone May 12, 2016
@kroeckx kroeckx added the approval: done This pull request has the required number of approvals label May 12, 2016
@kroeckx
Copy link
Member

kroeckx commented May 12, 2016

+1

@FdaSilvaYY FdaSilvaYY force-pushed the fix-missing-failure-checks branch from 989e590 to db0f786 Compare May 12, 2016 20:23
@FdaSilvaYY
Copy link
Contributor Author

Ping @richsalz, as this PR is ready to commit...
There at least 5 staging PR's label'ed "second-review", is there any particular reason ?

@richsalz
Copy link
Contributor

My $DAYJOB is taking precedence right now, others from the team now they have to step up :)

@FdaSilvaYY
Copy link
Contributor Author

Ok, I get it. I understand now, why your commit-rate has dropped ;)

@FdaSilvaYY FdaSilvaYY force-pushed the fix-missing-failure-checks branch from db0f786 to 90e9865 Compare May 15, 2016 20:09
@levitte
Copy link
Member

levitte commented May 16, 2016

Merged!

@levitte levitte closed this May 16, 2016
levitte pushed a commit that referenced this pull request May 16, 2016
Fix some missing OBJ_dup failure checks.
Merged from
https://boringssl.googlesource.com/boringssl/+/0ce78a757d815c0dde9ed5884229f3a5b2cb3e9c%5E!

Reviewed-by: Kurt Roeckx <kurt@openssl.org>
Reviewed-by: Richard Levitte <levitte@openssl.org>
(Merged from #1057)
@FdaSilvaYY FdaSilvaYY deleted the fix-missing-failure-checks branch May 16, 2016 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approval: done This pull request has the required number of approvals

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants