Rename "private" file, doc doc changes in CHANGES #10039
Conversation
|
"defines" is also not quite right, or |
|
Happy to change the name to anything more useful just tell me what it should be. The current name was a bad mistake on my part. |
CHANGES
Outdated
There was a problem hiding this comment.
„Hundreds of improvements...“ by „[Many]“? Sounds a little bit exaggerated and vague at the same time.
I‘d suggest:
„A lot of improvements...“ by „[Rich Salz and others]“. (or „e.a.“)
There was a problem hiding this comment.
If you think that others made outstanding contributions to the documentation and should be mentioned too, feel free to add them.
There was a problem hiding this comment.
I made\ over 2000 changes via git diff master | grep '^+' | wc -l so I reworded it and put myself as the author. Other folks should add themselves.
There was a problem hiding this comment.
Oh, I see. I wasn't aware that the "Hundreds of improvements" were measured in line counts ;-)
There was a problem hiding this comment.
put myself as the author
You truly deserve the credits IMHO. Nobody else put so much effort into cleaning up the documentation as you did recently.
How about „extra.sym“ or „extra.syms“? |
|
"missing.num" is now called "other-names.num" |
|
Frankly, .num is wrong. |
|
Let's call it |
|
I'm serious in my pickiness |
|
@levitte I no longer care, tell me what name you want. |
|
|
|
(I do like the |
|
Not thrilled with the non-common ".syms" extension, but I did it. |
|
It's not like ".num" is much more common. 😉 |
|
I would wait until the build-fixing PR goes in; I will have to rebase. |
|
Rebased and pushed. I don't know if this needs another review or not. |
It was a clean rebase, yeah? In that case, no |
|
There were merge issues in find-doc-nits, as was to be expected. |
|
In that cases, it's better to re-review |
|
Should be just a reconfirm, the changes to find-doc-nits in this PR were simple. |
Use err() for find-doc-nits -e output Doing this meant we could remove the -s flag, so we do so; move option/help stuff to top of script. Add a CHANGES entry. Rename missing to other.syms
|
Merged. 185ec4b Rename "private" file, doc doc changes in CHANGES |
Use err() for find-doc-nits -e output Doing this meant we could remove the -s flag, so we do so; move option/help stuff to top of script. Add a CHANGES entry. Rename missing to other.syms Reviewed-by: Tomas Mraz <tmraz@fedoraproject.org> Reviewed-by: Richard Levitte <levitte@openssl.org> (Merged from #10039)
This also fixes a long-standing source of confusion, dating dating back to when I first created the file. "private.num" is really "defines.num"
Removed the -p option; it's always on now.