Add methods and Outputs for calculating the momentum of a Body#3962
Merged
nickbianco merged 3 commits intomainfrom Nov 9, 2024
Merged
Add methods and Outputs for calculating the momentum of a Body#3962nickbianco merged 3 commits intomainfrom
Outputs for calculating the momentum of a Body#3962nickbianco merged 3 commits intomainfrom
Conversation
carmichaelong
approved these changes
Nov 8, 2024
Member
carmichaelong
left a comment
There was a problem hiding this comment.
LGTM. I'm inclined to agree that since these are such light wrappers, it's OK to not have unit tests.
Member
Author
|
Thanks @carmichaelong! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes issue #3937
Brief summary of changes
Added the methods
calcMomentumAboutOrigin,calcAngularMomentumAboutOrigin,calcLinearMomentumAboutOrigin,calcMomentumAboutMassCenter,calcAngularMomentumAboutMassCenter, andcalcLinearMomentumAboutMassCentertoBodyand associatedOutputs. This change required updating the Simbody commit to include a fix for a missingconstqualifier inMobilizedBody.I also cleaned up a few unused using directives/declarations in
Bodyand fixed some misplaced changelog entries.Testing I've completed
Tested all methods and
Outputs locally using a simple sliding mass model. Could add unittests if desired, but these methods should all be tested in Simbody.Looking for feedback on...
CHANGELOG.md (choose one)
This change is