Add const qualification to calcBodyMomentumAboutBodyOriginInGround()#803
Merged
sherm1 merged 1 commit intosimbody:masterfrom Nov 7, 2024
Merged
Conversation
sherm1
approved these changes
Nov 7, 2024
Member
sherm1
left a comment
There was a problem hiding this comment.
Thanks, Nick!
Windows CI failed but looks unrelated.
Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @nickbianco)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While writing wrapper functions in OpenSim for accessing body momentum calculations from Simbody, I noticed that
calcBodyMomentumAboutBodyOriginInGround()was notconstqualified.Opening the PR since I don't see any reason why it shouldn't be, and I receive no compiler errors when adding it in.
This change is