[RELEASE-1.8] Re-introducing https://github.com/knative/serving/pull/13337 #179
Conversation
|
@ReToCode: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/unhold /cc @skonto |
|
It seems 1.8 branch missed knative@a6a18b8 but we need to cherry-pick? |
And if we cherry-pick it we need to add a patch in |
Hm but then let's not cherry-pick it. S-O does handle that transformation anyways. I think this is why it was not on the revert-list in the first place as it was introduced upstream in 1.9. WDYT? /cc @skonto |
|
Sure, no problem for me to handle it in SO's transformation if it is more simple than the temporary patch here. |
d56a360 to
dcb4ef0
Compare
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: nak3, ReToCode The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
JIRA: https://issues.redhat.com/browse/SRVCOM-2300
Changes
/hold openshift/release#36606 is necessary for the tests to pass.
/cc @mgencur, @skonto