Skip to content

Conversation

@ReToCode
Copy link
Contributor

JIRA: https://issues.redhat.com/browse/SRVCOM-2303

Changes

  • Use OCP 4.12 for Serving 1.6, 1.7, 1.8 as upper bound
  • Drop OCP 4.8 and OCP 4.9 builds for Serving 1.8

@openshift-ci-robot
Copy link
Contributor

@ReToCode: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-openshift-knative-serving-release-v1.6-412-e2e-aws-ocp-412 openshift-knative/serving presubmit Presubmit changed
pull-ci-openshift-knative-serving-release-v1.6-412-images openshift-knative/serving presubmit Presubmit changed
pull-ci-openshift-knative-serving-release-v1.7-412-e2e-aws-ocp-412 openshift-knative/serving presubmit Presubmit changed
pull-ci-openshift-knative-serving-release-v1.7-412-images openshift-knative/serving presubmit Presubmit changed
pull-ci-openshift-knative-serving-release-v1.8-410-e2e-aws-ocp-410 openshift-knative/serving presubmit Presubmit changed
pull-ci-openshift-knative-serving-release-v1.8-410-images openshift-knative/serving presubmit Presubmit changed
pull-ci-openshift-knative-serving-release-v1.8-412-e2e-aws-ocp-412 openshift-knative/serving presubmit Presubmit changed
pull-ci-openshift-knative-serving-release-v1.8-412-images openshift-knative/serving presubmit Presubmit changed
pull-ci-openshift-knative-serving-release-v1.7-411-e2e-aws-ocp-411 openshift-knative/serving presubmit Ci-operator config changed
pull-ci-openshift-knative-serving-release-v1.7-411-images openshift-knative/serving presubmit Ci-operator config changed
pull-ci-openshift-knative-serving-release-v1.8-411-e2e-aws-ocp-411 openshift-knative/serving presubmit Ci-operator config changed
pull-ci-openshift-knative-serving-release-v1.8-411-images openshift-knative/serving presubmit Ci-operator config changed
pull-ci-openshift-knative-serving-release-v1.6-411-e2e-aws-ocp-411 openshift-knative/serving presubmit Ci-operator config changed
pull-ci-openshift-knative-serving-release-v1.6-411-images openshift-knative/serving presubmit Ci-operator config changed
periodic-ci-openshift-knative-serving-release-v1.8-412-e2e-aws-ocp-412-continuous N/A periodic Periodic changed
periodic-ci-openshift-knative-serving-release-v1.8-412-e2e-aws-ocp-tls-412 N/A periodic Periodic changed
periodic-ci-openshift-knative-serving-release-v1.6-412-e2e-aws-ocp-tls-412 N/A periodic Periodic changed
periodic-ci-openshift-knative-serving-release-v1.7-412-e2e-aws-ocp-412-continuous N/A periodic Periodic changed
periodic-ci-openshift-knative-serving-release-v1.7-412-e2e-aws-ocp-tls-412 N/A periodic Periodic changed
periodic-ci-openshift-knative-serving-release-v1.6-412-e2e-aws-ocp-412-continuous N/A periodic Periodic changed

Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals.

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 10 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 20 rehearsals
Comment: /pj-rehearse max to run up to 35 rehearsals
Comment: /pj-rehearse auto-ack to run up to 10 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse refresh to get an updated list of affected jobs (useful if you have new pushes to the branch)

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@ReToCode
Copy link
Contributor Author

/pj-rehearse more

@openshift-ci openshift-ci bot requested review from alanfx and mgencur February 21, 2023 14:21
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 21, 2023
@ReToCode
Copy link
Contributor Author

/cc @skonto , @mgencur

@ReToCode
Copy link
Contributor Author

/pj-rehearse pull-ci-openshift-knative-serving-release-v1.7-412-e2e-aws-ocp-412

@skonto
Copy link
Contributor

skonto commented Feb 22, 2023

/hold for @mgencur to chime in.

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 22, 2023
@skonto
Copy link
Contributor

skonto commented Feb 22, 2023

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 22, 2023
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Feb 22, 2023
@mgencur
Copy link
Contributor

mgencur commented Feb 22, 2023

/lgtm
Please unhold when ready.

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 22, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 22, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mgencur, ReToCode, skonto

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ReToCode
Copy link
Contributor Author

/unhold

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 22, 2023
@ReToCode
Copy link
Contributor Author

/pj-rehearse auto-ack

@ReToCode
Copy link
Contributor Author

/retest

2 similar comments
@ReToCode
Copy link
Contributor Author

/retest

@ReToCode
Copy link
Contributor Author

/retest

@ReToCode
Copy link
Contributor Author

/pj-rehearse refresh

@openshift-ci-robot
Copy link
Contributor

@ReToCode: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-openshift-knative-serving-release-v1.6-412-e2e-aws-ocp-412 openshift-knative/serving presubmit Presubmit changed
pull-ci-openshift-knative-serving-release-v1.6-412-images openshift-knative/serving presubmit Presubmit changed
pull-ci-openshift-knative-serving-release-v1.7-412-e2e-aws-ocp-412 openshift-knative/serving presubmit Presubmit changed
pull-ci-openshift-knative-serving-release-v1.7-412-images openshift-knative/serving presubmit Presubmit changed
pull-ci-openshift-knative-serving-release-v1.8-410-e2e-aws-ocp-410 openshift-knative/serving presubmit Presubmit changed
pull-ci-openshift-knative-serving-release-v1.8-410-images openshift-knative/serving presubmit Presubmit changed
pull-ci-openshift-knative-serving-release-v1.8-412-e2e-aws-ocp-412 openshift-knative/serving presubmit Presubmit changed
pull-ci-openshift-knative-serving-release-v1.8-412-images openshift-knative/serving presubmit Presubmit changed
pull-ci-openshift-knative-serving-release-v1.6-411-e2e-aws-ocp-411 openshift-knative/serving presubmit Ci-operator config changed
pull-ci-openshift-knative-serving-release-v1.6-411-images openshift-knative/serving presubmit Ci-operator config changed
pull-ci-openshift-knative-serving-release-v1.8-411-e2e-aws-ocp-411 openshift-knative/serving presubmit Ci-operator config changed
pull-ci-openshift-knative-serving-release-v1.8-411-images openshift-knative/serving presubmit Ci-operator config changed
pull-ci-openshift-knative-serving-release-v1.7-411-e2e-aws-ocp-411 openshift-knative/serving presubmit Ci-operator config changed
pull-ci-openshift-knative-serving-release-v1.7-411-images openshift-knative/serving presubmit Ci-operator config changed
periodic-ci-openshift-knative-serving-release-v1.7-412-e2e-aws-ocp-tls-412 N/A periodic Periodic changed
periodic-ci-openshift-knative-serving-release-v1.8-412-e2e-aws-ocp-tls-412 N/A periodic Periodic changed
periodic-ci-openshift-knative-serving-release-v1.7-412-e2e-aws-ocp-412-continuous N/A periodic Periodic changed
periodic-ci-openshift-knative-serving-release-v1.8-412-e2e-aws-ocp-412-continuous N/A periodic Periodic changed
periodic-ci-openshift-knative-serving-release-v1.6-412-e2e-aws-ocp-tls-412 N/A periodic Periodic changed
periodic-ci-openshift-knative-serving-release-v1.6-412-e2e-aws-ocp-412-continuous N/A periodic Periodic changed
Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 10 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 20 rehearsals
Comment: /pj-rehearse max to run up to 35 rehearsals
Comment: /pj-rehearse auto-ack to run up to 10 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse refresh to get an updated list of affected jobs (useful if you have new pushes to the branch)

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@ReToCode
Copy link
Contributor Author

/pj-rehearse more

@ReToCode
Copy link
Contributor Author

/pj-rehearse ack

@openshift-ci-robot openshift-ci-robot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Feb 23, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 23, 2023

@ReToCode: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit 614222d into openshift:master Feb 23, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 23, 2023

@ReToCode: Updated the following 2 configmaps:

  • job-config-misc configmap in namespace ci at cluster app.ci using the following files:
    • key openshift-knative-serving-release-v1.6-periodics.yaml using file ci-operator/jobs/openshift-knative/serving/openshift-knative-serving-release-v1.6-periodics.yaml
    • key openshift-knative-serving-release-v1.6-postsubmits.yaml using file ci-operator/jobs/openshift-knative/serving/openshift-knative-serving-release-v1.6-postsubmits.yaml
    • key openshift-knative-serving-release-v1.6-presubmits.yaml using file ci-operator/jobs/openshift-knative/serving/openshift-knative-serving-release-v1.6-presubmits.yaml
    • key openshift-knative-serving-release-v1.7-periodics.yaml using file ci-operator/jobs/openshift-knative/serving/openshift-knative-serving-release-v1.7-periodics.yaml
    • key openshift-knative-serving-release-v1.7-postsubmits.yaml using file ci-operator/jobs/openshift-knative/serving/openshift-knative-serving-release-v1.7-postsubmits.yaml
    • key openshift-knative-serving-release-v1.7-presubmits.yaml using file ci-operator/jobs/openshift-knative/serving/openshift-knative-serving-release-v1.7-presubmits.yaml
    • key openshift-knative-serving-release-v1.8-periodics.yaml using file ci-operator/jobs/openshift-knative/serving/openshift-knative-serving-release-v1.8-periodics.yaml
    • key openshift-knative-serving-release-v1.8-postsubmits.yaml using file ci-operator/jobs/openshift-knative/serving/openshift-knative-serving-release-v1.8-postsubmits.yaml
    • key openshift-knative-serving-release-v1.8-presubmits.yaml using file ci-operator/jobs/openshift-knative/serving/openshift-knative-serving-release-v1.8-presubmits.yaml
  • ci-operator-misc-configs configmap in namespace ci at cluster app.ci using the following files:
    • key openshift-knative-serving-release-v1.6__411.yaml using file ci-operator/config/openshift-knative/serving/openshift-knative-serving-release-v1.6__411.yaml
    • key openshift-knative-serving-release-v1.6__412.yaml using file ci-operator/config/openshift-knative/serving/openshift-knative-serving-release-v1.6__412.yaml
    • key openshift-knative-serving-release-v1.7__411.yaml using file ci-operator/config/openshift-knative/serving/openshift-knative-serving-release-v1.7__411.yaml
    • key openshift-knative-serving-release-v1.7__412.yaml using file ci-operator/config/openshift-knative/serving/openshift-knative-serving-release-v1.7__412.yaml
    • key openshift-knative-serving-release-v1.8__48.yaml using file ``
    • key openshift-knative-serving-release-v1.8__410.yaml using file ci-operator/config/openshift-knative/serving/openshift-knative-serving-release-v1.8__410.yaml
    • key openshift-knative-serving-release-v1.8__411.yaml using file ci-operator/config/openshift-knative/serving/openshift-knative-serving-release-v1.8__411.yaml
    • key openshift-knative-serving-release-v1.8__49.yaml using file ``
    • key openshift-knative-serving-release-v1.8__412.yaml using file ci-operator/config/openshift-knative/serving/openshift-knative-serving-release-v1.8__412.yaml
Details

In response to this:

JIRA: https://issues.redhat.com/browse/SRVCOM-2303

Changes

  • Use OCP 4.12 for Serving 1.6, 1.7, 1.8 as upper bound
  • Drop OCP 4.8 and OCP 4.9 builds for Serving 1.8

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ReToCode ReToCode deleted the serving-ocp-12 branch February 23, 2023 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. rehearsals-ack Signifies that rehearsal jobs have been acknowledged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants