Skip to content

Upgrade stolostron thanos build image to go1.21#51890

Merged
openshift-merge-bot[bot] merged 1 commit intoopenshift:masterfrom
subbarao-meduri:bump-stolo-thanos-build-image-version-go-1.21
May 10, 2024
Merged

Upgrade stolostron thanos build image to go1.21#51890
openshift-merge-bot[bot] merged 1 commit intoopenshift:masterfrom
subbarao-meduri:bump-stolo-thanos-build-image-version-go-1.21

Conversation

@subbarao-meduri
Copy link
Copy Markdown
Contributor

@subbarao-meduri subbarao-meduri commented May 10, 2024

No description provided.

@subbarao-meduri
upgrade stolostron thanos build image to go1.21
1c5747f 
Signed-off-by: Subbarao Meduri <smeduri@redhat.com>
@subbarao-meduri
Copy link
Copy Markdown
Contributor Author

subbarao-meduri commented May 10, 2024

/assign @saswatamcode

saswatamcode
saswatamcode approved these changes May 10, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@saswatamcode saswatamcode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot
Copy link
Copy Markdown
Contributor

openshift-ci-robot commented May 10, 2024

[REHEARSALNOTIFIER]
@subbarao-meduri: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-stolostron-thanos-release-2.11-e2e-kind stolostron/thanos presubmit Ci-operator config changed
pull-ci-stolostron-thanos-release-2.11-images stolostron/thanos presubmit Ci-operator config changed
pull-ci-stolostron-thanos-release-2.11-ocm-ci-rbac stolostron/thanos presubmit Ci-operator config changed
pull-ci-stolostron-thanos-release-2.11-pr-image-mirror stolostron/thanos presubmit Ci-operator config changed
pull-ci-stolostron-thanos-release-2.11-test-unit stolostron/thanos presubmit Ci-operator config changed

Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals.

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse abort to abort all active rehearsals

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@openshift-ci openshift-ci bot requested review from marcolan018 and morvencao May 10, 2024 15:38
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci bot commented May 10, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: saswatamcode, subbarao-meduri

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 10, 2024
@subbarao-meduri
Copy link
Copy Markdown
Contributor Author

subbarao-meduri commented May 10, 2024

/pj-rehearse pull-ci-stolostron-thanos-release-2.11-test-unit

@openshift-ci-robot
Copy link
Copy Markdown
Contributor

openshift-ci-robot commented May 10, 2024

@subbarao-meduri: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 10, 2024
@subbarao-meduri
Copy link
Copy Markdown
Contributor Author

subbarao-meduri commented May 10, 2024

/pj-rehearse pull-ci-stolostron-thanos-release-2.11-e2e-kind

@openshift-ci-robot
Copy link
Copy Markdown
Contributor

openshift-ci-robot commented May 10, 2024

@subbarao-meduri: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@subbarao-meduri
Copy link
Copy Markdown
Contributor Author

subbarao-meduri commented May 10, 2024

/pj-rehearse ack

@openshift-ci-robot
Copy link
Copy Markdown
Contributor

openshift-ci-robot commented May 10, 2024

@subbarao-meduri: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci-robot openshift-ci-robot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label May 10, 2024
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci bot commented May 10, 2024

@subbarao-meduri: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit 36706c6 into openshift:master May 10, 2024
@subbarao-meduri subbarao-meduri mentioned this pull request May 10, 2024
Merged
jbpratt pushed a commit to jbpratt/release that referenced this pull request May 30, 2024
@subbarao-meduri @jbpratt
upgrade stolostron thanos build image to go1.21 (openshift#51890)
b747843 
Signed-off-by: Subbarao Meduri <smeduri@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@marcolan018 marcolan018 Awaiting requested review from marcolan018

@morvencao morvencao Awaiting requested review from morvencao

1 more reviewer

@saswatamcode saswatamcode saswatamcode approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@saswatamcode saswatamcode

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. rehearsals-ack Signifies that rehearsal jobs have been acknowledged

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@subbarao-meduri @openshift-ci-robot @saswatamcode