Skip to content

Test openshift/imagebuilder with go 1.20#48288

Merged
openshift-merge-bot[bot] merged 1 commit intoopenshift:masterfrom
nalind:imagebuilder-with-go-1.20
Feb 5, 2024
Merged

Test openshift/imagebuilder with go 1.20#48288
openshift-merge-bot[bot] merged 1 commit intoopenshift:masterfrom
nalind:imagebuilder-with-go-1.20

Conversation

@nalind
Copy link
Copy Markdown
Member

@nalind nalind commented Jan 31, 2024

Run our unit tests with a not-archived-yet version of Go. Version 1.22 is about to be released, but more importantly, one of our dependencies is about to start using functions that were added to the standard library in version 1.20.

Run our unit tests with a not-archived-yet version of Go.  Version 1.22
is about to be released, but more importantly, one of our dependencies
is about to start using functions that were added to the standard
library in version 1.20.

Signed-off-by: Nalin Dahyabhai <nalin@redhat.com>
@nalind
Copy link
Copy Markdown
Member Author

nalind commented Jan 31, 2024

This blocks openshift/imagebuilder#276.

@openshift-ci-robot
Copy link
Copy Markdown
Contributor

[REHEARSALNOTIFIER]
@nalind: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-openshift-imagebuilder-master-unit openshift/imagebuilder presubmit Ci-operator config changed

Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals.

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse abort to abort all active rehearsals

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@openshift-ci openshift-ci bot requested review from mrunalp and rhatdan January 31, 2024 18:33
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 31, 2024
@nalind
Copy link
Copy Markdown
Member Author

nalind commented Jan 31, 2024

/pj-rehearse

@nalind
Copy link
Copy Markdown
Member Author

nalind commented Feb 2, 2024

/pj-rehearse auto-ack

@openshift-ci-robot openshift-ci-robot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Feb 2, 2024
@rhatdan
Copy link
Copy Markdown

rhatdan commented Feb 5, 2024

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 5, 2024
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci bot commented Feb 5, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nalind, rhatdan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci bot commented Feb 5, 2024

@nalind: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit 84e4ad0 into openshift:master Feb 5, 2024
@nalind nalind deleted the imagebuilder-with-go-1.20 branch February 5, 2024 22:03
afaranha pushed a commit to afaranha/release that referenced this pull request Feb 6, 2024
…48288)

Run our unit tests with a not-archived-yet version of Go.  Version 1.22
is about to be released, but more importantly, one of our dependencies
is about to start using functions that were added to the standard
library in version 1.20.

Signed-off-by: Nalin Dahyabhai <nalin@redhat.com>
ritmun pushed a commit to ritmun/release that referenced this pull request Feb 8, 2024
…48288)

Run our unit tests with a not-archived-yet version of Go.  Version 1.22
is about to be released, but more importantly, one of our dependencies
is about to start using functions that were added to the standard
library in version 1.20.

Signed-off-by: Nalin Dahyabhai <nalin@redhat.com>
memodi pushed a commit to memodi/release that referenced this pull request Mar 14, 2024
…48288)

Run our unit tests with a not-archived-yet version of Go.  Version 1.22
is about to be released, but more importantly, one of our dependencies
is about to start using functions that were added to the standard
library in version 1.20.

Signed-off-by: Nalin Dahyabhai <nalin@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. rehearsals-ack Signifies that rehearsal jobs have been acknowledged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants