Skip to content

OCPNODE-3330: SigstoreImageVerification uses client-go to create test CRs#29896

Merged
openshift-merge-bot[bot] merged 1 commit intoopenshift:mainfrom
QiWang19:tests-use-client-go
Jun 11, 2025
Merged

OCPNODE-3330: SigstoreImageVerification uses client-go to create test CRs#29896
openshift-merge-bot[bot] merged 1 commit intoopenshift:mainfrom
QiWang19:tests-use-client-go

Conversation

@QiWang19
Copy link
Copy Markdown
Member

@QiWang19 QiWang19 commented Jun 5, 2025

Fix [OCPFeatureGate:SigstoreImageVerification] test failure: https://prow.ci.openshift.org/view/gs/test-platform-results/logs/periodic-ci-openshift-multiarch-master-nightly-4.20-ocp-e2e-aws-ovn-techpreview-serial-multi-a-a/1927305457819455488
waitForPoolComplete(oc *exutil.CLI) function returns false positive since the pool 'UPDATING' status has a delay after creating clusterimgapolicy through oc CLI. The testing pod launched without the imagepolicy rollout finished which led to the test failure.
This PR uses client-go instead to create the test objects.

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 5, 2025
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci bot commented Jun 5, 2025

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci bot commented Jun 5, 2025

@QiWang19: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-release-master-ci-4.20-e2e-aws-ovn-techpreview-serial

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/2a0f4f10-423d-11f0-8e56-ca3a27857f9d-0

@QiWang19 QiWang19 force-pushed the tests-use-client-go branch from c847032 to 4f7670f Compare June 6, 2025 01:10
@QiWang19
Copy link
Copy Markdown
Member Author

QiWang19 commented Jun 6, 2025

/payload-job periodic-ci-openshift-release-master-ci-4.20-e2e-aws-ovn-techpreview-serial

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci bot commented Jun 6, 2025

@QiWang19: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-release-master-ci-4.20-e2e-aws-ovn-techpreview-serial

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/21d58900-4273-11f0-87b3-88a970764595-0

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci bot commented Jun 6, 2025

@QiWang19: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-release-master-ci-4.20-e2e-aws-ovn-techpreview-serial

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/83cd23d0-431c-11f0-9542-3098891a0678-0

@QiWang19
Copy link
Copy Markdown
Member Author

QiWang19 commented Jun 6, 2025

/test all

@QiWang19
Copy link
Copy Markdown
Member Author

QiWang19 commented Jun 6, 2025

/payload-job

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci bot commented Jun 6, 2025

@QiWang19: it appears that you have attempted to use some version of the payload command, but your comment was incorrectly formatted and cannot be acted upon. See the docs for usage info.

@QiWang19 QiWang19 force-pushed the tests-use-client-go branch from 510d92a to e643ab2 Compare June 6, 2025 22:31
@QiWang19
Copy link
Copy Markdown
Member Author

QiWang19 commented Jun 6, 2025

/payload-job periodic-ci-openshift-release-master-ci-4.20-e2e-aws-ovn-techpreview-serial

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci bot commented Jun 6, 2025

@QiWang19: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-release-master-ci-4.20-e2e-aws-ovn-techpreview-serial

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/fb650d00-4325-11f0-9949-ff6e301a590a-0

@QiWang19
Copy link
Copy Markdown
Member Author

QiWang19 commented Jun 6, 2025

/test all

@openshift-trt
Copy link
Copy Markdown

openshift-trt bot commented Jun 7, 2025

Risk analysis has seen new tests most likely introduced by this PR.
Please ensure that new tests meet guidelines for naming and stability.

New tests seen in this PR at sha: e643ab2

  • "[sig-installer][Suite:openshift/openstack] The OpenShift cluster should allow the manual setting of enable_topology to false [Serial]" [Total: 2, Pass: 2, Fail: 0, Flake: 0]

@QiWang19 QiWang19 force-pushed the tests-use-client-go branch 2 times, most recently from 4534b0c to 5dfe9a1 Compare June 7, 2025 22:17
@QiWang19 QiWang19 changed the title wip: use client-go in the test SigstoreImageVerification uses client-go to create test CRs Jun 7, 2025
@QiWang19 QiWang19 changed the title SigstoreImageVerification uses client-go to create test CRs OCPNODE-3330: SigstoreImageVerification uses client-go to create test CRs Jun 7, 2025
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jun 7, 2025
@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Jun 7, 2025

@QiWang19: This pull request references OCPNODE-3330 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.20.0" version, but no target version was set.

Details

In response to this:

https://prow.ci.openshift.org/view/gs/test-platform-results/logs/periodic-ci-openshift-multiarch-master-nightly-4.20-ocp-e2e-aws-ovn-techpreview-serial-multi-a-a/1927305457819455488
waitForPoolComplete(oc *exutil.CLI) function returns false positive since the pool 'UPDATING' status has a delay after creating clusterimgapolicy through oc CLI. The testing pod launched without the imagepolicy rollout finished which led to the test failure.
This PR uses client-go instead to create the test objects.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@QiWang19 QiWang19 marked this pull request as ready for review June 7, 2025 22:21
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 7, 2025
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci bot commented Jun 7, 2025

@QiWang19: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-release-master-ci-4.20-e2e-aws-ovn-techpreview-serial

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/e47ffa0a-43ed-11f0-85d1-67521a3fb8e6-0

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci bot commented Jun 7, 2025

@QiWang19: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-release-master-ci-4.20-e2e-aws-ovn-techpreview-serial

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/f0380e28-43ed-11f0-9052-1520f62a32d6-0

@openshift-ci openshift-ci bot requested review from p0lyn0mial and sjenning June 7, 2025 22:23
@openshift-trt
Copy link
Copy Markdown

openshift-trt bot commented Jun 8, 2025

Job Failure Risk Analysis for sha: 5dfe9a1

Job Name Failure Risk
pull-ci-openshift-origin-main-e2e-azure-ovn-etcd-scaling Low
[bz-Cloud Compute] clusteroperator/control-plane-machine-set should not change condition/Degraded
This test has passed 0.00% of 1 runs on release 4.20 [Architecture:amd64 FeatureSet:default Installer:ipi JobTier:rare Network:ovn NetworkStack:ipv4 Owner:eng Platform:azure SecurityMode:default Topology:ha Upgrade:none] in the last week.
---
[bz-kube-storage-version-migrator] clusteroperator/kube-storage-version-migrator should not change condition/Available
This test has passed 0.00% of 1 runs on release 4.20 [Architecture:amd64 FeatureSet:default Installer:ipi JobTier:rare Network:ovn NetworkStack:ipv4 Owner:eng Platform:azure SecurityMode:default Topology:ha Upgrade:none] in the last week.

Open Bugs
[CI] e2e-openstack-ovn-etcd-scaling job permanent fails at many openshift-test tests
pull-ci-openshift-origin-main-e2e-gcp-disruptive High
[bz-Cloud Compute] clusteroperator/machine-api should not change condition/Degraded
This test has passed 99.96% of 4759 runs on release 4.20 [Overall] in the last week.
pull-ci-openshift-origin-main-e2e-gcp-ovn-etcd-scaling Low
[bz-kube-storage-version-migrator] clusteroperator/kube-storage-version-migrator should not change condition/Available
This test has passed 0.00% of 1 runs on release 4.20 [Architecture:amd64 FeatureSet:default Installer:ipi JobTier:rare Network:ovn NetworkStack:ipv4 Owner:eng Platform:gcp SecurityMode:default Topology:ha Upgrade:none] in the last week.

Open Bugs
[CI] e2e-openstack-ovn-etcd-scaling job permanent fails at many openshift-test tests
---
[bz-Cloud Compute] clusteroperator/control-plane-machine-set should not change condition/Degraded
This test has passed 0.00% of 1 runs on release 4.20 [Architecture:amd64 FeatureSet:default Installer:ipi JobTier:rare Network:ovn NetworkStack:ipv4 Owner:eng Platform:gcp SecurityMode:default Topology:ha Upgrade:none] in the last week.

@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Jun 9, 2025

@QiWang19: This pull request references OCPNODE-3330 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.20.0" version, but no target version was set.

Details

In response to this:

Fix [OCPFeatureGate:SigstoreImageVerification] test failure: https://prow.ci.openshift.org/view/gs/test-platform-results/logs/periodic-ci-openshift-multiarch-master-nightly-4.20-ocp-e2e-aws-ovn-techpreview-serial-multi-a-a/1927305457819455488
waitForPoolComplete(oc *exutil.CLI) function returns false positive since the pool 'UPDATING' status has a delay after creating clusterimgapolicy through oc CLI. The testing pod launched without the imagepolicy rollout finished which led to the test failure.
This PR uses client-go instead to create the test objects.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@neisw
Copy link
Copy Markdown
Contributor

neisw commented Jun 9, 2025

/approve

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 9, 2025
@QiWang19
Copy link
Copy Markdown
Member Author

QiWang19 commented Jun 9, 2025

/payload-job periodic-ci-openshift-release-master-ci-4.20-e2e-aws-ovn-techpreview-serial

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci bot commented Jun 9, 2025

@QiWang19: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-release-master-ci-4.20-e2e-aws-ovn-techpreview-serial

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/cb4efe10-454f-11f0-8f30-b211f597ad7b-0

@QiWang19 QiWang19 force-pushed the tests-use-client-go branch from 5dfe9a1 to 6f8e6a7 Compare June 9, 2025 16:41
@QiWang19
Copy link
Copy Markdown
Member Author

QiWang19 commented Jun 9, 2025

/payload-job periodic-ci-openshift-release-master-ci-4.20-e2e-aws-ovn-techpreview-serial

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci bot commented Jun 9, 2025

@QiWang19: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-release-master-ci-4.20-e2e-aws-ovn-techpreview-serial

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/9d02c4f0-4550-11f0-88a2-97ddd7d22c57-0

@QiWang19
Copy link
Copy Markdown
Member Author

QiWang19 commented Jun 9, 2025

/payload-job periodic-ci-openshift-release-master-ci-4.20-e2e-gcp-ovn-techpreview-serial

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci bot commented Jun 9, 2025

@QiWang19: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-release-master-ci-4.20-e2e-gcp-ovn-techpreview-serial

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/32004a40-4552-11f0-8ac4-817d0819eacf-0

@openshift-trt
Copy link
Copy Markdown

openshift-trt bot commented Jun 9, 2025

Job Failure Risk Analysis for sha: 6f8e6a7

Job Name Failure Risk
pull-ci-openshift-origin-main-e2e-aws-ovn-etcd-scaling High
[sig-architecture] platform pods in ns/openshift-etcd should not exit an excessive amount of times
This test has passed 100.00% of 2 runs on release 4.20 [Architecture:amd64 FeatureSet:default Installer:ipi JobTier:rare Network:ovn NetworkStack:ipv4 Owner:eng Platform:aws SecurityMode:default Topology:ha Upgrade:none] in the last week.
pull-ci-openshift-origin-main-e2e-azure-ovn-etcd-scaling Low
[bz-Cloud Compute] clusteroperator/control-plane-machine-set should not change condition/Degraded
This test has passed 0.00% of 1 runs on release 4.20 [Architecture:amd64 FeatureSet:default Installer:ipi JobTier:rare Network:ovn NetworkStack:ipv4 Owner:eng Platform:azure SecurityMode:default Topology:ha Upgrade:none] in the last week.
---
[bz-kube-storage-version-migrator] clusteroperator/kube-storage-version-migrator should not change condition/Available
This test has passed 0.00% of 1 runs on release 4.20 [Architecture:amd64 FeatureSet:default Installer:ipi JobTier:rare Network:ovn NetworkStack:ipv4 Owner:eng Platform:azure SecurityMode:default Topology:ha Upgrade:none] in the last week.

Open Bugs
[CI] e2e-openstack-ovn-etcd-scaling job permanent fails at many openshift-test tests

@QiWang19
Copy link
Copy Markdown
Member Author

/retest-required

fix https://prow.ci.openshift.org/view/gs/test-platform-results/logs/periodic-ci-openshift-multiarch-master-nightly-4.20-ocp-e2e-aws-ovn-techpreview-serial-multi-a-a/1927305457819455488
waitForPoolComplete(oc *exutil.CLI) function returns false positive since the pool 'UPDATING' status has a delay after creating clusterimgapolicy through oc CLI. The testing pod launched without the imagepolicy rollout finished which led to the test failure.
This PR uses client-go instead of oc to create the test objects.

Signed-off-by: Qi Wang <qiwan@redhat.com>
@QiWang19 QiWang19 force-pushed the tests-use-client-go branch from 6f8e6a7 to 992792f Compare June 10, 2025 18:03
@haircommander
Copy link
Copy Markdown
Member

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 10, 2025
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci bot commented Jun 10, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: haircommander, neisw, QiWang19

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot
Copy link
Copy Markdown

/retest-required

Remaining retests: 0 against base HEAD 4a5cc22 and 2 for PR HEAD 992792f in total

@openshift-ci-robot
Copy link
Copy Markdown

/retest-required

Remaining retests: 0 against base HEAD 757cf53 and 1 for PR HEAD 992792f in total

@openshift-ci-robot
Copy link
Copy Markdown

/retest-required

Remaining retests: 0 against base HEAD 757cf53 and 2 for PR HEAD 992792f in total

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci bot commented Jun 11, 2025

@QiWang19: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-gcp-ovn-etcd-scaling 992792f link false /test e2e-gcp-ovn-etcd-scaling
ci/prow/e2e-gcp-fips-serial-1of2 992792f link false /test e2e-gcp-fips-serial-1of2
ci/prow/e2e-gcp-disruptive 992792f link false /test e2e-gcp-disruptive
ci/prow/e2e-gcp-fips-serial-2of2 992792f link false /test e2e-gcp-fips-serial-2of2
ci/prow/e2e-aws-ovn-etcd-scaling 992792f link false /test e2e-aws-ovn-etcd-scaling
ci/prow/e2e-azure-ovn-upgrade 992792f link false /test e2e-azure-ovn-upgrade
ci/prow/e2e-aws-ovn-serial-publicnet-1of2 992792f link false /test e2e-aws-ovn-serial-publicnet-1of2
ci/prow/e2e-aws-csi 992792f link false /test e2e-aws-csi
ci/prow/e2e-vsphere-ovn-dualstack-primaryv6 992792f link false /test e2e-vsphere-ovn-dualstack-primaryv6
ci/prow/e2e-metal-ipi-ovn 992792f link false /test e2e-metal-ipi-ovn
ci/prow/e2e-metal-ipi-ovn-kube-apiserver-rollout 992792f link false /test e2e-metal-ipi-ovn-kube-apiserver-rollout
ci/prow/e2e-openstack-ovn 992792f link false /test e2e-openstack-ovn
ci/prow/e2e-metal-ipi-ovn-dualstack 992792f link false /test e2e-metal-ipi-ovn-dualstack
ci/prow/e2e-metal-ipi-virtualmedia 992792f link false /test e2e-metal-ipi-virtualmedia
ci/prow/e2e-aws-ovn-single-node-upgrade 992792f link false /test e2e-aws-ovn-single-node-upgrade
ci/prow/e2e-azure-ovn-etcd-scaling 992792f link false /test e2e-azure-ovn-etcd-scaling
ci/prow/e2e-metal-ipi-ovn-dualstack-local-gateway 992792f link false /test e2e-metal-ipi-ovn-dualstack-local-gateway
ci/prow/e2e-vsphere-ovn-etcd-scaling 992792f link false /test e2e-vsphere-ovn-etcd-scaling
ci/prow/e2e-aws-disruptive 992792f link false /test e2e-aws-disruptive
ci/prow/okd-e2e-gcp 992792f link false /test okd-e2e-gcp
ci/prow/e2e-openstack-serial 992792f link false /test e2e-openstack-serial
ci/prow/4.12-upgrade-from-stable-4.11-e2e-aws-ovn-upgrade-rollback 992792f link false /test 4.12-upgrade-from-stable-4.11-e2e-aws-ovn-upgrade-rollback

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit 31c8b6d into openshift:main Jun 11, 2025
37 of 59 checks passed
@openshift-bot
Copy link
Copy Markdown
Contributor

[ART PR BUILD NOTIFIER]

Distgit: openshift-enterprise-tests
This PR has been included in build openshift-enterprise-tests-container-v4.20.0-202506110913.p0.g31c8b6d.assembly.stream.el9.
All builds following this will include this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants