Skip to content

Bug 1766287: Add CI Dockerfile for hello-openshift#25435

Merged
openshift-merge-robot merged 1 commit into
openshift:masterfrom
yselkowitz:hello-openshift
Sep 12, 2020
Merged

Bug 1766287: Add CI Dockerfile for hello-openshift#25435
openshift-merge-robot merged 1 commit into
openshift:masterfrom
yselkowitz:hello-openshift

Conversation

@yselkowitz

@yselkowitz yselkowitz commented Aug 21, 2020 •
edited by sdodson
Loading

Copy link
Copy Markdown
Contributor

hello-openshift is (in)famously used throughout openshift as both an example and test image, but it's never been built or shipped by ART and it isn't multi-arch. This is the first step to bring it into the release.

@yselkowitz

yselkowitz commented Aug 21, 2020

Copy link
Copy Markdown
Contributor Author

How could adding a new Dockerfile possibly cause a regression?
/retest

@wking

wking commented Aug 21, 2020

Copy link
Copy Markdown
Member

verify:

 --- ./test/extended/testdata/bindata.go	2020-08-21 19:10:13.000000000 +0000
+++ /tmp/tmp.h6FJD8Qbcq/test/extended/testdata/bindata.go	2020-08-21 19:18:29.347273095 +0000
@@ -32,6 +32,7 @@
 // examples/quickstarts/rails-postgresql-persistent.json
 // examples/quickstarts/rails-postgresql.json
 // examples/hello-openshift/Dockerfile
+// examples/hello-openshift/Dockerfile.rhel
...

@yselkowitz

yselkowitz commented Aug 21, 2020

Copy link
Copy Markdown
Contributor Author

There's no reason for this Dockerfile.rhel in testdata, it won't be used there. Any way to circumvent that?

@yselkowitz yselkowitz changed the title hello-openshift: add Dockerfile.rhel Bug 1766287: Add CI Dockerfile for hello-openshift Sep 10, 2020
@openshift-ci-robot openshift-ci-robot added the bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. label Sep 10, 2020
@openshift-ci-robot

openshift-ci-robot commented Sep 10, 2020

Copy link
Copy Markdown

@yselkowitz: This pull request references Bugzilla bug 1766287, which is valid. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.6.0) matches configured target release for branch (4.6.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
Details

In response to this:

Bug 1766287: Add CI Dockerfile for hello-openshift

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Sep 10, 2020
@yselkowitz

yselkowitz commented Sep 10, 2020

Copy link
Copy Markdown
Contributor Author

/retest

@sgreene570

sgreene570 commented Sep 11, 2020

Copy link
Copy Markdown
Contributor 
could not wait for build: the build src failed after 8s with reason PullBuilderImageFailed: Failed pulling builder image.

Pulling image docker-registry.default.svc:5000/ci-op-541dk...16d4fdaa913159315cf7d381e153339da2043ff241b4baff4f50f74 ...
error: build error: failed to pull image: unauthorized: authentication required

/retest

@yselkowitz

yselkowitz commented Sep 11, 2020

Copy link
Copy Markdown
Contributor Author

/retest

@yselkowitz

yselkowitz commented Sep 11, 2020

Copy link
Copy Markdown
Contributor Author

/assign @sdodson

@sdodson

sdodson commented Sep 11, 2020

Copy link
Copy Markdown
Member

Can you please fill out the description of this PR? What uses this? What purpose does this new image serve?

@yselkowitz

yselkowitz commented Sep 11, 2020

Copy link
Copy Markdown
Contributor Author

hello-openshift is (in)famously used throughout openshift as both an example and test image, but it's never been built or shipped by ART and it isn't multi-arch. This is the first step to bring it into the release.

@sdodson

sdodson commented Sep 11, 2020

Copy link
Copy Markdown
Member

/lgtm

@openshift-ci-robot openshift-ci-robot added lgtm Indicates that a PR is ready to be merged. and removed bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Sep 11, 2020
@openshift-ci-robot

openshift-ci-robot commented Sep 11, 2020

Copy link
Copy Markdown

@yselkowitz: This pull request references Bugzilla bug 1766287, which is invalid:

  • expected the bug to target the "4.6.0" release, but it targets "4.7.0" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

Bug 1766287: Add CI Dockerfile for hello-openshift

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Sep 11, 2020
@sdodson

sdodson commented Sep 11, 2020

Copy link
Copy Markdown
Member

/bugzilla refresh

@openshift-ci-robot openshift-ci-robot added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Sep 11, 2020
@openshift-ci-robot

openshift-ci-robot commented Sep 11, 2020

Copy link
Copy Markdown

@sdodson: This pull request references Bugzilla bug 1766287, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.6.0) matches configured target release for branch (4.6.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
Details

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sdodson

sdodson commented Sep 11, 2020

Copy link
Copy Markdown
Member

/approve

@openshift-ci-robot

openshift-ci-robot commented Sep 11, 2020

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sdodson, yselkowitz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 11, 2020
@spadgett spadgett mentioned this pull request Sep 11, 2020
Closed
@sdodson

sdodson commented Sep 11, 2020

Copy link
Copy Markdown
Member

/refresh

@openshift-bot

openshift-bot commented Sep 11, 2020

Copy link
Copy Markdown
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

2 similar comments
@openshift-bot

openshift-bot commented Sep 12, 2020

Copy link
Copy Markdown
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot

openshift-bot commented Sep 12, 2020

Copy link
Copy Markdown
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 5022f83 into openshift:master Sep 12, 2020
@openshift-ci-robot

openshift-ci-robot commented Sep 12, 2020

Copy link
Copy Markdown

@yselkowitz: All pull requests linked via external trackers have merged:

Bugzilla bug 1766287 has been moved to the MODIFIED state.

Details

In response to this:

Bug 1766287: Add CI Dockerfile for hello-openshift

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot mentioned this pull request Nov 25, 2020
Merged
@openshift-ci-robot openshift-ci-robot mentioned this pull request Jan 6, 2021
Merged
@openshift-ci-robot openshift-ci-robot mentioned this pull request Mar 26, 2021
Merged
@yselkowitz yselkowitz deleted the hello-openshift branch October 5, 2021 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jwforres jwforres Awaiting requested review from jwforres

@knobunc knobunc Awaiting requested review from knobunc

Assignees

@sdodson sdodson

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@yselkowitz @wking @openshift-ci-robot @sgreene570 @sdodson @openshift-bot @openshift-merge-robot