Skip to content

Pick 17616: Add --selector, --pod-selector flags oc adm drain#17868

Merged
openshift-merge-robot merged 2 commits intoopenshift:release-3.8from
juanvallejo:jvallejo/pick-17616-pod-selector
Jan 8, 2018
Merged

Pick 17616: Add --selector, --pod-selector flags oc adm drain#17868
openshift-merge-robot merged 2 commits intoopenshift:release-3.8from
juanvallejo:jvallejo/pick-17616-pod-selector

Conversation

@juanvallejo
Copy link
Copy Markdown
Contributor

@juanvallejo juanvallejo commented Dec 18, 2017

@openshift-ci-robot openshift-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Dec 18, 2017
@openshift-merge-robot openshift-merge-robot added the vendor-update Touching vendor dir or related files label Dec 18, 2017
@juanvallejo juanvallejo mentioned this pull request Dec 18, 2017
Merged
@juanvallejo
Copy link
Copy Markdown
Contributor Author

juanvallejo commented Dec 18, 2017

/test end_to_end

@deads2k
Copy link
Copy Markdown
Contributor

deads2k commented Dec 19, 2017

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Dec 19, 2017
@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Dec 19, 2017

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deads2k, juanvallejo

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 19, 2017
@juanvallejo
Copy link
Copy Markdown
Contributor Author

juanvallejo commented Dec 19, 2017

/test end_to_end

1 similar comment
@juanvallejo
Copy link
Copy Markdown
Contributor Author

juanvallejo commented Dec 19, 2017

/test end_to_end

@soltysh
Copy link
Copy Markdown
Contributor

soltysh commented Dec 20, 2017

/retest

@juanvallejo
Copy link
Copy Markdown
Contributor Author

juanvallejo commented Dec 20, 2017 •
edited
Loading

@stevekuznetsov
I keep seeing this failure in end-to-end

router_test.go:1416: Error validating master addr 172.18.4.186:8080 : Get https://172.18.4.186:8443: dial tcp 172.18.4.186:8443: getsockopt: connection refused
router_test.go:1721: Unable to start http server: listen tcp 172.18.4.186:8080: bind: address already in use

EDIT: Also seeing this happen in another pick to 3.8: #17869

@soltysh
Copy link
Copy Markdown
Contributor

soltysh commented Dec 21, 2017

/retest

@juanvallejo
Copy link
Copy Markdown
Contributor Author

juanvallejo commented Dec 21, 2017

/test end_to_end

@soltysh
Copy link
Copy Markdown
Contributor

soltysh commented Dec 22, 2017

/retest

@soltysh soltysh mentioned this pull request Dec 22, 2017
Closed
@soltysh
Copy link
Copy Markdown
Contributor

soltysh commented Dec 22, 2017

/retest

2 similar comments
@soltysh
Copy link
Copy Markdown
Contributor

soltysh commented Dec 22, 2017

/retest

@soltysh
Copy link
Copy Markdown
Contributor

soltysh commented Dec 22, 2017

/retest

@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Dec 23, 2017

/retest

Please review the full test history for this PR and help us cut down flakes.

5 similar comments
@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Dec 25, 2017

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Dec 26, 2017

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Dec 27, 2017

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Dec 28, 2017

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Dec 30, 2017

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Dec 31, 2017

/retest

Please review the full test history for this PR and help us cut down flakes.

3 similar comments
@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Jan 1, 2018

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Jan 1, 2018

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Jan 2, 2018

/retest

Please review the full test history for this PR and help us cut down flakes.

@soltysh
Copy link
Copy Markdown
Contributor

soltysh commented Jan 3, 2018

/retest

@soltysh
Copy link
Copy Markdown
Contributor

soltysh commented Jan 3, 2018

This needs #17966

@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Jan 4, 2018

/retest

Please review the full test history for this PR and help us cut down flakes.

@mfojtik
Copy link
Copy Markdown
Contributor

mfojtik commented Jan 4, 2018

/retest

1 similar comment
@soltysh
Copy link
Copy Markdown
Contributor

soltysh commented Jan 4, 2018

/retest

@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Jan 5, 2018

/retest

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Jan 7, 2018

/retest

Please review the full test history for this PR and help us cut down flakes.

@juanvallejo
Copy link
Copy Markdown
Contributor Author

juanvallejo commented Jan 8, 2018

/retest

@openshift-merge-robot
Copy link
Copy Markdown
Contributor

openshift-merge-robot commented Jan 8, 2018

/test all [submit-queue is verifying that this PR is safe to merge]

@openshift-merge-robot
Copy link
Copy Markdown
Contributor

openshift-merge-robot commented Jan 8, 2018

Automatic merge from submit-queue.

@openshift-merge-robot openshift-merge-robot merged commit 91f500a into openshift:release-3.8 Jan 8, 2018
@juanvallejo juanvallejo deleted the jvallejo/pick-17616-pod-selector branch January 8, 2018 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fabianofranz fabianofranz Awaiting requested review from fabianofranz

@smarterclayton smarterclayton Awaiting requested review from smarterclayton

Assignees

@deads2k deads2k

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. vendor-update Touching vendor dir or related files

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@juanvallejo @deads2k @openshift-ci-robot @soltysh @openshift-bot @mfojtik @openshift-merge-robot