Skip to content

Pick 17536: prevent references from origin to oc#17869

Merged
openshift-merge-robot merged 1 commit intoopenshift:release-3.8from
juanvallejo:jvallejo/pick-pr-17536-2nd-attempt
Jan 6, 2018
Merged

Pick 17536: prevent references from origin to oc#17869
openshift-merge-robot merged 1 commit intoopenshift:release-3.8from
juanvallejo:jvallejo/pick-pr-17536-2nd-attempt

Conversation

@juanvallejo
Copy link
Copy Markdown
Contributor

@juanvallejo juanvallejo commented Dec 18, 2017

Picks PR #17536 which brings in the last patch needed to eliminate dependencies from origin on the pkg/oc subtree.

Re-opened from #17566

cc @deads2k

@juanvallejo juanvallejo added approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. labels Dec 18, 2017
@openshift-ci-robot openshift-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Dec 18, 2017
@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Dec 18, 2017

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: juanvallejo

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@juanvallejo
Copy link
Copy Markdown
Contributor Author

juanvallejo commented Dec 18, 2017

/test end_to_end

@juanvallejo
Copy link
Copy Markdown
Contributor Author

juanvallejo commented Dec 19, 2017

/retest

3 similar comments
@juanvallejo
Copy link
Copy Markdown
Contributor Author

juanvallejo commented Dec 19, 2017

/retest

@juanvallejo
Copy link
Copy Markdown
Contributor Author

juanvallejo commented Dec 19, 2017

/retest

@juanvallejo
Copy link
Copy Markdown
Contributor Author

juanvallejo commented Dec 19, 2017

/retest

@juanvallejo juanvallejo mentioned this pull request Dec 20, 2017
Merged
@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Dec 20, 2017

/retest

Please review the full test history for this PR and help us cut down flakes.

11 similar comments
@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Dec 21, 2017

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Dec 23, 2017

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Dec 24, 2017

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Dec 25, 2017

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Dec 26, 2017

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Dec 27, 2017

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Dec 28, 2017

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Dec 30, 2017

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Dec 31, 2017

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Jan 1, 2018

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Jan 2, 2018

/retest

Please review the full test history for this PR and help us cut down flakes.

@0xmichalis
Copy link
Copy Markdown
Contributor

0xmichalis commented Jan 2, 2018

/retest

mfojtik
mfojtik reviewed Jan 2, 2018
View reviewed changes
pkg/cmd/openshift/openshift.go
return NewCmdCompletion(fullName, os.Stdout)
}

// newCmdOptions implements the OpenShift cli options command
Copy link
Copy Markdown
Contributor

@mfojtik mfojtik Jan 2, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: CLI options

@mfojtik
Copy link
Copy Markdown
Contributor

mfojtik commented Jan 2, 2018

/retest

@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Jan 3, 2018

/retest

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Jan 4, 2018

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Jan 5, 2018

/retest

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Jan 6, 2018

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot
Copy link
Copy Markdown
Contributor

openshift-merge-robot commented Jan 6, 2018

Automatic merge from submit-queue.

@openshift-merge-robot openshift-merge-robot merged commit 8a52daa into openshift:release-3.8 Jan 6, 2018
@juanvallejo juanvallejo deleted the jvallejo/pick-pr-17536-2nd-attempt branch January 8, 2018 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@csrwng csrwng Awaiting requested review from csrwng

@smarterclayton smarterclayton Awaiting requested review from smarterclayton

1 more reviewer

@mfojtik mfojtik mfojtik left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@juanvallejo @openshift-ci-robot @openshift-bot @0xmichalis @mfojtik @openshift-merge-robot