Skip to content

UPSTREAM: 57211: Process cluster-scoped owners correctly#17819

Merged
openshift-merge-robot merged 1 commit intoopenshift:release-3.8from
liggitt:cluster-scoped-owners-3.8
Jan 6, 2018
Merged

UPSTREAM: 57211: Process cluster-scoped owners correctly#17819
openshift-merge-robot merged 1 commit intoopenshift:release-3.8from
liggitt:cluster-scoped-owners-3.8

Conversation

@liggitt
Copy link
Copy Markdown
Contributor

@liggitt liggitt commented Dec 15, 2017

No description provided.

@openshift-ci-robot openshift-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Dec 15, 2017
@openshift-merge-robot openshift-merge-robot added the vendor-update Touching vendor dir or related files label Dec 15, 2017
@liggitt liggitt added this to the 3.8.0 milestone Dec 15, 2017
@liggitt
Copy link
Copy Markdown
Contributor Author

liggitt commented Jan 3, 2018

/retest

@enj
Copy link
Copy Markdown
Contributor

enj commented Jan 3, 2018

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 3, 2018
@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Jan 3, 2018

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: enj, liggitt

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@enj enj changed the title UPSTREAM: 57214: Process cluster-scoped owners correctly UPSTREAM: 57211: Process cluster-scoped owners correctly Jan 3, 2018
@liggitt
Copy link
Copy Markdown
Contributor Author

liggitt commented Jan 3, 2018 •
edited
Loading

@stevekuznetsov this ring a bell?

https://storage.googleapis.com/origin-ci-test/pr-logs/pull/17819/test_pull_request_origin_cmd/8032/build-log.txt

Running hack/test-util.sh:41: executing 'exit 1' expecting success...
FAILURE after 0.006s: hack/test-util.sh:41: executing 'exit 1' expecting success: the command returned the wrong error code
There was no output from the command.
There was no error output from the command.

edit: nevermind, misread output... those were successful failures... looks like this was the error:

Running hack/test-cmd.sh:107: executing 'oc login --server='https://172.17.0.2:28443' --certificate-authority='/tmp/openshift/init/openshift.local.config/master/ca.crt' -u test-user -p anything' expecting success...
FAILURE after 0.233s: hack/test-cmd.sh:107: executing 'oc login --server='https://172.17.0.2:28443' --certificate-authority='/tmp/openshift/init/openshift.local.config/master/ca.crt' -u test-user -p anything' expecting success: the command returned the wrong error code
There was no output from the command.
Standard error from the command:
error: Missing configuration - verify you have provided the correct host and port and that the server is currently running.
error: Missing configuration
[ERROR] PID 20612: hack/lib/cmd.sh:241: `return "${return_code}"` exited with status 1.

@liggitt
Copy link
Copy Markdown
Contributor Author

liggitt commented Jan 3, 2018

@enj looks like the "Missing configuration" error comes from osincli... anything change there recently?

@liggitt
Copy link
Copy Markdown
Contributor Author

liggitt commented Jan 3, 2018 •
edited
Loading

ah, looks like the real error is masked... error is unmasked in #17606

picked test fix to wait until server is healthy before proceeding
#17975

@liggitt liggitt mentioned this pull request Jan 3, 2018
Merged
@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Jan 4, 2018

/retest

Please review the full test history for this PR and help us cut down flakes.

@liggitt
Copy link
Copy Markdown
Contributor Author

liggitt commented Jan 4, 2018

/retest

3 similar comments
@liggitt
Copy link
Copy Markdown
Contributor Author

liggitt commented Jan 5, 2018

/retest

@liggitt
Copy link
Copy Markdown
Contributor Author

liggitt commented Jan 5, 2018

/retest

@liggitt
Copy link
Copy Markdown
Contributor Author

liggitt commented Jan 6, 2018

/retest

@openshift-merge-robot
Copy link
Copy Markdown
Contributor

openshift-merge-robot commented Jan 6, 2018

Automatic merge from submit-queue.

@openshift-merge-robot openshift-merge-robot merged commit 63be508 into openshift:release-3.8 Jan 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@deads2k deads2k Awaiting requested review from deads2k

@enj enj Awaiting requested review from enj

Assignees

@enj enj

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. vendor-update Touching vendor dir or related files

Projects

None yet

Milestone

v3.8

Development

Successfully merging this pull request may close these issues.

5 participants

@liggitt @enj @openshift-ci-robot @openshift-bot @openshift-merge-robot