Skip to content

Install openshift-diagnostics binary in dind and vagrant environments#17816

Merged
openshift-merge-robot merged 1 commit intoopenshift:masterfrom
pravisankar:dind-fix-install-cmds
Dec 27, 2017
Merged

Install openshift-diagnostics binary in dind and vagrant environments#17816
openshift-merge-robot merged 1 commit intoopenshift:masterfrom
pravisankar:dind-fix-install-cmds

Conversation

@pravisankar
Copy link
Copy Markdown

@pravisankar pravisankar commented Dec 14, 2017

Install openshift-diagnostics binary in dind and vagrant environments
928111c 
- openshift#17482 removed 'openshift infra'
command and diagnostic-pod/network-diagnostic-pod subcommands now are
moved under openshift-diagnostics command.
@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Dec 14, 2017
@pravisankar pravisankar added component/diagnostics and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Dec 14, 2017
@pravisankar
Copy link
Copy Markdown
Author

pravisankar commented Dec 14, 2017

@openshift/networking @sosiouxme PTAL

@sosiouxme
Copy link
Copy Markdown
Member

sosiouxme commented Dec 15, 2017

/lgtm
mmmm, flaky flaky tests...
/retest
Any idea how to get this into the origin image too?

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Dec 15, 2017
@dcbw
Copy link
Copy Markdown
Contributor

dcbw commented Dec 15, 2017

/test cross

@dcbw
Copy link
Copy Markdown
Contributor

dcbw commented Dec 15, 2017

/test extended_conformance_install

@dcbw
Copy link
Copy Markdown
Contributor

dcbw commented Dec 15, 2017

/lgtm

@eparis
Copy link
Copy Markdown
Member

eparis commented Dec 15, 2017

/lgtm

@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Dec 15, 2017

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dcbw, eparis, pravisankar, sosiouxme

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 15, 2017
@imcsk8
Copy link
Copy Markdown
Contributor

imcsk8 commented Dec 15, 2017

LGTM

@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Dec 16, 2017

/retest

Please review the full test history for this PR and help us cut down flakes.

10 similar comments
@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Dec 17, 2017

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Dec 18, 2017

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Dec 19, 2017

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Dec 20, 2017

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Dec 21, 2017

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Dec 23, 2017

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Dec 24, 2017

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Dec 25, 2017

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Dec 26, 2017

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Dec 27, 2017

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Dec 27, 2017 •
edited
Loading

@pravisankar: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
ci/openshift-jenkins/cross 928111c link /test cross

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot
Copy link
Copy Markdown
Contributor

openshift-merge-robot commented Dec 27, 2017

Automatic merge from submit-queue.

@openshift-merge-robot openshift-merge-robot merged commit a1fa9d1 into openshift:master Dec 27, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dcbw dcbw Awaiting requested review from dcbw

@liggitt liggitt Awaiting requested review from liggitt

Assignees

@sosiouxme sosiouxme

@eparis eparis

@dcbw dcbw

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. component/diagnostics lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@pravisankar @sosiouxme @dcbw @eparis @openshift-ci-robot @imcsk8 @openshift-bot @openshift-merge-robot