move "openshift ex" -> "oc ex"#17486
Merged
openshift-merge-robot merged 3 commits intoopenshift:masterfrom Nov 30, 2017
Merged
Conversation
This was referenced Nov 27, 2017
Contributor
|
You need a release note on this. /lgtm |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: deads2k, juanvallejo The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing |
8d455de to
28fea0d
Compare
8e8cb26 to
b3cf70d
Compare
b3cf70d to
8b71c30
Compare
8b71c30 to
508b618
Compare
juanvallejo
commented
Nov 28, 2017
hack/lib/start.sh
Outdated
| local sudo=${USE_SUDO:+sudo} | ||
| cp "${SERVER_CONFIG_DIR}/master/master-config.yaml" "${SERVER_CONFIG_DIR}/master/master-config.orig.yaml" | ||
| oc ex config patch "${SERVER_CONFIG_DIR}/master/master-config.orig.yaml" --patch="{\"etcdConfig\": {\"address\": \"${API_HOST}:${ETCD_PORT}\"}}" | \ | ||
| oc ex config patch - --patch="{\"pluginConfig\": {\"openshift.io/ImagePolicy\": {\"configuration\": {\"apiVersion\": \"v1\", \"executionRules\": [{\"matchImageAnnotations\": [{\"key\": \"images.openshift.io/deny-execution\", \"value\": \"true\"}], \"name\": \"execution-denied\", \"onResources\": [{\"resource\": \"pods\"}, {\"resource\": \"builds\"}], \"reject\": \"true\", \"skipOnResolutionFailure\": \"true\" }], \"kind\": \"ImagePolicyConfig\" }, \"location\": \"\"}}}" | \ |
Contributor
Author
Contributor
Contributor
Author
There was a problem hiding this comment.
You can save this commit for that pull. You want to pick up that pull?
Sure, will start working on the pull now
openshift-merge-robot
added a commit
that referenced
this pull request
Nov 29, 2017
…g-oc Automatic merge from submit-queue. move pkg/cmd/util/clientcmd -> pkg/oc/cli/util/clientcmd This patch *partially* solves a few of the items (currently checked) from #17309 Now that `clientcmd` (which includes printer factory methods) is moved into `pkg/oc`, the following files outside of `pkg/oc` need to have their dependency on `clientcmd` broken (this will be done in a separate PR): - [x] pkg/cmd/server/origin/controller/config.go (#17357) - [x] pkg/cmd/server/admin/create_error_template.go (#17357) - [x] pkg/cmd/server/admin/create_bootstrap_project_template.go (#17357) - [x] pkg/cmd/server/admin/overwrite_bootstrappolicy.go (*this file has been removed by* #17336) - [x] pkg/cmd/server/admin/create_login_template.go (#17357) - [x] pkg/cmd/server/admin/create_provider_selection_template.go (#17357) - [x] **pkg/cmd/infra/router/template.go** (Wanted by: `pkg/cmd/openshift/openshift.go` (no other dependents)) (#17357) - [x] **pkg/cmd/infra/router/f5.go** (Wanted by: `pkg/cmd/openshift/openshift.go` (no other dependents)) (#17357) - [x] pkg/cmd/openshift/openshift.go (#17486 and #17482) - [x] pkg/cmd/dockerregistry/dockerregistry.go (Wanted by: `cmd/dockerregistry/main.go` (depends on `clientcmd.Config`)) (#17357) - [x] *pkg/diagnostics/networkpod/util/util.go* (Can be addressed by moving `pkg/diagnostics` inside existing `pkg/oc/admin/diagnostics`) #17393 - [x] *pkg/diagnostics/client/config_contexts.go* (Can be addressed by moving `pkg/diagnostics` inside existing `pkg/oc/admin/diagnostics`) #17393 - [x] *pkg/diagnostics/client/run_diagnostics_pod.go* (Can be addressed by moving `pkg/diagnostics` inside existing `pkg/oc/admin/diagnostics`) #17393 - [x] *pkg/diagnostics/pod/auth.go* (Can be addressed by moving `pkg/diagnostics` inside existing `pkg/oc/admin/diagnostics`) #17393 - [x] *pkg/diagnostics/network/run_pod.go* (Can be addressed by moving `pkg/diagnostics` inside existing `pkg/oc/admin/diagnostics`) #17393 - [x] pkg/ipfailover/keepalived/plugin.go (moved to `pkg/oc/experimental`) (#17357) - [x] pkg/federation/kubefed/kubefed.go (#17357) - [x] pkg/dockerregistry/server/client/client.go (#17357) - [x] pkg/dockerregistry/server/auth_test.go (#17357) **bold** = depends on `clientcmd.Config` (not sure what to do about this) AND only dependent is `pkg/cmd/openshift/openshift.go` cc @deads2k @openshift/cli-review @liggitt
Contributor
|
/lgtm |
c4f50d5 to
508b618
Compare
This was referenced Nov 29, 2017
508b618 to
3310e78
Compare
Contributor
Author
|
/retest |
Contributor
Author
|
/test extended_conformance_install |
3310e78 to
7c3a54e
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: deads2k, juanvallejo, openshift-merge-robot The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing |
Contributor
|
/retest Please review the full test history for this PR and help us cut down flakes. |
Contributor
|
/retest |
Contributor
Author
|
/test extended_conformance_install_update |
|
@juanvallejo: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Contributor
|
Automatic merge from submit-queue. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moves the experimental command group to
ocin order to break deps onpkg/ocin packages outside of that subtree. Part of #17309 and #17356Release-Note:
Experimental commands moved from the "openshift" parent to the "oc" parentcc @deads2k @liggitt