stop adding beta admission config to default master configs#17473
stop adding beta admission config to default master configs#17473deads2k wants to merge 1 commit intoopenshift:masterfrom
Conversation
| config.ServiceAccountConfig.PublicKeyFiles = []string{} | ||
| } | ||
|
|
||
| // embed a default policy for generated config |
There was a problem hiding this comment.
no objections from me. @smarterclayton, are we expecting this admission plugin to be enabled by default, and if so, does the default config for this plugin do what we want?
There was a problem hiding this comment.
no objections from me. @smarterclayton, are we expecting this admission plugin to be enabled by default, and if so, does the default config for this plugin do what we want?
It does not. No config means nothing. This changes what an empty openshift start master does, but no one should be using that in production and production builds its config differently anyway.
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: deads2k, liggitt The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing |
|
@liggitt integration I'll fix, test-cmd I'll remove. comments? |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
3 similar comments
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
@deads2k the cmd error seems real.. did this broke the image resolution? |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
1 similar comment
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
1 similar comment
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
@deads2k: The following tests failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
Closing in favor of #17516 per the discussion with David in #17486 (comment) |
Stop adding the image admission config. I confirmed with @sdodson last week that he doesn't use the config this creates.
@liggitt as discussed last week.
@juanvallejo this snips the pkg/oc link you asked about before.