Skip to content

fix the manifests generation#533

Merged
openshift-merge-robot merged 2 commits into
openshift:masterfrom
stevekuznetsov:skuznets/fix-verify
Aug 7, 2023
Merged

fix the manifests generation#533
openshift-merge-robot merged 2 commits into
openshift:masterfrom
stevekuznetsov:skuznets/fix-verify

Conversation

@stevekuznetsov

@stevekuznetsov stevekuznetsov commented Aug 7, 2023

Copy link
Copy Markdown
Contributor

manifests: use the CVO-replaced placeholder for version

Signed-off-by: Steve Kuznetsov skuznets@redhat.com

makefile: verify that we use the CVO-based placeholder

Signed-off-by: Steve Kuznetsov skuznets@redhat.com

@stevekuznetsov
manifests: use the CVO-replaced placeholder for version
7fedf7f 
Signed-off-by: Steve Kuznetsov <skuznets@redhat.com>
@stevekuznetsov
makefile: verify that we use the CVO-based placeholder
1e0092b 
Signed-off-by: Steve Kuznetsov <skuznets@redhat.com>
@openshift-ci openshift-ci Bot requested review from awgreene and oceanc80 August 7, 2023 12:44
awgreene
awgreene approved these changes Aug 7, 2023
View reviewed changes

@awgreene awgreene left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@openshift-ci openshift-ci Bot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Aug 7, 2023
@stevekuznetsov stevekuznetsov mentioned this pull request Aug 7, 2023
Merged
@tmshort

tmshort commented Aug 7, 2023

Copy link
Copy Markdown
Contributor

Is there an issue that this is a regression in version numbering? Does it matter?
Otherwise, looks fine.

tmshort
tmshort approved these changes Aug 7, 2023
View reviewed changes

@tmshort tmshort left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
So, it shouldn't be considered a regression

@openshift-ci

openshift-ci Bot commented Aug 7, 2023

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: awgreene, stevekuznetsov, tmshort

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@stevekuznetsov

stevekuznetsov commented Aug 7, 2023

Copy link
Copy Markdown
Contributor Author

/retest

@openshift-ci

openshift-ci Bot commented Aug 7, 2023

Copy link
Copy Markdown
Contributor

@stevekuznetsov: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit 3e56c4b into openshift:master Aug 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@oceanc80 oceanc80 Awaiting requested review from oceanc80

2 more reviewers

@awgreene awgreene awgreene approved these changes

@tmshort tmshort tmshort approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@awgreene awgreene

@tmshort tmshort

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@stevekuznetsov @tmshort @awgreene @openshift-merge-robot