Skip to content

OPRUN-2913: Sync from api repo 1#475

Closed
tmshort wants to merge 2 commits into
openshift:masterfrom
tmshort:sync-api-1
Closed

OPRUN-2913: Sync from api repo 1#475
tmshort wants to merge 2 commits into
openshift:masterfrom
tmshort:sync-api-1

Conversation

@tmshort

@tmshort tmshort commented Mar 16, 2023

Copy link
Copy Markdown
Contributor

This syncs two commits from the upstream api repo. Additional PRs will be opened for the rest of the api, operator-lifecycle-manager and operator-registry upstream repos.

bcrochet and others added 2 commits March 16, 2023 16:10
@bcrochet @tmshort
Fix a panic when reading annotations if the bundle is not there (open…
5af9977 
…shift#255)

If the bundle is not present, the current bundleLoader will panic
when it gets to addChannelsFromAnnotationsFile. If the bundle is
nil, addChannelsFromAnnotationsFile should not attempt to do anything
so instead it just returns now.

Signed-off-by: Brad P. Crochet <brad@redhat.com>

Signed-off-by: Brad P. Crochet <brad@redhat.com>
Upstream-repository: api
Upstream-commit: 5f99430d4ec47d59daafa3b818229f0466531dea
@grokspawn @tmshort
introduce spec.runAsRoot field (openshift#258)
619e491 
Signed-off-by: Jordan <jordan@nimblewidget.com>

Signed-off-by: Jordan <jordan@nimblewidget.com>
Upstream-repository: api
Upstream-commit: 7339a22050af53df7b6f97a652b8e2d73698765a
@tmshort

tmshort commented Mar 17, 2023

Copy link
Copy Markdown
Contributor Author

/retest e2e-upgrade

@openshift-ci

openshift-ci Bot commented Mar 17, 2023

Copy link
Copy Markdown
Contributor

@tmshort: The /retest command does not accept any targets.
The following commands are available to trigger required jobs:

  • /test e2e-gcp-console-olm
  • /test e2e-gcp-olm
  • /test e2e-gcp-ovn
  • /test e2e-upgrade
  • /test images
  • /test unit-api
  • /test unit-olm
  • /test unit-psm
  • /test unit-registry
  • /test verify

The following commands are available to trigger optional jobs:

  • /test e2e-gcp-olm-flaky

Use /test all to run all jobs.

Details

In response to this:

/retest e2e-upgrade

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tmshort

tmshort commented Mar 17, 2023

Copy link
Copy Markdown
Contributor Author

/test e2e-upgrade

3 similar comments
@tmshort

tmshort commented Mar 17, 2023

Copy link
Copy Markdown
Contributor Author

/test e2e-upgrade

@ankitathomas

ankitathomas commented Mar 18, 2023

Copy link
Copy Markdown
Contributor

/test e2e-upgrade

@tmshort

tmshort commented Mar 20, 2023

Copy link
Copy Markdown
Contributor Author

/test e2e-upgrade

@tmshort

tmshort commented Mar 20, 2023

Copy link
Copy Markdown
Contributor Author

/retest

2 similar comments
@tmshort

tmshort commented Mar 21, 2023

Copy link
Copy Markdown
Contributor Author

/retest

@tmshort

tmshort commented Mar 21, 2023

Copy link
Copy Markdown
Contributor Author

/retest

@tmshort tmshort changed the title Sync from api repo 1 Bug 2055861: Sync from api repo 1 Mar 21, 2023
@openshift-ci openshift-ci Bot added bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Mar 21, 2023
@openshift-ci

openshift-ci Bot commented Mar 21, 2023

Copy link
Copy Markdown
Contributor

@tmshort: This pull request references Bugzilla bug 2055861, which is invalid:

  • expected the bug to be open, but it isn't
  • expected the bug to target the "4.14.0" release, but it targets "4.11.0" instead
  • expected the bug to be in one of the following states: NEW, ASSIGNED, ON_DEV, POST, POST, but it is CLOSED (ERRATA) instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

Bug 2055861: Sync from api repo 1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@anik120

anik120 commented Mar 22, 2023

Copy link
Copy Markdown
Contributor

/test e2e-upgrade

@tmshort

tmshort commented Mar 22, 2023

Copy link
Copy Markdown
Contributor Author

/retest

@tmshort tmshort changed the title Bug 2055861: Sync from api repo 1 Sync from api repo 1 Mar 22, 2023
@openshift-ci openshift-ci Bot removed bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Mar 22, 2023
@openshift-ci

openshift-ci Bot commented Mar 22, 2023

Copy link
Copy Markdown
Contributor

@tmshort: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

Details

In response to this:

Sync from api repo 1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tmshort

tmshort commented Mar 22, 2023

Copy link
Copy Markdown
Contributor Author

/retest

@tmshort

tmshort commented Mar 22, 2023

Copy link
Copy Markdown
Contributor Author

Everything passed! But I need approvals, LGTM and other labels. @anik120

@grokspawn

grokspawn commented Mar 27, 2023

Copy link
Copy Markdown
Contributor

/lgmt
but don't we need a jira for this?

1 similar comment
@grokspawn

grokspawn commented Mar 27, 2023

Copy link
Copy Markdown
Contributor

/lgmt
but don't we need a jira for this?

@tmshort

tmshort commented Mar 27, 2023

Copy link
Copy Markdown
Contributor Author

There's no jira ticket associated with either of the upstream commits.

m1kola
m1kola approved these changes Mar 27, 2023
View reviewed changes

@m1kola m1kola left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Mar 27, 2023
@tmshort

tmshort commented Mar 27, 2023

Copy link
Copy Markdown
Contributor Author

@grokspawn Is there a way to override (Jira) or could @joelanford merge it?

@grokspawn

grokspawn commented Mar 27, 2023

Copy link
Copy Markdown
Contributor

@grokspawn Is there a way to override (Jira) or could @joelanford merge it?

Joe might be able to merge it, but I was pretty sure that the downstream process required a jira/BZ tracking vehicle.
@awgreene may be able to give context here.

@perdasilva

perdasilva commented Mar 27, 2023

Copy link
Copy Markdown
Contributor

/approve

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 27, 2023
@awgreene

awgreene commented Mar 27, 2023

Copy link
Copy Markdown
Contributor

/approve

@openshift-ci

openshift-ci Bot commented Mar 27, 2023

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: awgreene, m1kola, perdasilva, tmshort

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [awgreene,perdasilva]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tmshort tmshort changed the title Sync from api repo 1 OPRUN-2913: Sync from api repo 1 Mar 27, 2023
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Mar 27, 2023
@openshift-ci-robot

openshift-ci-robot commented Mar 27, 2023 •
edited by openshift-ci Bot
Loading

Copy link
Copy Markdown

@tmshort: This pull request references OPRUN-2913 which is a valid jira issue.

Details

In response to this:

This syncs two commits from the upstream api repo. Additional PRs will be opened for the rest of the api, operator-lifecycle-manager and operator-registry upstream repos.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot

openshift-ci-robot commented Jun 19, 2023

Copy link
Copy Markdown

/retest-required

Remaining retests: 0 against base HEAD a73360f and 2 for PR HEAD 619e491 in total

@openshift-ci-robot

openshift-ci-robot commented Jun 29, 2023

Copy link
Copy Markdown

/retest-required

Remaining retests: 0 against base HEAD 8c1c697 and 1 for PR HEAD 619e491 in total

@tmshort tmshort closed this Jun 29, 2023
@tmshort tmshort deleted the sync-api-1 branch October 23, 2023 13:37
openshift-bot pushed a commit to openshift-bot/operator-framework-olm that referenced this pull request Feb 27, 2026
@grokspawn
add bundle relatedimage image pullspec validation (openshift#475)
293d887 
Signed-off-by: grokspawn <jordan@nimblewidget.com>
Upstream-repository: api
Upstream-commit: 63554abeb51540fadade28fae27994da20de32f7
@openshift-bot openshift-bot mentioned this pull request Feb 27, 2026
Closed
openshift-bot pushed a commit to openshift-bot/operator-framework-olm that referenced this pull request Feb 27, 2026
@grokspawn
add bundle relatedimage image pullspec validation (openshift#475)
d8704fa 
Signed-off-by: grokspawn <jordan@nimblewidget.com>
Upstream-repository: api
Upstream-commit: 63554abeb51540fadade28fae27994da20de32f7
@openshift-bot openshift-bot mentioned this pull request Feb 27, 2026
Merged
openshift-bot pushed a commit to openshift-bot/operator-framework-olm that referenced this pull request Mar 3, 2026
@grokspawn
add bundle relatedimage image pullspec validation (openshift#475)
074f9aa 
Signed-off-by: grokspawn <jordan@nimblewidget.com>
Upstream-repository: api
Upstream-commit: 63554abeb51540fadade28fae27994da20de32f7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gallettilance gallettilance Awaiting requested review from gallettilance

@joelanford joelanford Awaiting requested review from joelanford

1 more reviewer

@m1kola m1kola m1kola approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@m1kola m1kola

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

9 participants

@tmshort @ankitathomas @anik120 @grokspawn @perdasilva @awgreene @openshift-ci-robot @m1kola @bcrochet