Skip to content

NO-ISSUE: Update verify_commits.sh to use main branch#1127

Merged
openshift-merge-bot[bot] merged 1 commit into
openshift:mainfrom
tmshort:move-master-to-main
Oct 25, 2025
Merged

NO-ISSUE: Update verify_commits.sh to use main branch#1127
openshift-merge-bot[bot] merged 1 commit into
openshift:mainfrom
tmshort:move-master-to-main

Conversation

@tmshort

@tmshort tmshort commented Oct 17, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

We now use the main branch. The CI call to this was changed to use main, but we might as well make it the default since make verify can be run locally.

@tmshort
Update verify_commits.sh to use main branch
dd29742 
Signed-off-by: Todd Short <todd.short@me.com>
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Oct 17, 2025
@openshift-ci-robot

openshift-ci-robot commented Oct 17, 2025

Copy link
Copy Markdown

@tmshort: This pull request explicitly references no jira issue.

Details

In response to this:

We now use the main branch. The call to this was changed to use main, but we might as well make it the default since make verify can be run locally.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@tmshort

tmshort commented Oct 17, 2025

Copy link
Copy Markdown
Contributor Author

The error being seen:

/Library/Developer/CommandLineTools/usr/bin/make verify-commits
./scripts/verify_commits.sh  # see https://github.com/kubernetes/test-infra/blob/master/prow/jobs.md#job-environment-variables
fatal: bad revision '^master'
[2025-10-17T12:18:05-0400]: detected 0 commit(s) to verify
Successfully validated all commits

@grokspawn

grokspawn commented Oct 17, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

Also update 108?

Looks like not, because if I do that I get an error, whereas 108 saying 'master' appears to grab the correct list of commits to evaluate.

@openshift-ci openshift-ci Bot requested review from bentito and perdasilva October 17, 2025 16:19
@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 17, 2025
@tmshort

tmshort commented Oct 17, 2025

Copy link
Copy Markdown
Contributor Author

And verify-deps is failing? This has nothing to do with that‽‽

@grokspawn

grokspawn commented Oct 17, 2025

Copy link
Copy Markdown
Contributor

This looks like a change in openshift/api dependency checking, and some "contagious" version. Great that it is "discovered" instead of "advertised".

@grokspawn

grokspawn commented Oct 17, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

Fixed here and needing to come downstream to resolve this, I guess.

Additional conversation which was discovered only after another team encountered the new "antibiotics": https://redhat-internal.slack.com/archives/C07RDCVEYJG/p1760624199090789

@jupierce

jupierce commented Oct 17, 2025

Copy link
Copy Markdown
Contributor

/override ci/prow/verify-deps

@openshift-ci

openshift-ci Bot commented Oct 17, 2025

Copy link
Copy Markdown
Contributor

@jupierce: Overrode contexts on behalf of jupierce: ci/prow/verify-deps

Details

In response to this:

/override ci/prow/verify-deps

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@grokspawn

grokspawn commented Oct 17, 2025

Copy link
Copy Markdown
Contributor

/retest-required

@tmshort

tmshort commented Oct 18, 2025

Copy link
Copy Markdown
Contributor Author

/retest

@tmshort

tmshort commented Oct 18, 2025

Copy link
Copy Markdown
Contributor Author

/retest-required

1 similar comment
@jianzhangbjz

jianzhangbjz commented Oct 20, 2025

Copy link
Copy Markdown
Contributor

/retest-required

@jianzhangbjz

jianzhangbjz commented Oct 20, 2025

Copy link
Copy Markdown
Contributor

/verified by pass
/lgtm
/approve

@openshift-ci-robot openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label Oct 20, 2025
@openshift-ci-robot

openshift-ci-robot commented Oct 20, 2025

Copy link
Copy Markdown

@jianzhangbjz: This PR has been marked as verified by pass.

Details

In response to this:

/verified by pass
/lgtm
/approve

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Oct 20, 2025
@openshift-ci

openshift-ci Bot commented Oct 20, 2025

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jianzhangbjz, tmshort

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot

openshift-ci-robot commented Oct 20, 2025

Copy link
Copy Markdown

/retest-required

Remaining retests: 0 against base HEAD bdc0d75 and 2 for PR HEAD dd29742 in total

@tmshort

tmshort commented Oct 20, 2025

Copy link
Copy Markdown
Contributor Author

/retest-required

1 similar comment
@jianzhangbjz

jianzhangbjz commented Oct 21, 2025

Copy link
Copy Markdown
Contributor

/retest-required

@jianzhangbjz

jianzhangbjz commented Oct 21, 2025

Copy link
Copy Markdown
Contributor

The ci/prow/e2e-gcp-olm got the below failure, which should be resolved by https://redhat-internal.slack.com/archives/C04FPB1H05A/p1760996979415059

error: unable to read image quay-proxy.ci.openshift.org/openshift/ci@sha256:7fa2a1a95aaa870f144f3e4ddf045206269eace0eef83de7a182591c64a305c8: unable to retrieve source image quay-proxy.ci.openshift.org/openshift/ci@sha256:7fa2a1a95aaa870f144f3e4ddf045206269eace0eef83de7a182591c64a305c8 manifest #1 from manifest list: received unexpected HTTP status: 500 Internal Server Error

@jianzhangbjz

jianzhangbjz commented Oct 21, 2025

Copy link
Copy Markdown
Contributor

/retest-required

@openshift-ci-robot

openshift-ci-robot commented Oct 21, 2025

Copy link
Copy Markdown

/retest-required

Remaining retests: 0 against base HEAD a0b88f9 and 1 for PR HEAD dd29742 in total

@jianzhangbjz

jianzhangbjz commented Oct 22, 2025

Copy link
Copy Markdown
Contributor

/retest-required

@tmshort

tmshort commented Oct 22, 2025

Copy link
Copy Markdown
Contributor Author

/retest-required

2 similar comments
@tmshort

tmshort commented Oct 23, 2025

Copy link
Copy Markdown
Contributor Author

/retest-required

@jianzhangbjz

jianzhangbjz commented Oct 24, 2025

Copy link
Copy Markdown
Contributor

/retest-required

@openshift-ci-robot

openshift-ci-robot commented Oct 24, 2025

Copy link
Copy Markdown

/retest-required

Remaining retests: 0 against base HEAD 7ff5cb5 and 0 for PR HEAD dd29742 in total

@openshift-ci

openshift-ci Bot commented Oct 25, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

@tmshort: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/okd-scos-e2e-aws-ovn dd29742 link false /test okd-scos-e2e-aws-ovn

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@tmshort

tmshort commented Oct 25, 2025

Copy link
Copy Markdown
Contributor Author

/retest-required

@openshift-merge-bot openshift-merge-bot Bot merged commit 25904d8 into openshift:main Oct 25, 2025
15 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bentito bentito Awaiting requested review from bentito

@perdasilva perdasilva Awaiting requested review from perdasilva

Assignees

@jianzhangbjz jianzhangbjz

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. verified Signifies that the PR passed pre-merge verification criteria

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@tmshort @openshift-ci-robot @grokspawn @jupierce @jianzhangbjz