[release-4.16] OCPBUGS-60847: Add NetworkPolicy as a supported kind#1050
Conversation
Signed-off-by: Anik Bhattacharjee <anbhatta@gmail.com> Upstream-repository: operator-registry Upstream-commit: 919aefdce3f4d6b77c3872df249815d20749db94
Signed-off-by: Rashmi Gottipati <chowdary.grashmi@gmail.com> Upstream-repository: operator-lifecycle-manager Upstream-commit: d7aaeb11ab80f862fc9c70dfb7865158bb67e28c
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: anik120 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
e4e142c to
5fa2213
Compare
|
/retest |
1 similar comment
|
/retest |
|
/retest-required |
1 similar comment
|
/retest-required |
|
/retest |
1 similar comment
|
/retest |
|
/retitle [release-4.16] OCPBUGS-60847: Add NetworkPolicy as a supported kind |
|
@anik120: This pull request references Jira Issue OCPBUGS-60847, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/label backport-risk-assessed |
|
ci/prow/e2e-gcp-olm last passed on 3 July. |
|
/test e2e-gcp-olm |
1 similar comment
|
/test e2e-gcp-olm |
|
/retest |
1 similar comment
|
/retest |
|
/test e2e-gcp-olm |
|
Looked into the test failures, and there's just one common test failure across multiple runs:
eg this test, and this test, both ran one after the other. Ran the test manually with an openshift cluster with the PR on top of it: Also verified that the cluster I created had the Unfortunately, the must-gather from CI does not have the test namespace that the test is run in (because of cleanup jobs), so I could not find much evidence to reason for why the test failed in the CI cluster. Gives us enough confidence for now though to keep letting CI run, especially cause a permissive, all-allow network policy in the Note that 4.16 has no other NetworkPolicies: |
|
/retest |
1 similar comment
|
/hold burning CI cycles is not going to help. Based on the report I wrote above, OCPBUGS-57092 needs to be updated to target 4.16 too, and override the test here for 4.16 instead |
|
Same test was the problem in 4.15 too #1012 (comment) |
|
Looking into test failure here: #1062 |
|
/retest |
|
/unhold |
|
/verified by @Xia-Zhao-rh |
|
@jianzhangbjz: This PR has been marked as verified by DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/test e2e-gcp-olm |
|
@anik120: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
91a201c
into
openshift:release-4.16
|
@anik120: Jira Issue Verification Checks: Jira Issue OCPBUGS-60847 Jira Issue OCPBUGS-60847 has been moved to the MODIFIED state and will move to the VERIFIED state when the change is available in an accepted nightly payload. 🕓 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
[ART PR BUILD NOTIFIER] Distgit: operator-lifecycle-manager |
|
[ART PR BUILD NOTIFIER] Distgit: operator-registry |
|
[ART PR BUILD NOTIFIER] Distgit: ose-operator-framework-tools |
Manual cherry-pick of #1047