Skip to content

NO-ISSUE: Enable readonlyRootFilesystem by default#1043

Merged
openshift-merge-bot[bot] merged 1 commit into
openshift:mainfrom
dusk125:rofs
Aug 14, 2025
Merged

NO-ISSUE: Enable readonlyRootFilesystem by default#1043
openshift-merge-bot[bot] merged 1 commit into
openshift:mainfrom
dusk125:rofs

Conversation

@dusk125

@dusk125 dusk125 commented Jul 24, 2025

Copy link
Copy Markdown
Contributor

No description provided.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jul 24, 2025
@openshift-ci-robot

openshift-ci-robot commented Jul 24, 2025

Copy link
Copy Markdown

@dusk125: This pull request explicitly references no jira issue.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@dusk125 dusk125 force-pushed the rofs branch 3 times, most recently from c84cd31 to 5c57e8d Compare July 24, 2025 20:43
@jianzhangbjz

jianzhangbjz commented Jul 25, 2025

Copy link
Copy Markdown
Contributor

I ran a round of regression tests for this PR, including auth rotation, and passed.

launch 4.20,openshift/operator-framework-olm#1043 aws

jiazha-mac:openshift-tests-private jiazha$ oc get clusterversion
NAME      VERSION                                                AVAILABLE   PROGRESSING   SINCE   STATUS
version   4.20.0-0-2025-07-25-020638-test-ci-ln-wxvv572-latest   True        False         50m     Cluster version is 4.20.0-0-2025-07-25-020638-test-ci-ln-wxvv572-latest

@jianzhangbjz

jianzhangbjz commented Jul 25, 2025

Copy link
Copy Markdown
Contributor

/label qe-approved
/lgtm

@openshift-ci openshift-ci Bot added the qe-approved Signifies that QE has signed off on this PR label Jul 25, 2025
@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Jul 25, 2025
@camilamacedo86

camilamacedo86 commented Jul 25, 2025

Copy link
Copy Markdown
Contributor

/test e2e-gcp-olm

@dusk125

dusk125 commented Jul 25, 2025

Copy link
Copy Markdown
Contributor Author

/retest-required

2 similar comments
@dusk125

dusk125 commented Jul 25, 2025

Copy link
Copy Markdown
Contributor Author

/retest-required

@dusk125

dusk125 commented Jul 29, 2025

Copy link
Copy Markdown
Contributor Author

/retest-required

@jianzhangbjz

jianzhangbjz commented Aug 5, 2025

Copy link
Copy Markdown
Contributor

/test e2e-gcp-olm

@tmshort

tmshort commented Aug 5, 2025

Copy link
Copy Markdown
Contributor

/approve

@openshift-ci

openshift-ci Bot commented Aug 5, 2025

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dusk125, tmshort

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 5, 2025
@openshift-ci-robot

openshift-ci-robot commented Aug 5, 2025

Copy link
Copy Markdown

/retest-required

Remaining retests: 0 against base HEAD 45b9152 and 2 for PR HEAD 5c57e8d in total

@dusk125

dusk125 commented Aug 5, 2025

Copy link
Copy Markdown
Contributor Author

/test e2e-gcp-console-olm

@openshift-ci-robot

openshift-ci-robot commented Aug 5, 2025

Copy link
Copy Markdown

/retest-required

Remaining retests: 0 against base HEAD 45b9152 and 2 for PR HEAD 5c57e8d in total

1 similar comment
@openshift-ci-robot

openshift-ci-robot commented Aug 6, 2025

Copy link
Copy Markdown

/retest-required

Remaining retests: 0 against base HEAD 45b9152 and 2 for PR HEAD 5c57e8d in total

@camilamacedo86

camilamacedo86 commented Aug 6, 2025

Copy link
Copy Markdown
Contributor

/retest-required

@jianzhangbjz

jianzhangbjz commented Aug 7, 2025

Copy link
Copy Markdown
Contributor

/test e2e-gcp-console-olm

@openshift-ci-robot

openshift-ci-robot commented Aug 7, 2025

Copy link
Copy Markdown

/retest-required

Remaining retests: 0 against base HEAD 45b9152 and 2 for PR HEAD 5c57e8d in total

@dusk125

dusk125 commented Aug 8, 2025

Copy link
Copy Markdown
Contributor Author

/retest-required

@openshift-ci-robot

openshift-ci-robot commented Aug 11, 2025

Copy link
Copy Markdown

/retest-required

Remaining retests: 0 against base HEAD 45b9152 and 2 for PR HEAD 5c57e8d in total

@grokspawn

grokspawn commented Aug 11, 2025

Copy link
Copy Markdown
Contributor

Not sure we can expect ci/prow/e2e-gcp-olm to pass here while operator-framework/operator-lifecycle-manager#3614 has not been downstreamed, since it is just executing the upstream e2e (see here).
I think 3614 needs to precede this work, be downstreamed, and then this might work.

@openshift-ci-robot

openshift-ci-robot commented Aug 11, 2025

Copy link
Copy Markdown

/retest-required

Remaining retests: 0 against base HEAD 8db3912 and 1 for PR HEAD 5c57e8d in total

@dusk125

dusk125 commented Aug 11, 2025

Copy link
Copy Markdown
Contributor Author

/hold
for operator-framework/operator-lifecycle-manager#3614

@openshift-ci openshift-ci Bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 11, 2025
@dusk125

dusk125 commented Aug 13, 2025

Copy link
Copy Markdown
Contributor Author

/retest
/hold cancel
upstream PR has merged

@openshift-ci openshift-ci Bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 13, 2025
@openshift-ci-robot

openshift-ci-robot commented Aug 13, 2025

Copy link
Copy Markdown

/retest-required

Remaining retests: 0 against base HEAD 8db3912 and 2 for PR HEAD 5c57e8d in total

2 similar comments
@openshift-ci-robot

openshift-ci-robot commented Aug 14, 2025

Copy link
Copy Markdown

/retest-required

Remaining retests: 0 against base HEAD 8db3912 and 2 for PR HEAD 5c57e8d in total

@openshift-ci-robot

openshift-ci-robot commented Aug 14, 2025

Copy link
Copy Markdown

/retest-required

Remaining retests: 0 against base HEAD 8db3912 and 2 for PR HEAD 5c57e8d in total

@openshift-ci-robot

openshift-ci-robot commented Aug 14, 2025

Copy link
Copy Markdown

/retest-required

Remaining retests: 0 against base HEAD 99823e1 and 1 for PR HEAD 5c57e8d in total

@openshift-ci openshift-ci Bot removed the lgtm Indicates that a PR is ready to be merged. label Aug 14, 2025
@dusk125

dusk125 commented Aug 14, 2025

Copy link
Copy Markdown
Contributor Author

/hold cancel
Rebased onto the synchronized main

@dusk125

dusk125 commented Aug 14, 2025

Copy link
Copy Markdown
Contributor Author

/retest

@openshift-ci

openshift-ci Bot commented Aug 14, 2025

Copy link
Copy Markdown
Contributor

@dusk125: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/okd-scos-e2e-aws-ovn cf18ee1 link false /test okd-scos-e2e-aws-ovn

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@grokspawn

grokspawn commented Aug 14, 2025

Copy link
Copy Markdown
Contributor

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Aug 14, 2025
@openshift-merge-bot openshift-merge-bot Bot merged commit 7fbd76c into openshift:main Aug 14, 2025
15 of 16 checks passed
@dusk125 dusk125 deleted the rofs branch August 14, 2025 23:28
@openshift-bot

openshift-bot commented Aug 15, 2025

Copy link
Copy Markdown
Contributor

[ART PR BUILD NOTIFIER]

Distgit: operator-lifecycle-manager
This PR has been included in build operator-lifecycle-manager-container-v4.20.0-202508150152.p0.g7fbd76c.assembly.stream.el9.
All builds following this will include this PR.

@openshift-bot

openshift-bot commented Aug 15, 2025

Copy link
Copy Markdown
Contributor

[ART PR BUILD NOTIFIER]

Distgit: operator-registry
This PR has been included in build operator-registry-container-v4.20.0-202508150152.p0.g7fbd76c.assembly.stream.el9.
All builds following this will include this PR.

@openshift-bot

openshift-bot commented Aug 15, 2025

Copy link
Copy Markdown
Contributor

[ART PR BUILD NOTIFIER]

Distgit: ose-operator-framework-tools
This PR has been included in build ose-operator-framework-tools-container-v4.20.0-202508150152.p0.g7fbd76c.assembly.stream.el9.
All builds following this will include this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@camilamacedo86 camilamacedo86 Awaiting requested review from camilamacedo86

@LalatenduMohanty LalatenduMohanty Awaiting requested review from LalatenduMohanty

Assignees

@jianzhangbjz jianzhangbjz

@grokspawn grokspawn

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. qe-approved Signifies that QE has signed off on this PR

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@dusk125 @openshift-ci-robot @jianzhangbjz @camilamacedo86 @tmshort @grokspawn @openshift-bot