systemd: install systemd.conf to enable CPU Accounting#581
Conversation
|
/test e2e-aws |
|
/hold |
e10f1ad to
b60a315
Compare
|
/retest |
3 similar comments
|
/retest |
|
/retest |
|
/retest |
|
/hold cancel |
There was a problem hiding this comment.
Don't use origin. Use kubelet-cgroups or something.
There was a problem hiding this comment.
kubelet-cgroup-accounting.conf
Can you add a description into the system unit so people know why this is there?
7f8028e to
5e8ff60
Compare
|
@smarterclayton thanks. Fixed both comments. |
|
/retest |
|
do we want to enable accounting just for {kubelet,crio}.service? enabling accounting globally will incur kernel overhead and will make the stats summary api response much larger. |
|
meh, nevermind. there aren't that many service on rhcos anyway and global memory accounting is already on by default. |
|
lgtm as well, approving |
|
/test unit works locally... |
|
Looks like master might be broken? |
5e8ff60 to
dde204e
Compare
|
Had to rebase and regenerate the templates due to a change on master. |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED Approval requirements bypassed by manually added approval. This pull-request has been approved by: rphillips, sjenning The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
/retest |
If this is the default for OpenShift already, we probably can enable it as well. see openshift/machine-config-operator#581
Install system.conf to enable CPU Accounting.
Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=1692131
- What I did
Install a custom system.conf file enabling CPU, BlockIO, and Memory accounting.
ref: https://github.com/openshift/origin/blob/master/contrib/systemd/origin-accounting.conf
- Description for the changelog
Enable CPU Accounting within systemd
/cc @sjenning @derekwaynecarr