Skip to content

NO-JIRA: remove default ServiceAccount which is deleted#5130

Closed
lance5890 wants to merge 1 commit into
openshift:mainfrom
lance5890:rm_default-account_mco_deleted
Closed

NO-JIRA: remove default ServiceAccount which is deleted#5130
lance5890 wants to merge 1 commit into
openshift:mainfrom
lance5890:rm_default-account_mco_deleted

Conversation

@lance5890

@lance5890 lance5890 commented Jun 20, 2025 •
edited
Loading

Copy link
Copy Markdown

- What I did

  1. As the default sa have already deleted in OCPBUGS-16905: install: Recreate and delayed default ServiceAccount deletion #3895
  2. And this yaml only works when upgrade from 4.13 to 4.14, no need to keep it in newest version(4.20)
    remove the deleted yaml in mco

address openshift/cluster-version-operator#1207
- How to verify it

- Description for the changelog

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jun 20, 2025
@openshift-ci-robot

openshift-ci-robot commented Jun 20, 2025

Copy link
Copy Markdown
Contributor

@lance5890: This pull request explicitly references no jira issue.

Details

In response to this:

- What I did

- How to verify it

- Description for the changelog

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci Bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jun 20, 2025
@openshift-ci

openshift-ci Bot commented Jun 20, 2025

Copy link
Copy Markdown
Contributor

Hi @lance5890. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci openshift-ci Bot requested review from pablintino and umohnani8 June 20, 2025 02:30
@lance5890

lance5890 commented Jun 20, 2025

Copy link
Copy Markdown
Author

/cc @wking

@openshift-ci openshift-ci Bot requested a review from wking June 20, 2025 02:32
lance5890
lance5890 commented Jun 20, 2025
View reviewed changes
Comment thread install/0000_90_machine-config_90_deletion.yaml
This was referenced Jul 1, 2025
Closed
Closed
@umohnani8

umohnani8 commented Jul 1, 2025

Copy link
Copy Markdown
Contributor

/approve

@openshift-ci

openshift-ci Bot commented Jul 1, 2025

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lance5890, umohnani8

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 1, 2025
@umohnani8

umohnani8 commented Jul 1, 2025

Copy link
Copy Markdown
Contributor

/ok-to-test

@openshift-ci openshift-ci Bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jul 1, 2025
@lance5890

lance5890 commented Jul 2, 2025

Copy link
Copy Markdown
Author

/retest-required

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 19, 2025
@lance5890
remove default ServiceAccount which is deleted
eb6e105 
Signed-off-by: lan.tian <lance5890@163.com>
@lance5890 lance5890 force-pushed the rm_default-account_mco_deleted branch from a634570 to eb6e105 Compare September 19, 2025 10:39
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 19, 2025
@lance5890

lance5890 commented Oct 1, 2025

Copy link
Copy Markdown
Author

/retest

@openshift-ci

openshift-ci Bot commented Oct 1, 2025

Copy link
Copy Markdown
Contributor

@lance5890: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/bootstrap-unit eb6e105 link false /test bootstrap-unit
ci/prow/e2e-aws-mco-disruptive eb6e105 link false /test e2e-aws-mco-disruptive
ci/prow/e2e-gcp-mco-disruptive eb6e105 link false /test e2e-gcp-mco-disruptive
ci/prow/e2e-azure-ovn-upgrade-out-of-change eb6e105 link false /test e2e-azure-ovn-upgrade-out-of-change
ci/prow/e2e-gcp-op-ocl eb6e105 link false /test e2e-gcp-op-ocl

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-bot

openshift-bot commented Dec 30, 2025

Copy link
Copy Markdown
Contributor

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@openshift-ci openshift-ci Bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Dec 30, 2025
@lance5890 lance5890 closed this Jan 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pablintino pablintino Awaiting requested review from pablintino

@umohnani8 umohnani8 Awaiting requested review from umohnani8

@wking wking Awaiting requested review from wking

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. ok-to-test Indicates a non-member PR verified by an org member that is safe to test.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@lance5890 @openshift-ci-robot @umohnani8 @openshift-bot @openshift-merge-robot