Skip to content

OCPBUGS-19400,OCPBUGS-21721: install/0000_90_machine-config-operator_90_deletion: Drop this file#3983

Merged
openshift-ci[bot] merged 1 commit into
openshift:release-4.13from
wking:drop-default-ClusterRoleBinding-deletion-manifest
Oct 17, 2023
Merged

OCPBUGS-19400,OCPBUGS-21721: install/0000_90_machine-config-operator_90_deletion: Drop this file#3983
openshift-ci[bot] merged 1 commit into
openshift:release-4.13from
wking:drop-default-ClusterRoleBinding-deletion-manifest

Conversation

@wking

@wking wking commented Oct 16, 2023

Copy link
Copy Markdown
Member

ace637f (#3740, OCPBUGS-10924) moved the 4.14 machine-config operator to a non-default ServiceAccount and ClusterRoleBinding. But 4.13 and earlier remain on the default ServiceAccount.

1cdb75f (#3923, OCPBUGS-19400) brought Recreate logic back to 4.13.14 and later (good), but also brought back a delete manifest for the default ClusterRoleBinding, which leads to the 4.13 cluster-version operator fighting with itself over whether that ClusterRoleBinding should exist (it should exist on 4.13, OCPBUGS-21721). For example, this CI run updates from 4.12.36 to 4.13.14, and has:

$ curl -s https://gcsweb-ci.apps.ci.l2s4.p1.openshiftapps.com/gcs/origin-ci-test/logs/release-openshift-origin-installer-e2e-aws-upgrade/1707415968109563904/artifacts/e2e-aws-upgrade/clusterversion.json | jq -r '.items[].status.conditions[] | select(.type == "Upgradeable") | .lastTransitionTime + " " + .type + "=" + .status + " " + .reason + ": " + .message'
2023-09-28T17:09:41Z Upgradeable=False ResourceDeletesInProgress: Cluster minor level upgrades are not allowed while resource deletions are in progress; resources=clusterrolebinding "default-account-openshift-machine-config-operator"

- What I did

By dropping the deletion manifest from 4.13, we avoid contention between two manifests, and leave the default ClusterRoleBinding alone until a later update to 4.14 will remove it.

- How to verify it

Update from 4.12 to 4.13. Confirm that the default ClusterRoleBinding exists and that ClusterVersion's Upgradeable is not complaining about resource deletions are in progress.

- Description for the changelog

Are we doing an MCO change-log? I'd expect this to get handled via Jira fields.

@wking wking changed the title install/0000_90_machine-config-operator_90_deletion: Drop this file OCPBUGS-10924: install/0000_90_machine-config-operator_90_deletion: Drop this file Oct 16, 2023
@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Oct 16, 2023
@openshift-ci-robot

Copy link
Copy Markdown
Contributor

@wking: This pull request references Jira Issue OCPBUGS-10924, which is invalid:

  • expected the bug to target the "4.13.z" version, but it targets "4.14.0" instead
  • expected the bug to be in one of the following states: NEW, ASSIGNED, POST, but it is Verified instead
  • expected Jira Issue OCPBUGS-10924 to depend on a bug targeting a version in 4.14.0 and in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

ace637f (#3740, OCPBUGS-10924) moved the 4.14 machine-config operator to a non-default ServiceAccount and ClusterRoleBinding. But 4.13 and earlier remain on the default ServiceAccount.

1cdb75f (#3923, OCPBUGS-19400) brought Recreate logic back to 4.13.14 and later (good), but also brought back a delete manifest for the default ClusterRoleBinding, which leads to the 4.13 cluster-version operator fighting with itself over whether that ClusterRoleBinding should exist (it should exist on 4.13, OCPBUGS-10924). For example, this CI run updates from 4.12.36 to 4.13.14, and has:

$ curl -s https://gcsweb-ci.apps.ci.l2s4.p1.openshiftapps.com/gcs/origin-ci-test/logs/release-openshift-origin-installer-e2e-aws-upgrade/1707415968109563904/artifacts/e2e-aws-upgrade/clusterversion.json | jq -r '.items[].status.conditions[] | select(.type == "Upgradeable") | .lastTransitionTime + " " + .type + "=" + .status + " " + .reason + ": " + .message'
2023-09-28T17:09:41Z Upgradeable=False ResourceDeletesInProgress: Cluster minor level upgrades are not allowed while resource deletions are in progress; resources=clusterrolebinding "default-account-openshift-machine-config-operator"

- What I did

By dropping the deletion manifest from 4.13, we avoid contention between two manifests, and leave the default ClusterRoleBinding alone until a later update to 4.14 will remove it.

- How to verify it

Update from 4.12 to 4.13. Confirm that the default ClusterRoleBinding exists and that ClusterVersion's Upgradeable is not complaining about resource deletions are in progress.

- Description for the changelog

Are we doing an MCO change-log? I'd expect this to get handled via Jira fields.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

ace637f (OCPBUGS-10924: Switch default SA to
machine-config-operator, 2023-06-23, openshift#3740) moved the 4.14
machine-config operator to a non-default ServiceAccount and
ClusterRoleBinding.  But 4.13 and earlier remain on the default
ServiceAccount.

1cdb75f (install: Recreate and delayed default ServiceAccount
deletion, 2023-09-19, openshift#3923, OCPBUGS-19400) brought Recreate logic
back to 4.13.14 [1] and later (good), but also brought back a 'delete'
manifest for the default ClusterRoleBinding, which leads to the 4.13
cluster-version operator fighting with itself over whether that
ClusterRoleBinding should exist (it should exist on 4.13) [2].  For
example, [3] updates from 4.12.36 to 4.13.14, and has:

  $ curl -s https://gcsweb-ci.apps.ci.l2s4.p1.openshiftapps.com/gcs/origin-ci-test/logs/release-openshift-origin-installer-e2e-aws-upgrade/1707415968109563904/artifacts/e2e-aws-upgrade/clusterversion.json | jq -r '.items[].status.conditions[] | select(.type == "Upgradeable") | .lastTransitionTime + " " + .type + "=" + .status + " " + .reason + ": " + .message'
  2023-09-28T17:09:41Z Upgradeable=False ResourceDeletesInProgress: Cluster minor level upgrades are not allowed while resource deletions are in progress; resources=clusterrolebinding "default-account-openshift-machine-config-operator"

By dropping the deletion manifest from 4.13, we avoid contention
between two manifests, and leave the default ClusterRoleBinding alone
until a later update to 4.14 will remove it.

[1]: https://amd64.ocp.releases.ci.openshift.org/releasestream/4-stable/release/4.13.14
[2]: https://issues.redhat.com/browse/OCPBUGS-21721
[3]: https://prow.ci.openshift.org/view/gs/origin-ci-test/logs/release-openshift-origin-installer-e2e-aws-upgrade/1707415968109563904
@wking wking force-pushed the drop-default-ClusterRoleBinding-deletion-manifest branch from 7a4c537 to 58a087b Compare October 16, 2023 21:40
@wking wking changed the title OCPBUGS-10924: install/0000_90_machine-config-operator_90_deletion: Drop this file OCPBUGS-21721: install/0000_90_machine-config-operator_90_deletion: Drop this file Oct 16, 2023
@openshift-ci-robot openshift-ci-robot added the jira/severity-moderate Referenced Jira bug's severity is moderate for the branch this PR is targeting. label Oct 16, 2023
@openshift-ci-robot

Copy link
Copy Markdown
Contributor

@wking: This pull request references Jira Issue OCPBUGS-21721, which is invalid:

  • expected Jira Issue OCPBUGS-21721 to depend on a bug targeting a version in 4.14.0 and in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

ace637f (#3740, OCPBUGS-10924) moved the 4.14 machine-config operator to a non-default ServiceAccount and ClusterRoleBinding. But 4.13 and earlier remain on the default ServiceAccount.

1cdb75f (#3923, OCPBUGS-19400) brought Recreate logic back to 4.13.14 and later (good), but also brought back a delete manifest for the default ClusterRoleBinding, which leads to the 4.13 cluster-version operator fighting with itself over whether that ClusterRoleBinding should exist (it should exist on 4.13, OCPBUGS-21721). For example, this CI run updates from 4.12.36 to 4.13.14, and has:

$ curl -s https://gcsweb-ci.apps.ci.l2s4.p1.openshiftapps.com/gcs/origin-ci-test/logs/release-openshift-origin-installer-e2e-aws-upgrade/1707415968109563904/artifacts/e2e-aws-upgrade/clusterversion.json | jq -r '.items[].status.conditions[] | select(.type == "Upgradeable") | .lastTransitionTime + " " + .type + "=" + .status + " " + .reason + ": " + .message'
2023-09-28T17:09:41Z Upgradeable=False ResourceDeletesInProgress: Cluster minor level upgrades are not allowed while resource deletions are in progress; resources=clusterrolebinding "default-account-openshift-machine-config-operator"

- What I did

By dropping the deletion manifest from 4.13, we avoid contention between two manifests, and leave the default ClusterRoleBinding alone until a later update to 4.14 will remove it.

- How to verify it

Update from 4.12 to 4.13. Confirm that the default ClusterRoleBinding exists and that ClusterVersion's Upgradeable is not complaining about resource deletions are in progress.

- Description for the changelog

Are we doing an MCO change-log? I'd expect this to get handled via Jira fields.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci Bot requested review from cgwalters and jkyros October 16, 2023 21:42
@wking

wking commented Oct 16, 2023

Copy link
Copy Markdown
Member Author

/jira refresh

@openshift-ci-robot

Copy link
Copy Markdown
Contributor

@wking: This pull request references Jira Issue OCPBUGS-21721, which is invalid:

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@yuqi-zhang

Copy link
Copy Markdown
Contributor

Ignore the bootstrap-unit failure, I caused that via a previous PR and haven't had a chance to fix it. Regardless, not a blocking job

@wking

wking commented Oct 16, 2023

Copy link
Copy Markdown
Member Author

/jira refresh

@openshift-ci-robot openshift-ci-robot added the jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. label Oct 16, 2023
@openshift-ci-robot

Copy link
Copy Markdown
Contributor

@wking: This pull request references Jira Issue OCPBUGS-21721, which is valid. The bug has been moved to the POST state.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.13.z) matches configured target version for branch (4.13.z)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)
  • dependent bug Jira Issue OCPBUGS-21764 is in the state Closed (Done), which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
  • dependent Jira Issue OCPBUGS-21764 targets the "4.14.0" version, which is one of the valid target versions: 4.14.0
  • bug has dependents

Requesting review from QA contact:
/cc @sergiordlr

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot removed the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Oct 16, 2023
@openshift-ci openshift-ci Bot requested a review from sergiordlr October 16, 2023 23:18
@openshift-ci

openshift-ci Bot commented Oct 16, 2023

Copy link
Copy Markdown
Contributor

@wking: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/bootstrap-unit 58a087b link false /test bootstrap-unit
ci/prow/okd-scos-e2e-aws-ovn 58a087b link false /test okd-scos-e2e-aws-ovn

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@rioliu-rh

Copy link
Copy Markdown

/label cherry-pick-approved

@openshift-ci openshift-ci Bot added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Oct 17, 2023
@rioliu-rh

rioliu-rh commented Oct 17, 2023

Copy link
Copy Markdown

pre-merge testing, build ci image with this PR
upgrade cluster from 4.12.38 to 4.13.0-0.ci.test-2023-10-17-020658-ci-ln-ztgfry2-latest.
upgrade is completed successfully
check status conditions of clusterversion/version, no condition ResourceDeletesInProgress found.

$ cv version -o yaml | yq -y '.status.conditions'
- lastTransitionTime: '2023-10-17T02:24:27Z'
  message: 'Unable to retrieve available updates: currently reconciling cluster version
    4.13.0-0.ci.test-2023-10-17-020658-ci-ln-ztgfry2-latest not found in the "stable-4.12"
    channel'
  reason: VersionNotFound
  status: 'False'
  type: RetrievedUpdates
- lastTransitionTime: '2023-10-17T02:50:37Z'
  message: Capabilities match configured spec
  reason: AsExpected
  status: 'False'
  type: ImplicitlyEnabledCapabilities
- lastTransitionTime: '2023-10-17T02:24:27Z'
  message: Payload loaded version="4.13.0-0.ci.test-2023-10-17-020658-ci-ln-ztgfry2-latest"
    image="registry.build05.ci.openshift.org/ci-ln-ztgfry2/release:latest" architecture="amd64"
  reason: PayloadLoaded
  status: 'True'
  type: ReleaseAccepted
- lastTransitionTime: '2023-10-17T02:43:14Z'
  message: Done applying 4.13.0-0.ci.test-2023-10-17-020658-ci-ln-ztgfry2-latest
  status: 'True'
  type: Available
- lastTransitionTime: '2023-10-17T03:56:12Z'
  status: 'False'
  type: Failing
- lastTransitionTime: '2023-10-17T03:58:27Z'
  message: Cluster version is 4.13.0-0.ci.test-2023-10-17-020658-ci-ln-ztgfry2-latest
  status: 'False'
  type: Progressing

upgrade history

$ cv version -o yaml | yq -y '.status.history'
- acceptedRisks: 'Target release version="" image="registry.build05.ci.openshift.org/ci-ln-ztgfry2/release:latest"
    cannot be verified, but continuing anyway because the update was forced: release
    images that are not accessed via digest cannot be verified

    Forced through blocking failures: Multiple precondition checks failed:

    * Precondition "ClusterVersionUpgradeable" failed because of "AdminAckRequired":
    Kubernetes 1.26 and therefore OpenShift 4.13 remove several APIs which require
    admin consideration. Please see the knowledge article https://access.redhat.com/articles/6958394
    for details and instructions.

    * Precondition "EtcdRecentBackup" failed because of "ControllerStarted": RecentBackup:
    The etcd backup controller is starting, and will decide if recent backups are
    available or if a backup is required

    * Precondition "ClusterVersionRecommendedUpdate" failed because of "UnknownUpdate":
    RetrievedUpdates=False (VersionNotFound), so the recommended status of updating
    from 4.12.38 to 4.13.0-0.ci.test-2023-10-17-020658-ci-ln-ztgfry2-latest is unknown.'
  completionTime: '2023-10-17T03:58:27Z'
  image: registry.build05.ci.openshift.org/ci-ln-ztgfry2/release:latest
  startedTime: '2023-10-17T02:50:34Z'
  state: Completed
  verified: false
  version: 4.13.0-0.ci.test-2023-10-17-020658-ci-ln-ztgfry2-latest
- completionTime: '2023-10-17T02:43:14Z'
  image: quay.io/openshift-release-dev/ocp-release@sha256:09e50f5d863fdcecdb4a7e3fe2c78e5bec992f10be032acadc317c0d66c79700
  startedTime: '2023-10-17T02:24:27Z'
  state: Completed
  verified: false
  version: 4.12.38

check default clusterrolebinding

$ oc get clusterrolebinding/default-account-openshift-machine-config-operator -n openshift-machine-config-operator
NAME                                                ROLE                        AGE
default-account-openshift-machine-config-operator   ClusterRole/cluster-admin   118m

@rioliu-rh

Copy link
Copy Markdown

@sinnykumari

Copy link
Copy Markdown
Contributor

this makes sense. Thanks Trevor
/lgtm
/label backport-risk-assessed

@openshift-ci openshift-ci Bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Oct 17, 2023
@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Oct 17, 2023
@openshift-ci

openshift-ci Bot commented Oct 17, 2023

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sinnykumari, wking

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 17, 2023
@openshift-ci openshift-ci Bot merged commit 645056f into openshift:release-4.13 Oct 17, 2023
@openshift-ci-robot

Copy link
Copy Markdown
Contributor

@wking: Jira Issue OCPBUGS-21721: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-21721 has been moved to the MODIFIED state.

Details

In response to this:

ace637f (#3740, OCPBUGS-10924) moved the 4.14 machine-config operator to a non-default ServiceAccount and ClusterRoleBinding. But 4.13 and earlier remain on the default ServiceAccount.

1cdb75f (#3923, OCPBUGS-19400) brought Recreate logic back to 4.13.14 and later (good), but also brought back a delete manifest for the default ClusterRoleBinding, which leads to the 4.13 cluster-version operator fighting with itself over whether that ClusterRoleBinding should exist (it should exist on 4.13, OCPBUGS-21721). For example, this CI run updates from 4.12.36 to 4.13.14, and has:

$ curl -s https://gcsweb-ci.apps.ci.l2s4.p1.openshiftapps.com/gcs/origin-ci-test/logs/release-openshift-origin-installer-e2e-aws-upgrade/1707415968109563904/artifacts/e2e-aws-upgrade/clusterversion.json | jq -r '.items[].status.conditions[] | select(.type == "Upgradeable") | .lastTransitionTime + " " + .type + "=" + .status + " " + .reason + ": " + .message'
2023-09-28T17:09:41Z Upgradeable=False ResourceDeletesInProgress: Cluster minor level upgrades are not allowed while resource deletions are in progress; resources=clusterrolebinding "default-account-openshift-machine-config-operator"

- What I did

By dropping the deletion manifest from 4.13, we avoid contention between two manifests, and leave the default ClusterRoleBinding alone until a later update to 4.14 will remove it.

- How to verify it

Update from 4.12 to 4.13. Confirm that the default ClusterRoleBinding exists and that ClusterVersion's Upgradeable is not complaining about resource deletions are in progress.

- Description for the changelog

Are we doing an MCO change-log? I'd expect this to get handled via Jira fields.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@rioliu-rh

Copy link
Copy Markdown

/retitle OCPBUGS-19400,OCPBUGS-21721: install/0000_90_machine-config-operator_90_deletion: Drop this file

@openshift-ci openshift-ci Bot changed the title OCPBUGS-21721: install/0000_90_machine-config-operator_90_deletion: Drop this file OCPBUGS-19400,OCPBUGS-21721: install/0000_90_machine-config-operator_90_deletion: Drop this file Oct 17, 2023
@openshift-ci-robot

Copy link
Copy Markdown
Contributor

@wking: Jira Issue OCPBUGS-19400: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-19400 has been moved to the MODIFIED state.

Jira Issue OCPBUGS-21721 is in an unrecognized state (MODIFIED) and will not be moved to the MODIFIED state.

Details

In response to this:

ace637f (#3740, OCPBUGS-10924) moved the 4.14 machine-config operator to a non-default ServiceAccount and ClusterRoleBinding. But 4.13 and earlier remain on the default ServiceAccount.

1cdb75f (#3923, OCPBUGS-19400) brought Recreate logic back to 4.13.14 and later (good), but also brought back a delete manifest for the default ClusterRoleBinding, which leads to the 4.13 cluster-version operator fighting with itself over whether that ClusterRoleBinding should exist (it should exist on 4.13, OCPBUGS-21721). For example, this CI run updates from 4.12.36 to 4.13.14, and has:

$ curl -s https://gcsweb-ci.apps.ci.l2s4.p1.openshiftapps.com/gcs/origin-ci-test/logs/release-openshift-origin-installer-e2e-aws-upgrade/1707415968109563904/artifacts/e2e-aws-upgrade/clusterversion.json | jq -r '.items[].status.conditions[] | select(.type == "Upgradeable") | .lastTransitionTime + " " + .type + "=" + .status + " " + .reason + ": " + .message'
2023-09-28T17:09:41Z Upgradeable=False ResourceDeletesInProgress: Cluster minor level upgrades are not allowed while resource deletions are in progress; resources=clusterrolebinding "default-account-openshift-machine-config-operator"

- What I did

By dropping the deletion manifest from 4.13, we avoid contention between two manifests, and leave the default ClusterRoleBinding alone until a later update to 4.14 will remove it.

- How to verify it

Update from 4.12 to 4.13. Confirm that the default ClusterRoleBinding exists and that ClusterVersion's Upgradeable is not complaining about resource deletions are in progress.

- Description for the changelog

Are we doing an MCO change-log? I'd expect this to get handled via Jira fields.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@rioliu-rh

Copy link
Copy Markdown

/jira refresh

@openshift-ci-robot

Copy link
Copy Markdown
Contributor

@rioliu-rh: Jira Issue OCPBUGS-19400 is in an unrecognized state (MODIFIED) and will not be moved to the MODIFIED state.

Jira Issue OCPBUGS-21721 is in an unrecognized state (MODIFIED) and will not be moved to the MODIFIED state.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@wking wking deleted the drop-default-ClusterRoleBinding-deletion-manifest branch October 17, 2023 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. jira/severity-moderate Referenced Jira bug's severity is moderate for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.