redo multi project fix to punt objectList<->projectList correlation, …#138
Conversation
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: gabemontero The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Install origin flake /retest |
|
Several confirmations from upstream users have arrived confirming that the manually built plugins from this branch has solved the issue for them. /hold cancel @openshift/sig-developer-experience bump ... any takers/folks with bandwidth for a review? I'll wait until sometime after lunch to see if anyone can. |
|
|
||
| Result r = new Result(verb); | ||
| ArrayList<String> projectNames = new ArrayList<String>(); | ||
| HashMap<String, String> projectNames = null;// = new HashMap<String, String>(); |
There was a problem hiding this comment.
yep should clean that up
| String name = obj2MapMetadata.get("name"); | ||
| r = innerObjectDefAction(verb, obj2, userArgs, ns, r); | ||
| projectNames.add(ns); | ||
| projectNames.put(kind.toLowerCase().trim()+"/"+name, ns); |
There was a problem hiding this comment.
isn't this going to have collisions if someone is creating a "build/foo" in two namespaces?
There was a problem hiding this comment.
yep you are right
alas, more groovy pain to come as I figure out how to assess :-(
There was a problem hiding this comment.
ok I think the change to address is minor .... will test out in the AM
|
/hold cancel |
|
stopped ci job |
|
/hold |
|
/hold cancel |
|
@bparees comments addressed |
|
separate commit |
|
install origin failure .... more instances of openshift/origin#19293 |
|
/retest |
1 similar comment
|
/retest |
| projList.put(name, project); | ||
| // we hardcode the suffix to 0 since we are only sending | ||
| // 1 item from the original nameelist down ... hence the | ||
| // suffix is no the index for the first entry in the array |
There was a problem hiding this comment.
s/nameelist/namelist/
s/no/not? now?/
|
/refresh |
…employ more passive project assignment
738704e to
bb5f9fa
Compare
…y-return redo multi project fix to punt objectList<->projectList correlation, …
…employ more passive project assignment
Fixes #130
@openshift/sig-developer-experience ptal
this fix addresses issues introduced by the earlier mulit-project fix for single project envs,
but still maintains the ability to have multi-project creates.
on the bright side, this version simplifies to a decent extent the original multi-project fix.
NOTE: I have obtained agreement from 2 upstream users to validate the fix. I'm going the attempt to hold merging until we have validation from them, assuming they respond relatively soon. Also, we do now have a multi-project test case in the PR extended tests, so we should be good there.
In both upstream users cases, they are hitting timing issues between when selectors with DCs are created, and when they attempt to iterate over pods associated with them with
openshift.withEach. While they can hit the issue fairly reliably with their Jenkins files, it has been much less frequent with me (I have seen it like once after many runs).I also found an issue with the
openshift.unionmethod ... I plan on creating a new test case for that.