Skip to content

tests: fix timeout loading logs in CRD extensions test#7709

Merged
openshift-merge-robot merged 1 commit into
openshift:masterfrom
spadgett:crd-test-log-timeout
Jan 6, 2021
Merged

tests: fix timeout loading logs in CRD extensions test#7709
openshift-merge-robot merged 1 commit into
openshift:masterfrom
spadgett:crd-test-log-timeout

Conversation

@spadgett

@spadgett spadgett commented Jan 5, 2021

Copy link
Copy Markdown
Member

We don't need to wait for the log content itself to check if the log links are present. The log is sometimes slow to load, causing the tests to timeout.

/cc @dtaylor113 @rhamilto

@spadgett
tests: fix timeout loading logs in CRD extensions test
ead8f49 
We don't need to wait for the log content itself to check if the log
links are present. The log is sometimes slow to load, causing the tests
to timeout.
@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 5, 2021
This was referenced Jan 5, 2021
Merged
Merged
dtaylor113
dtaylor113 approved these changes Jan 5, 2021
View reviewed changes

@dtaylor113 dtaylor113 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 5, 2021
@openshift-ci-robot

openshift-ci-robot commented Jan 5, 2021

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dtaylor113, spadgett

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-bot

openshift-bot commented Jan 5, 2021

Copy link
Copy Markdown
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

13 similar comments
@openshift-bot

openshift-bot commented Jan 5, 2021

Copy link
Copy Markdown
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot

openshift-bot commented Jan 5, 2021

Copy link
Copy Markdown
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot

openshift-bot commented Jan 5, 2021

Copy link
Copy Markdown
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot

openshift-bot commented Jan 5, 2021

Copy link
Copy Markdown
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot

openshift-bot commented Jan 5, 2021

Copy link
Copy Markdown
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot

openshift-bot commented Jan 5, 2021

Copy link
Copy Markdown
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot

openshift-bot commented Jan 5, 2021

Copy link
Copy Markdown
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot

openshift-bot commented Jan 5, 2021

Copy link
Copy Markdown
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot

openshift-bot commented Jan 5, 2021

Copy link
Copy Markdown
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot

openshift-bot commented Jan 5, 2021

Copy link
Copy Markdown
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot

openshift-bot commented Jan 5, 2021

Copy link
Copy Markdown
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot

openshift-bot commented Jan 6, 2021

Copy link
Copy Markdown
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot

openshift-bot commented Jan 6, 2021

Copy link
Copy Markdown
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 5a8786c into openshift:master Jan 6, 2021
@spadgett spadgett deleted the crd-test-log-timeout branch January 6, 2021 14:16
@spadgett spadgett added this to the v4.7 milestone Jan 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rhamilto rhamilto Awaiting requested review from rhamilto

1 more reviewer

@dtaylor113 dtaylor113 dtaylor113 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@dtaylor113 dtaylor113

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

v4.7

Development

Successfully merging this pull request may close these issues.

5 participants

@spadgett @openshift-ci-robot @openshift-bot @dtaylor113 @openshift-merge-robot