Skip to content

OCPBUGS-57298: rm hello-openshift yaml #642

Merged
openshift-merge-bot[bot] merged 1 commit into
openshift:mainfrom
lance5890:clenaup_hello-openshift_IS
Jun 10, 2025
Merged

OCPBUGS-57298: rm hello-openshift yaml #642
openshift-merge-bot[bot] merged 1 commit into
openshift:mainfrom
lance5890:clenaup_hello-openshift_IS

Conversation

@lance5890

@lance5890 lance5890 commented Jun 5, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

This hello-openshift ImageStream is removed in ocp 4.8 within #380

address openshift/cluster-version-operator#1207

And now the OCP 4.18 has no longer need this YAML anymore, remove the redundant YAML

image

@lance5890
Update 08-openshift-imagestreams.yaml
d316e9c 
cleanup hello-openshift yaml in ImageStream
@openshift-ci openshift-ci Bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jun 5, 2025
@openshift-ci

openshift-ci Bot commented Jun 5, 2025

Copy link
Copy Markdown
Contributor

Hi @lance5890. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci openshift-ci Bot requested review from fbm3307 and rhdmalone June 5, 2025 08:33
@lance5890 lance5890 changed the title cleanup hello-openshift yaml NO-JIRA: cleanup hello-openshift yaml Jun 5, 2025
@openshift-ci-robot

openshift-ci-robot commented Jun 5, 2025

Copy link
Copy Markdown
Contributor

@lance5890: This pull request explicitly references no jira issue.

Details

In response to this:

This hello-openshift is removed in ocp 4.8 within #380

And now the OCP 4.18 has no longer need this YAML anymore, remove the redundant YAML

image

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jun 5, 2025
@aroyoredhat

aroyoredhat commented Jun 9, 2025

Copy link
Copy Markdown
Contributor

/ok-to-test

@openshift-ci openshift-ci Bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jun 9, 2025
@lance5890

lance5890 commented Jun 10, 2025

Copy link
Copy Markdown
Contributor Author

/test okd-scos-e2e-aws-ovn

1 similar comment
@lance5890

lance5890 commented Jun 10, 2025

Copy link
Copy Markdown
Contributor Author

/test okd-scos-e2e-aws-ovn

@openshift-ci

openshift-ci Bot commented Jun 10, 2025

Copy link
Copy Markdown
Contributor

@lance5890: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

lance5890
lance5890 commented Jun 10, 2025
View reviewed changes
Comment thread manifests/08-openshift-imagestreams.yaml
@lance5890

lance5890 commented Jun 10, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

aroyoredhat

@aroyoredhat e2e all passed, could u please take a look

@aroyoredhat

aroyoredhat commented Jun 10, 2025

Copy link
Copy Markdown
Contributor

/lgtm

@aroyoredhat

aroyoredhat commented Jun 10, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

@lance5890 Please add this jira on the title OCPBUGS-57298 to link it automatically

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Jun 10, 2025
@openshift-ci

openshift-ci Bot commented Jun 10, 2025

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aroyoredhat, lance5890

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 10, 2025
@openshift-merge-bot openshift-merge-bot Bot merged commit 3ac08e5 into openshift:main Jun 10, 2025
11 checks passed
@openshift-bot

openshift-bot commented Jun 10, 2025

Copy link
Copy Markdown
Contributor

[ART PR BUILD NOTIFIER]

Distgit: ose-cluster-samples-operator
This PR has been included in build ose-cluster-samples-operator-container-v4.20.0-202506102021.p0.g3ac08e5.assembly.stream.el9.
All builds following this will include this PR.

@lance5890 lance5890 changed the title NO-JIRA: cleanup hello-openshift yaml OCPBUGS-57298: cleanup hello-openshift yaml Jun 10, 2025
@openshift-ci-robot

openshift-ci-robot commented Jun 10, 2025

Copy link
Copy Markdown
Contributor

@lance5890: Jira Issue OCPBUGS-57298: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-57298 has been moved to the MODIFIED state.

Details

In response to this:

This hello-openshift ImageStream is removed in ocp 4.8 within #380

And now the OCP 4.18 has no longer need this YAML anymore, remove the redundant YAML

image

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@lance5890

lance5890 commented Jun 10, 2025

Copy link
Copy Markdown
Contributor Author

@lance5890 Please add this jira on the title OCPBUGS-57298 to link it automatically

done

@lance5890 lance5890 changed the title OCPBUGS-57298: cleanup hello-openshift yaml OCPBUGS-57298: rm hello-openshift yaml Jun 16, 2025
This was referenced Jul 1, 2025
Closed
Closed
@openshift-ci-robot

openshift-ci-robot commented Jul 1, 2025

Copy link
Copy Markdown
Contributor

@lance5890: Jira Issue OCPBUGS-57298 is in an unrecognized state (Verified) and will not be moved to the MODIFIED state.

Details

In response to this:

This hello-openshift ImageStream is removed in ocp 4.8 within #380

address openshift/cluster-version-operator#1207

And now the OCP 4.18 has no longer need this YAML anymore, remove the redundant YAML

image

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fbm3307 fbm3307 Awaiting requested review from fbm3307

@rhdmalone rhdmalone Awaiting requested review from rhdmalone

Assignees

@aroyoredhat aroyoredhat

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@lance5890 @openshift-ci-robot @aroyoredhat @openshift-bot