Skip to content

Bug 2001977: delete hello-openshift in payload imagestream#393

Merged
openshift-merge-robot merged 2 commits into
openshift:release-4.7from
gabemontero:proper-rm-hello-openshift-47
Sep 23, 2021
Merged

Bug 2001977: delete hello-openshift in payload imagestream#393
openshift-merge-robot merged 2 commits into
openshift:release-4.7from
gabemontero:proper-rm-hello-openshift-47

Conversation

@gabemontero

@gabemontero gabemontero commented Sep 7, 2021

Copy link
Copy Markdown
Contributor

cherry pick failed ... example #380 (comment)

ultimately want to get this back to 4.7 .... see #385 (comment)

/assign @dperaza4dustbit

more tech debt I was still carrying prior to hand off

NOTE: confirmed with @jottofar that the install feature of using an annotation to have CVO delete a given item it manages is not getting backported to 4.7, so we just have to remove the imagestream like we did in 4.8.

@openshift-ci openshift-ci Bot added bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Sep 7, 2021
@openshift-ci

openshift-ci Bot commented Sep 7, 2021

Copy link
Copy Markdown
Contributor

@gabemontero: This pull request references Bugzilla bug 2001977, which is invalid:

  • expected dependent Bugzilla bug 2001974 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but it is POST instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

Bug 2001977: delete hello-openshift in payload imagestream via CVO annotation

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci Bot requested review from adambkaplan and dmage September 7, 2021 15:26
@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 7, 2021
@gabemontero

Copy link
Copy Markdown
Contributor Author

sig api machinery flake e2e-aws

/retest

@gabemontero

Copy link
Copy Markdown
Contributor Author

if https://bugzilla.redhat.com/show_bug.cgi?id=1976307 is not backported to 4.7 than simple delete of hello-openshift will be our only option

@gabemontero

Copy link
Copy Markdown
Contributor Author

/hold

@openshift-ci openshift-ci Bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 9, 2021
@gabemontero

Copy link
Copy Markdown
Contributor Author

/bugzilla refresh

@openshift-ci

openshift-ci Bot commented Sep 9, 2021

Copy link
Copy Markdown
Contributor

@gabemontero: An error was encountered querying GitHub for users with public email (jitsingh@redhat.com) for bug 2001977 on the Bugzilla server at https://bugzilla.redhat.com. No known errors were detected, please see the full error message for details.

Full error message. non-200 OK status code: 403 Forbidden body: "{\n \"documentation_url\": \"https://docs.github.com/en/free-pro-team@latest/rest/overview/resources-in-the-rest-api#secondary-rate-limits\",\n \"message\": \"You have exceeded a secondary rate limit. Please wait a few minutes before you try again.\"\n}\n"

Please contact an administrator to resolve this issue, then request a bug refresh with /bugzilla refresh.

Details

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@gabemontero gabemontero force-pushed the proper-rm-hello-openshift-47 branch from 5e3eb34 to 961f4a9 Compare September 9, 2021 13:12
@gabemontero

Copy link
Copy Markdown
Contributor Author

/bugzilla refresh

@openshift-ci openshift-ci Bot added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Sep 9, 2021
@openshift-ci

openshift-ci Bot commented Sep 9, 2021

Copy link
Copy Markdown
Contributor

@gabemontero: This pull request references Bugzilla bug 2001977, which is valid.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.7.z) matches configured target release for branch (4.7.z)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
  • dependent bug Bugzilla bug 2001974 is in the state VERIFIED, which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE))
  • dependent Bugzilla bug 2001974 targets the "4.8.z" release, which is one of the valid target releases: 4.8.0, 4.8.z
  • bug has dependents

Requesting review from QA contact:
/cc @jitendar-singh

Details

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@gabemontero

Copy link
Copy Markdown
Contributor Author

/retest

@gabemontero

Copy link
Copy Markdown
Contributor Author

/test okd-e2e-aws-builds

@gabemontero

Copy link
Copy Markdown
Contributor Author

hey @vrutkovs - heads up, I'm seeing a bug in the 4.7 version of the OKD version of the imagestream

It is missing the "2.7" tag.

By comparison, it exists in the master branch: https://github.com/openshift/cluster-samples-operator/blob/master/assets/operator/okd-x86_64/ruby/imagestreams/ruby-centos.json#L103-L123

I see where you updated upstream with sclorg/s2i-ruby-container@4d4a6e7

But my guress is that was after the 4.7 GA.

I'm going to go ahead and fix 4.7 with this PR

@gabemontero

Copy link
Copy Markdown
Contributor Author

/hold cancel

@openshift-ci openshift-ci Bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 13, 2021
@openshift-ci

openshift-ci Bot commented Sep 13, 2021

Copy link
Copy Markdown
Contributor

@gabemontero: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/okd-e2e-aws-upgrade 0e8b14f link false /test okd-e2e-aws-upgrade
ci/prow/okd-e2e-aws-jenkins 0e8b14f link false /test okd-e2e-aws-jenkins

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@gabemontero

Copy link
Copy Markdown
Contributor Author

ok we now have okd-e2e-aws-build passing now ... the otherokd's passed previously but now hit unrelated flakes

/skip

@gabemontero

Copy link
Copy Markdown
Contributor Author

/retest

@gabemontero

Copy link
Copy Markdown
Contributor Author

/assign @coreydaley

@coreydaley

Copy link
Copy Markdown

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Sep 13, 2021
@openshift-ci

openshift-ci Bot commented Sep 13, 2021

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: coreydaley, gabemontero

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@gabemontero gabemontero changed the title Bug 2001977: delete hello-openshift in payload imagestream via CVO annotation Bug 2001977: delete hello-openshift in payload imagestream Sep 15, 2021
@openshift-ci

openshift-ci Bot commented Sep 15, 2021

Copy link
Copy Markdown
Contributor

@gabemontero: This pull request references Bugzilla bug 2001977, which is valid.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.7.z) matches configured target release for branch (4.7.z)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
  • dependent bug Bugzilla bug 2001974 is in the state VERIFIED, which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE))
  • dependent Bugzilla bug 2001974 targets the "4.8.z" release, which is one of the valid target releases: 4.8.0, 4.8.z
  • bug has dependents

Requesting review from QA contact:
/cc @jitendar-singh

Details

In response to this:

Bug 2001977: delete hello-openshift in payload imagestream

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@gabemontero

Copy link
Copy Markdown
Contributor Author

/hold

just for a bit ... double checking the console bits around this imagestream

@openshift-ci openshift-ci Bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 16, 2021
@gabemontero

Copy link
Copy Markdown
Contributor Author

we need openshift/console#10089 to merge first so that this PR does not break the 4.7 console

thanks @spadgett !!

@dhellmann

Copy link
Copy Markdown

[patch-manager] ⌛ This pull request was not picked by the patch manager for the current z-stream window and have to wait for the next window.

skipped for today

  • Score: 0.00
  • Reason: skipping because "do-not-merge/hold" label found

NOTE: This message was automatically generated, if you have questions please ask on #forum-release

@dhellmann

Copy link
Copy Markdown

Should the hold be removed from this one now that openshift/console#10089 has merged?

@gabemontero

Copy link
Copy Markdown
Contributor Author

it should @dhellmann

/hold cancel

@openshift-ci openshift-ci Bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 22, 2021
@dhellmann dhellmann added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Sep 23, 2021
@openshift-merge-robot openshift-merge-robot merged commit 1892553 into openshift:release-4.7 Sep 23, 2021
@openshift-ci

openshift-ci Bot commented Sep 23, 2021

Copy link
Copy Markdown
Contributor

@gabemontero: All pull requests linked via external trackers have merged:

Bugzilla bug 2001977 has been moved to the MODIFIED state.

Details

In response to this:

Bug 2001977: delete hello-openshift in payload imagestream

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@gabemontero gabemontero deleted the proper-rm-hello-openshift-47 branch September 23, 2021 17:32
@gabemontero

Copy link
Copy Markdown
Contributor Author

/assign @jitendar-singh

we need a QA approval label as part of moving forward with this backport of bz you have validated in later versions

thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants