Skip to content

NO-JIRA: remove unused clusterrolebinding default-account-cluster-network-operator#2725

Merged
openshift-merge-bot[bot] merged 1 commit into
openshift:masterfrom
lance5890:rm_default-account-cluster-network-operator
Jun 18, 2025
Merged

NO-JIRA: remove unused clusterrolebinding default-account-cluster-network-operator#2725
openshift-merge-bot[bot] merged 1 commit into
openshift:masterfrom
lance5890:rm_default-account-cluster-network-operator

Conversation

@lance5890

@lance5890 lance5890 commented Jun 16, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor
  1. The default-account-cluster-network-operator ClusterRoleBinding only worke when upgrade from 4.15
  2. cleanup the unused yaml in newest(4.20) version
  3. kind of subsequent optimization measures of OCPBUGS-11179: change CNO to use custom ServiceAccount #2084

address openshift/cluster-version-operator#1207

@openshift-ci openshift-ci Bot requested review from trozet and tssurya June 16, 2025 01:29
@openshift-ci openshift-ci Bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jun 16, 2025
@openshift-ci

openshift-ci Bot commented Jun 16, 2025

Copy link
Copy Markdown
Contributor

Hi @lance5890. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@lance5890 lance5890 changed the title cleanup unsed clusterrolebinding default-account-cluster-network-oper… NO_JIRA: rm unsed clusterrolebinding default-account-cluster-network-oper… Jun 16, 2025
@lance5890

lance5890 commented Jun 16, 2025

Copy link
Copy Markdown
Contributor Author

/cc @jcaamano

@openshift-ci openshift-ci Bot requested a review from jcaamano June 16, 2025 01:33
lance5890
lance5890 commented Jun 16, 2025
View reviewed changes
Comment thread manifests/0000_70_cluster-network-operator_02_rbac.yaml
@jcaamano

jcaamano commented Jun 17, 2025

Copy link
Copy Markdown
Contributor

@lance5890 can you explain what triggered this change?

@lance5890

lance5890 commented Jun 17, 2025

Copy link
Copy Markdown
Contributor Author

@lance5890 can you explain what triggered this change?

no exact issue, I just found this yaml is not exists in the 4.18 version, and the cvo will also skip this yaml, so maybe clean this yaml would be more concise for the manifest dir

@jcaamano

jcaamano commented Jun 17, 2025

Copy link
Copy Markdown
Contributor

/lgtm
/approve

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Jun 17, 2025
@jcaamano

jcaamano commented Jun 17, 2025

Copy link
Copy Markdown
Contributor

/lgtm cancel

jcaamano
jcaamano reviewed Jun 17, 2025
View reviewed changes
Comment thread manifests/0000_70_cluster-network-operator_02_rbac.yaml Outdated
@openshift-ci openshift-ci Bot removed the lgtm Indicates that a PR is ready to be merged. label Jun 17, 2025
@lance5890 lance5890 force-pushed the rm_default-account-cluster-network-operator branch from 06d5111 to a846d81 Compare June 17, 2025 11:12
@jcaamano

jcaamano commented Jun 17, 2025

Copy link
Copy Markdown
Contributor

@lance5890 could you squash into a single commit?

@lance5890
cleanup unsed clusterrolebinding default-account-cluster-network-oper…
5bb6872 
…ator

Signed-off-by: lan.tian <lance5890@163.com>
@lance5890 lance5890 force-pushed the rm_default-account-cluster-network-operator branch from a846d81 to 5bb6872 Compare June 18, 2025 01:24
@lance5890

lance5890 commented Jun 18, 2025

Copy link
Copy Markdown
Contributor Author

@lance5890 could you squash into a single commit?

squashed, please review again

@jcaamano

jcaamano commented Jun 18, 2025

Copy link
Copy Markdown
Contributor

/ok-to-test

@openshift-ci openshift-ci Bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jun 18, 2025
@jcaamano

jcaamano commented Jun 18, 2025

Copy link
Copy Markdown
Contributor

/retitle NO-JIRA: remove unused clusterrolebinding default-account-cluster-network-operator

@jcaamano

jcaamano commented Jun 18, 2025

Copy link
Copy Markdown
Contributor

/lgtm
/approve

@openshift-ci openshift-ci Bot changed the title NO_JIRA: rm unsed clusterrolebinding default-account-cluster-network-oper… NO-JIRA: remove unused clusterrolebinding default-account-cluster-network-operator Jun 18, 2025
@openshift-ci-robot

openshift-ci-robot commented Jun 18, 2025

Copy link
Copy Markdown
Contributor

@lance5890: This pull request explicitly references no jira issue.

Details

In response to this:

  1. The default-account-cluster-network-operator ClusterRoleBinding only worke when upgrade from 4.15
  2. cleanup the unused yaml in newest(4.20) version
  3. kind of subsequent optimization measures of OCPBUGS-11179: change CNO to use custom ServiceAccount #2084

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jun 18, 2025
@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Jun 18, 2025
@openshift-ci

openshift-ci Bot commented Jun 18, 2025

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jcaamano, lance5890

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 18, 2025
@openshift-merge-bot openshift-merge-bot Bot merged commit 4aa7fea into openshift:master Jun 18, 2025
33 of 41 checks passed
@openshift-ci

openshift-ci Bot commented Jun 18, 2025

Copy link
Copy Markdown
Contributor

@lance5890: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/4.20-upgrade-from-stable-4.19-e2e-aws-ovn-upgrade 5bb6872 link false /test 4.20-upgrade-from-stable-4.19-e2e-aws-ovn-upgrade
ci/prow/e2e-vsphere-ovn-dualstack-primaryv6 5bb6872 link false /test e2e-vsphere-ovn-dualstack-primaryv6
ci/prow/4.20-upgrade-from-stable-4.19-e2e-azure-ovn-upgrade 5bb6872 link false /test 4.20-upgrade-from-stable-4.19-e2e-azure-ovn-upgrade
ci/prow/e2e-ovn-hybrid-step-registry 5bb6872 link false /test e2e-ovn-hybrid-step-registry
ci/prow/e2e-openstack-ovn 5bb6872 link false /test e2e-openstack-ovn
ci/prow/4.20-upgrade-from-stable-4.19-e2e-gcp-ovn-upgrade 5bb6872 link false /test 4.20-upgrade-from-stable-4.19-e2e-gcp-ovn-upgrade
ci/prow/security 5bb6872 link false /test security

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-bot

openshift-bot commented Jun 18, 2025

Copy link
Copy Markdown
Contributor

[ART PR BUILD NOTIFIER]

Distgit: cluster-network-operator
This PR has been included in build cluster-network-operator-container-v4.20.0-202506181441.p0.g4aa7fea.assembly.stream.el9.
All builds following this will include this PR.

This was referenced Jul 1, 2025
Closed
Closed
@clarku clarku mentioned this pull request Aug 1, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@trozet trozet Awaiting requested review from trozet

@tssurya tssurya Awaiting requested review from tssurya

1 more reviewer

@jcaamano jcaamano jcaamano left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@jcaamano jcaamano

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@lance5890 @jcaamano @openshift-ci-robot @openshift-bot