Bug 2028054: Ensure old deployment is deleted before new deployment creation#157
Conversation
|
@JoelSpeed: This pull request references Bugzilla bug 2028054, which is invalid:
Comment DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/bugzilla refresh |
|
@JoelSpeed: This pull request references Bugzilla bug 2028054, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
Requesting review from QA contact: DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Fedosin, wking The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
3 similar comments
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
|
@JoelSpeed: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
@JoelSpeed: All pull requests linked via external trackers have merged: Bugzilla bug 2028054 has been moved to the MODIFIED state. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/cherry-pick release-4.9 |
|
@vrutkovs: new pull request created: #162 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
We have seen instances during upgrades from 4.8 to 4.9 in which the deployments end up stuck on leader election due to the new deployment being created before the old deployment (possibly).
At the moment, the CVO doesn't wait on deployments to become ready, but if it did, our current ordering (tombstone after new deployment) could block the application of the manifests.
To avoid this possible conflict, we should make sure that the tombstone comes before the deployment manifest.
@wking Would you be able to sanity check this from the CVO side, I've moved the tombstone to a lower numbered manifest which I believe should guarantee it to be actioned before the new deployment