Skip to content

NO-JIRA: Remove tombstones yamls#348

Merged
openshift-merge-bot[bot] merged 1 commit into
openshift:mainfrom
lance5890:rm_99_tombstones
Jul 2, 2025
Merged

NO-JIRA: Remove tombstones yamls#348
openshift-merge-bot[bot] merged 1 commit into
openshift:mainfrom
lance5890:rm_99_tombstones

Conversation

@lance5890

@lance5890 lance5890 commented Jul 2, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

kind of post-cleanup of #214

address openshift/cluster-version-operator#1207

@openshift-ci-robot

openshift-ci-robot commented Jul 2, 2025

Copy link
Copy Markdown
Contributor

@lance5890: This pull request explicitly references no jira issue.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jul 2, 2025
@openshift-ci openshift-ci Bot requested review from sub-mod and theobarberbany July 2, 2025 01:08
@openshift-ci

openshift-ci Bot commented Jul 2, 2025

Copy link
Copy Markdown
Contributor

Hi @lance5890. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci openshift-ci Bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jul 2, 2025
@lance5890

lance5890 commented Jul 2, 2025

Copy link
Copy Markdown
Contributor Author

/cc @JoelSpeed

@openshift-ci openshift-ci Bot requested a review from JoelSpeed July 2, 2025 01:09
@lance5890

lance5890 commented Jul 2, 2025

Copy link
Copy Markdown
Contributor Author

@elmiko

@lance5890 lance5890 mentioned this pull request Jul 2, 2025
Closed
12 tasks
@JoelSpeed

JoelSpeed commented Jul 2, 2025

Copy link
Copy Markdown
Contributor

/approve
/lgtm
/ok-to-test

@openshift-ci openshift-ci Bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jul 2, 2025
@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Jul 2, 2025
@openshift-ci

openshift-ci Bot commented Jul 2, 2025

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JoelSpeed

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 2, 2025
@openshift-ci-robot

openshift-ci-robot commented Jul 2, 2025

Copy link
Copy Markdown
Contributor

/retest-required

Remaining retests: 0 against base HEAD 51d0fd6 and 2 for PR HEAD 18c8a8d in total

@elmiko

elmiko commented Jul 2, 2025

Copy link
Copy Markdown
Contributor

change lgtm, i wouldn't have expected the failure we are seeing in the test. i don't think it's related to this change though.

/retest

@openshift-merge-bot openshift-merge-bot Bot merged commit 95ce1db into openshift:main Jul 2, 2025
13 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sub-mod sub-mod Awaiting requested review from sub-mod

@theobarberbany theobarberbany Awaiting requested review from theobarberbany

@JoelSpeed JoelSpeed Awaiting requested review from JoelSpeed

Assignees

@JoelSpeed JoelSpeed

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@lance5890 @openshift-ci-robot @JoelSpeed @elmiko