Skip to content

NO-JIRA: Remove deleted service yaml#880

Closed
lance5890 wants to merge 1 commit into
openshift:masterfrom
lance5890:rm_deleted_controller-manager-service
Closed

NO-JIRA: Remove deleted service yaml#880
lance5890 wants to merge 1 commit into
openshift:masterfrom
lance5890:rm_deleted_controller-manager-service

Conversation

@lance5890

@lance5890 lance5890 commented Jun 30, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

kind of post-cleanup of #388

address openshift/cluster-version-operator#1207

this only works when upgrade, cvo will skip this yaml in new version

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jun 30, 2025
@openshift-ci-robot

openshift-ci-robot commented Jun 30, 2025

Copy link
Copy Markdown
Contributor

@lance5890: This pull request explicitly references no jira issue.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci Bot requested review from dlom and suhanime June 30, 2025 06:13
@openshift-ci

openshift-ci Bot commented Jun 30, 2025

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: lance5890
Once this PR has been reviewed and has the lgtm label, please assign jstuever for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jun 30, 2025
@openshift-ci

openshift-ci Bot commented Jun 30, 2025

Copy link
Copy Markdown
Contributor

Hi @lance5890. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@lance5890

lance5890 commented Jun 30, 2025

Copy link
Copy Markdown
Contributor Author

/cc @wking

@openshift-ci openshift-ci Bot requested a review from wking June 30, 2025 06:14
lance5890
lance5890 commented Jun 30, 2025
View reviewed changes
Comment thread manifests/01-service-delete.yaml
annotations:
capability.openshift.io/name: CloudCredential
include.release.openshift.io/self-managed-high-availability: "true"
release.openshift.io/delete: "true"

@lance5890 lance5890 Jun 30, 2025

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cvo will skip this yaml with the annotation, only works when upgrade from older version

This was referenced Jul 1, 2025
Closed
Closed
@lance5890

lance5890 commented Sep 10, 2025

Copy link
Copy Markdown
Contributor Author

/cc @jstuever

@openshift-ci openshift-ci Bot requested a review from jstuever September 10, 2025 05:40
@openshift-bot

openshift-bot commented Dec 9, 2025

Copy link
Copy Markdown
Contributor

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@openshift-ci openshift-ci Bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Dec 9, 2025
@openshift-bot

openshift-bot commented Jan 9, 2026

Copy link
Copy Markdown
Contributor

Stale issues rot after 30d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle rotten
/remove-lifecycle stale

@openshift-ci openshift-ci Bot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Jan 9, 2026
@openshift-bot

openshift-bot commented Feb 8, 2026

Copy link
Copy Markdown
Contributor

Rotten issues close after 30d of inactivity.

Reopen the issue by commenting /reopen.
Mark the issue as fresh by commenting /remove-lifecycle rotten.
Exclude this issue from closing again by commenting /lifecycle frozen.

/close

@openshift-ci openshift-ci Bot closed this Feb 8, 2026
@openshift-ci

openshift-ci Bot commented Feb 8, 2026

Copy link
Copy Markdown
Contributor

@openshift-bot: Closed this PR.

Details

In response to this:

Rotten issues close after 30d of inactivity.

Reopen the issue by commenting /reopen.
Mark the issue as fresh by commenting /remove-lifecycle rotten.
Exclude this issue from closing again by commenting /lifecycle frozen.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dlom dlom Awaiting requested review from dlom

@suhanime suhanime Awaiting requested review from suhanime

@wking wking Awaiting requested review from wking

@jstuever jstuever Awaiting requested review from jstuever

Assignees

No one assigned

Labels

jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@lance5890 @openshift-ci-robot @openshift-bot