Conversation
go get k8s.io/api@v0.34.1 k8s.io/apimachinery@v0.34.1 k8s.io/client-go@v0.34.1 k8s.io/client-go@v0.34.1 k8s.io/code-generator@v0.34.1 go mod tidy go mod vendor make update go mod tidy go mod vendor
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: joelsmith The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
@joelsmith: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
Changes look good, but I don't believe we are able to merge this right now While the 1.34 rebase has not landed on k/k, we cannot update openshift/api to 1.34. Until that happens, bumping client-go to 1.34 would mean that folks would not be able to update o/api and o/client-go together. While their deps are not in lockstep, this could break development across the org. Where has this latency affected you? |
I'm doing the cluster autoscaler operator 1.34 chores and updating its deps exposes a need for an update here. Probably we should close this in favor of #332, which somehow I missed when I opened this one. Fingers crossed that the k/k 1.34 downstream rebase can land soon! /close |
|
@joelsmith: Closed this PR. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
This should fix build errors where the k8s libraries have been updated but OpenShift is still using the old k8s libraries, like this: