Skip to content

NO-JIRA: e2e: Add unix timestamp to WAF ACL names to avoid conflicts#145

Merged
alebedev87 merged 1 commit intoopenshift:mainfrom
alebedev87:fix-e2e-waf-acl-name-clash
Dec 18, 2024
Merged

NO-JIRA: e2e: Add unix timestamp to WAF ACL names to avoid conflicts#145
alebedev87 merged 1 commit intoopenshift:mainfrom
alebedev87:fix-e2e-waf-acl-name-clash

Conversation

@alebedev87
Copy link
Copy Markdown
Contributor

@alebedev87 alebedev87 commented Dec 17, 2024

WAF ACL may be create by one CI job but removed by another which may result into failed e2e test cases.
This commit adds Unix timestamp to WAF ACL names to minimize the occurrence of such situations.

@alebedev87
e2e: Add unix timestamp to WAF ACL names to avoid conflicts
770bfed 
WAF ACL may be create by one CI job but removed by another which may result into failed e2e test cases.
This commit adds Unix timestamp to WAF ACL names to minimize the occurrence of such situations.
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Dec 17, 2024
@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Dec 17, 2024

@alebedev87: This pull request explicitly references no jira issue.

Details

In response to this:

WAF ACL may be create by one CI job but removed by another which may result into failed e2e test cases.
This commit adds Unix timestamp to WAF ACL names to minimize the occurrence of such situations.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested review from Miciah and rfredette December 17, 2024 22:55
@alebedev87 alebedev87 mentioned this pull request Dec 17, 2024
Merged
@alebedev87
Copy link
Copy Markdown
Contributor Author

alebedev87 commented Dec 18, 2024

/label docs-approved
/label qe-approved
/label px-approved

Just a technical change in e2e tests.

@openshift-ci openshift-ci bot added docs-approved Signifies that Docs has signed off on this PR qe-approved Signifies that QE has signed off on this PR px-approved Signifies that Product Support has signed off on this PR labels Dec 18, 2024
@alebedev87
Copy link
Copy Markdown
Contributor Author

alebedev87 commented Dec 18, 2024

/approve

I don't think I can but let's try.

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci bot commented Dec 18, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alebedev87

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 18, 2024
@ShudiLi
Copy link
Copy Markdown
Member

ShudiLi commented Dec 18, 2024

/label qe-approved
thanks

@ShudiLi
Copy link
Copy Markdown
Member

ShudiLi commented Dec 18, 2024

/lgtm
thanks

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Dec 18, 2024
@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Dec 18, 2024

/retest-required

Remaining retests: 0 against base HEAD 82a317a and 2 for PR HEAD 770bfed in total

@alebedev87
Copy link
Copy Markdown
Contributor Author

alebedev87 commented Dec 18, 2024

/override ci/prow/e2e-aws-proxy-operator

The blackhole networking deprovision failed, not related to the change or anything we do.

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci bot commented Dec 18, 2024

@alebedev87: Overrode contexts on behalf of alebedev87: ci/prow/e2e-aws-proxy-operator

Details

In response to this:

/override ci/prow/e2e-aws-proxy-operator

The blackhole networking deprovision failed, not related to the change or anything we do.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci bot commented Dec 18, 2024

@alebedev87: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@alebedev87 alebedev87 merged commit ea53812 into openshift:main Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Miciah Miciah Awaiting requested review from Miciah

@rfredette rfredette Awaiting requested review from rfredette

Assignees

@ShudiLi ShudiLi

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. docs-approved Signifies that Docs has signed off on this PR jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. px-approved Signifies that Product Support has signed off on this PR qe-approved Signifies that QE has signed off on this PR

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@alebedev87 @openshift-ci-robot @ShudiLi