Skip to content

config/v1: add clusterversions CRD from CVO#495

Merged
openshift-merge-robot merged 4 commits intoopenshift:masterfrom
sttts:sttts-config-v1-clusterversions-crd
Oct 28, 2019
Merged

config/v1: add clusterversions CRD from CVO#495
openshift-merge-robot merged 4 commits intoopenshift:masterfrom
sttts:sttts-config-v1-clusterversions-crd

Conversation

@sttts
Copy link
Copy Markdown
Contributor

@sttts sttts commented Oct 25, 2019 •
edited
Loading

First half of the move of CRDs to openshift/api for CVO.

@openshift-ci-robot openshift-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Oct 25, 2019
@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 25, 2019
@sttts sttts force-pushed the sttts-config-v1-clusterversions-crd branch 2 times, most recently from 04de2b9 to b9098bd Compare October 25, 2019 13:50
soltysh
soltysh approved these changes Oct 25, 2019
View reviewed changes
Copy link
Copy Markdown
Contributor

@soltysh soltysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/hold
until we land #496

@openshift-ci-robot openshift-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm Indicates that a PR is ready to be merged. labels Oct 25, 2019
@soltysh
Copy link
Copy Markdown
Contributor

soltysh commented Oct 25, 2019

/retest

@sttts sttts force-pushed the sttts-config-v1-clusterversions-crd branch from b9098bd to e4cf4da Compare October 25, 2019 14:14
@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Oct 25, 2019
soltysh
soltysh approved these changes Oct 25, 2019
View reviewed changes
Copy link
Copy Markdown
Contributor

@soltysh soltysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 25, 2019
@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Oct 25, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: soltysh, sttts

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@soltysh
Copy link
Copy Markdown
Contributor

soltysh commented Oct 25, 2019

@abhinavdahiya ptal, since that's the piece of code you own.

@sttts
Copy link
Copy Markdown
Contributor Author

sttts commented Oct 28, 2019

/hold cancel

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 28, 2019
@openshift-merge-robot openshift-merge-robot merged commit 0c4d384 into openshift:master Oct 28, 2019
@sttts sttts mentioned this pull request Oct 28, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@abhinavdahiya abhinavdahiya Awaiting requested review from abhinavdahiya

@adambkaplan adambkaplan Awaiting requested review from adambkaplan

1 more reviewer

@soltysh soltysh soltysh approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@soltysh soltysh

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@sttts @soltysh @openshift-ci-robot @openshift-merge-robot